From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C731A45A42; Fri, 27 Sep 2024 11:35:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E43F4025D; Fri, 27 Sep 2024 11:35:17 +0200 (CEST) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by mails.dpdk.org (Postfix) with ESMTP id 9F98A4021E for ; Fri, 27 Sep 2024 11:35:16 +0200 (CEST) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2f7657f9f62so23327811fa.3 for ; Fri, 27 Sep 2024 02:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1727429716; x=1728034516; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1XIFXBaHefWV6v4AQhwW6y7IXci6z5M04Gy5QhKOi7s=; b=CVBNNTnsLr1KUd+Zghc8L15VAaf1tuVzMpe+CPiWlSVguACW4wbmqXoA7Fi6aCtPKv dt9Xt6BVGZbGHTvl0iQ52IGU0hu/XboIbrUYh+rYg5EEe+fz/1p85NvBVrPY2Ffwb26g sNILFT73nunHYU6HBUvJ2MuSqsYmQLcr7OJ4ZwNv9qL+L0hSNFKrr0bVHPz7ezffuS7m aJ9FHQAAuUM/evEhYtdKxC46RpUeW4xVoCFuuGdPhykg4cDP7I+CIPR0oXAN1qkvfsVx kPoaaE6b44CarJRcIhO4qRZvdTwQ+JMt2ZJi44C2sIGKTvEJFzZsAY5zy4JO2eEOvt2L gYaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727429716; x=1728034516; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1XIFXBaHefWV6v4AQhwW6y7IXci6z5M04Gy5QhKOi7s=; b=CIdeZq/0m8dFP0EEkWD4tvAS9GreoasBIt2Bo3m2c6O87ZJbA64mICPAAPLjfzxbey IasjX7JCa4utkl+hzE3KwZYRD2BN/I60V3RaXs/V2ClRo9M8RBkBfilOxf8Qrc0e6vCn GvXA59GRgb387vbPv+x0HXd87a+dHx2DThFu/12pHJVEX6QVAWsrti5R5Y8d+vUHCvIv 5bZRmYVJXck6Hdptut6JynPG3iGWnjPFQ5gKwfC2g5GISnFgQ5koQ8NIrdNdn4jKxFZn PsLKn2YmTNDAdfhl6CcNQ+OLXFk6JUMrlb44nZUXoai2gHXrjqADaN/C99OKAJh0qm49 y7vg== X-Forwarded-Encrypted: i=1; AJvYcCUTJ6y1v8oHJRNBMP3vfSqyTfP0Pai//HFrs35EeJ1YkfMtvmEzXmNPMNt+OA6cr4eWIGM=@dpdk.org X-Gm-Message-State: AOJu0YzXzMQAqC/EaNfSiRzFfQ6W6sLvIJHxSdiEmiZ5o4NmeOebpz6q kpqvLQMeo2TIsSNQSN7/IZDNGJ9Hd5x5EMj4dN9n1LRBcEO81wIJEeDSk+e/w4QKASUy5bgMlmj mVu4= X-Google-Smtp-Source: AGHT+IGPIZmGhDxNK/2rlG3mfyrb3NsPnVsr0nGLau7NgtmFVBbWTEHkqfdfg1lWgi/mzk5wPtUXrw== X-Received: by 2002:a05:600c:1ca1:b0:42a:a6aa:4135 with SMTP id 5b1f17b1804b1-42f5844cbd7mr16531955e9.20.1727429704780; Fri, 27 Sep 2024 02:35:04 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f57de11aasm20704955e9.16.2024.09.27.02.35.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 02:35:04 -0700 (PDT) Message-ID: <35c06abc-7c69-416c-bfd8-d59c3db60bf1@pantheon.tech> Date: Fri, 27 Sep 2024 11:35:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell To: Jeremy Spewock Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, wathsala.vithanage@arm.com, alex.chapman@arm.com, Luca.Vizzarro@arm.com, probb@iol.unh.edu, yoan.picchi@foss.arm.com, paul.szczepanek@arm.com, npratte@iol.unh.edu, dev@dpdk.org References: <20240605175227.7003-1-jspewock@iol.unh.edu> <20240925173727.14111-1-jspewock@iol.unh.edu> <20240925173727.14111-2-jspewock@iol.unh.edu> <15a9640e-72cd-482d-9a3b-1e89c3e6d57c@pantheon.tech> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >>> + Note that the order of inheritance is important for this class. In order to instantiate this >>> + class, the abstract methods of :class:`~.capturing_traffic_generator.CapturingTrafficGenerator` >>> + must be implemented. Since some of these methods are implemented in the underlying interactive >>> + shell, according to Python's Method Resolution Order (MRO), the interactive shell must come >>> + first. >> >> I didn't notice this before. Is this because of the close() method? Do >> we need to add any special steps to close the TG? Closing the >> interactive session should be enough, but I wanted to check with you. > > Yes it is because of the close method in the traffic generator. I > think closing the shell should be all we need to do really, there > isn't anything else this traffic generator is really using on the > host. > Ok, thanks. We can keep it this way then.