From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id CA1A5A04B5;
Wed, 30 Sep 2020 14:57:39 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 5EC471D614;
Wed, 30 Sep 2020 14:57:37 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id BD6181D577
for <dev@dpdk.org>; Wed, 30 Sep 2020 14:57:35 +0200 (CEST)
IronPort-SDR: RlHOsHmRxtU/YjB2H/I7znkUTpr46ksIKWgTU2m56W7O3IkWF9mu/P5SwXmlwzcCbr4RH2Kw7m
+RMI/hdLoe5g==
X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="150221586"
X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="150221586"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
30 Sep 2020 05:57:33 -0700
IronPort-SDR: y0tmHWf8bywGLGuvI0RmszHwL5mMPyrUMQ9WgLwWiRujTKatIJohF0Q9WahuKNQZUNXuyfZKvu
qE+uLgaTWeJA==
X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="497434974"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.251.186])
([10.213.251.186])
by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
30 Sep 2020 05:57:31 -0700
To: Lijun Ou <oulijun@huawei.com>, wenzhuo.lu@intel.com,
beilei.xing@intel.com, adrien.mazarguil@6wind.com
Cc: dev@dpdk.org, linuxarm@huawei.com
References: <1599702678-11142-1-git-send-email-oulijun@huawei.com>
<1600955105-53176-1-git-send-email-oulijun@huawei.com>
<1600955105-53176-2-git-send-email-oulijun@huawei.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <35e9e9bb-50fa-d76f-46b0-c9556c84114b@intel.com>
Date: Wed, 30 Sep 2020 13:57:28 +0100
MIME-Version: 1.0
In-Reply-To: <1600955105-53176-2-git-send-email-oulijun@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key
configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 9/24/2020 2:45 PM, Lijun Ou wrote:
> It use the NIC valid default RSS key instead of the testpmd
> dummy RSS key in the flow configuration when the RSS key is
> not specified in the flow rule. If the NIC RSS key is
> invalid, it will use testpmd dummy RSS key as the default
> key.
Can you please describe the impact, what fails without this fix?
>
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> V3->V4:
> -fix checkpatch warning and shorter commit content.
>
> V2->V3:
> -fix checkpatch warning.
>
> V1->V2:
> -fix the commit.
> ---
> app/test-pmd/cmdline_flow.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 6263d30..e6648da 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -4312,6 +4312,7 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,
> action_rss_data->queue[i] = i;
> if (!port_id_is_invalid(ctx->port, DISABLED_WARN) &&
> ctx->port != (portid_t)RTE_PORT_ALL) {
> + struct rte_eth_rss_conf rss_conf = {0};
> struct rte_eth_dev_info info;
> int ret2;
>
> @@ -4322,6 +4323,13 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,
> action_rss_data->conf.key_len =
> RTE_MIN(sizeof(action_rss_data->key),
> info.hash_key_size);
> +
> + rss_conf.rss_key_len = sizeof(action_rss_data->key);
> + rss_conf.rss_key = action_rss_data->key;
'rss_conf.rss_key_len' is the input parameter, it looks like it has been used as
the size of the 'rss_key', but as far as I can see it is not.
Because of this if 'info.hash_key_size' is bigger than
'sizeof(action_rss_data->key)', won't PMD overwrite the stack for the remaining
bytes?
Can you please check?
> + ret2 = rte_eth_dev_rss_hash_conf_get(ctx->port, &rss_conf);
> + if (ret2 != 0)
> + return ret2;
If PMD not implemented the 'rss_hash_conf_get' dev_ops, should it fail the RSS
action?
> + action_rss_data->conf.key = rss_conf.rss_key;
> }
> action->conf = &action_rss_data->conf;
> return ret;
>