From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EBF9A0C47; Thu, 7 Oct 2021 14:39:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF890411BB; Thu, 7 Oct 2021 14:39:46 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id F259B41137 for <dev@dpdk.org>; Thu, 7 Oct 2021 14:39:45 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 41426580F3C; Thu, 7 Oct 2021 08:39:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 07 Oct 2021 08:39:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= MBzt4hsZGHWwZDY9kKYirCd837RaF/GGTaf+4w/Wspw=; b=pBWSrSzS/Jmc/QK2 XQ67vhuEXkS3GqeRiT4vFJ+m1s4B3WG0xRwOGJ6fDkHIS3UMDs4P6+8t/CYuC4bz LKodYR6sioV8wnF1RtepCsWXBl0A4pBkQfWuZVDwY7TCDMkseON1JhOhoijsKtLa feDSgdSMn/74sSOXi5FGOFVy8JmYKy4QgJVpJLhkMkHmQ2EOS64jVpFxpvKDh4Gk CQIMzoVwVb1vne1+F4NZMRW6p9ldczabipsLHlIQ4hBh1tC9Qvj2RRoOf2IkfdGm Qp1MevD3VkHrDeFM27+alfzMB5zGnUTiQBuvHMf23AmLbUe3x58nofUM4XuprUnz UH4qNw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MBzt4hsZGHWwZDY9kKYirCd837RaF/GGTaf+4w/Ws pw=; b=bBLPfVNqu2SO0jp415RavPSVou8Vv/Cx+7BYbBAJkBJIJcJchve+z+6bm BxgEcHHVjdDv2k84AF0URUw8tgQI2+JGGmRRicZdkmz7gDIJw65sp48+N4UQ2SXw XPl9wGc5QvvDVrveZu68h6sEQxTg08xNczPt8Oqp74FHKSl5dtfJbVvhQvF+HCip nkzCaxII9C9eIndAUVkrQrLs06A3Guq9E67sZlnXDQTkesr63ynb5u6iR3XhOW+B 5GRSXmqs2CMhlHgWJ+LPKZy4xlQDYYg3FhNpOR7lXPsscwcChKtZ+f/LGJ9Dd0fX KGqV7P1y8FP2ICf1vtGEuZexMwlWQ== X-ME-Sender: <xms:jupeYUBXq5xOgiir1EMcLdmXGg9QN3BCDeBffU82RpqpnuqXE2qHbA> <xme:jupeYWjCTdw8j7v_T_R8vncT8B4QMNNQq92DWupanKthjU5LmJEif8xFNGlhE-b4r u0tziqirseOhNwS5Q> X-ME-Received: <xmr:jupeYXmOBQnMlI2g0xOmKa_Qq6-4umF6CxAy0swpfbBpC_82VtdHjYMsAacGc-skk3MWYw8BL65sabbDNyo_ljHmCOs1L4WZ1qfcX9xK> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelkedgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:jupeYazLzV_5k48681_jm2com1t6lIA2RQwxM-EQW8LiRdqVqbytsQ> <xmx:jupeYZQEcNZ7OVcPtOSjeaJyHlBKgntRbJTQ6IH9fAvzmyEy81hicg> <xmx:jupeYVaHJQM-zer7MZDPIJCfQOgeGpvCGKrwuJHX1B1qprMo5hc8KQ> <xmx:kOpeYYIGOyAUwwtnMDfSZZhpAA5cW0Jj8rxBHYErjmuCMrILREVHQQ> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Oct 2021 08:39:39 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru> Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com>, John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>, Beilei Xing <beilei.xing@intel.com>, Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Haiyue Wang <haiyue.wang@intel.com>, Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org Date: Thu, 07 Oct 2021 14:39:36 +0200 Message-ID: <3600492.CjBm2xMtKD@thomas> In-Reply-To: <f9adb934-9ddd-f64c-c94a-fe3a17e47b4c@oktetlabs.ru> References: <20210712161747.958019-1-andrew.rybchenko@oktetlabs.ru> <14586794.58kHr3nmNG@thomas> <f9adb934-9ddd-f64c-c94a-fe3a17e47b4c@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 07/10/2021 12:20, Andrew Rybchenko: > On 10/6/21 12:56 AM, Thomas Monjalon wrote: > > 13/09/2021 13:26, Andrew Rybchenko: > >> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru> > >> > >> Getting a list of representors from a representor does not make sense. > >> Instead, a parent device should be used. > > > > I don't understand which issue it is fixing. > > This function was not working before if not using the backer port? > > The function, rte_eth_representor_id_get(), is used in > eth_representor_cmp() which is required in ethdev class > iterator to search ethdev port ID by name (representor case). > Before the patch the function is called on the representor > itself it tries to get representors info to match. > > It was found by OvS+DPDK testing: > 1. OvS hotplugs representor > 2. OvS tries to find DPDK port ID for just hotplugged > representor and fails (if PMD does not provider > representors info on the representor itself) > > > Is it fixing a specific PMD? > > It is a generic fix for PMD which do *not* provide representors > info on the representor itself. This is the key information. Please reword the commit log.