From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 857FD45B68; Fri, 18 Oct 2024 10:37:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B11640268; Fri, 18 Oct 2024 10:37:53 +0200 (CEST) Received: from fout-a4-smtp.messagingengine.com (fout-a4-smtp.messagingengine.com [103.168.172.147]) by mails.dpdk.org (Postfix) with ESMTP id B7EB740265 for <dev@dpdk.org>; Fri, 18 Oct 2024 10:37:51 +0200 (CEST) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 456781380391; Fri, 18 Oct 2024 04:37:51 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Fri, 18 Oct 2024 04:37:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1729240671; x=1729327071; bh=Rn/0EnhCj4tVg/Vejf/qVM9I6ZmElA6zLlGSL1sQw7c=; b= Bm6T03Iuw235/R586ZX0Nm30yrchJaTUDIi4g7RUjUsaxn5GHRhTdFYRq4FzMmnL oVtHeLTcrxXOc+eDipJHMDQeU1dyURa9dp34OKsmMFuirUcDEHuKpKFwtmCegxJ2 vUWaGx9Z53dpBeKjGHJtuz86zQgSi4+QoX00mo3uuyWh9WcdE28WZYOi9UPa+WdH oT9lz9dQ8jV3PMUhfSbp4g/4O3De3gqcOs6eocn5ReIEcXvLaTlchh2kJIYorPia HydphapMc4JfSAyl/iux/FsJqwNBUjc9263fn2RA1twP1WybfJ5/aSHb9T36nABB 3i8O6En0AnOZTFoDtvIe6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729240671; x= 1729327071; bh=Rn/0EnhCj4tVg/Vejf/qVM9I6ZmElA6zLlGSL1sQw7c=; b=L rsZFi1jyfNwv6AGC7L7qPky0guO7xBnCCKhn+iMhR9DyZ2MwzavnnNdH6wiVauxo dqtpnxnZqEvwmtF8xfUdQYD61tb0TJ+uk+WBEE4yLUaALhTHRLOG9wFPeudTK5Ac U0t167Op89hYPGUbbRPx9at7Hjacj8Ha5bPHKWDYJvnoqXVVWSDO/JQdUTuYQthy nd1++rol1+WTpPB4WF9Y0OEzfKr2X8Rzv7U4RJmniZJhnePctuD6ANL07l1TmbXh GR5ixJQoDNxwlYjDeg/JrUkyBcA0JfNPMpTDrJEMBRjFrMS4ap155neLHLF8PahC OyNeTIRn1J23iZSMZMMMA== X-ME-Sender: <xms:Xh4SZw819DrcaqI56RVbX0fWnQXI_wUDwsxBG5xNij8dZSy0EWX_-A> <xme:Xh4SZ4stcLU2ol5N0TCMRzC9KoPmyzaUatZ7eVWKA2yHheimux0a7TyfCbOImEt3j Jrfkau-wwLcTtld1Q> X-ME-Received: <xmr:Xh4SZ2CeMof536zjx-soGjACYN3XZnRsJhgTPDX38CR8qDMQhhOFWz5h0Uj9oSySKoPsb44qAaYDYHamQp1U1Kwm8Q> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehfedgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehnihgrlh hlrdhmvggruggvsehinhhtvghlrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdho rhhgpdhrtghpthhtohepshhtvghphhgvnhesnhgvthifohhrkhhplhhumhgsvghrrdhorh hgpdhrtghpthhtohephihiphgvnhhguddrfigrnhhgsehinhhtvghlrdgtohhmpdhrtghp thhtohepshgrmhgvhhdrghhosghrihgvlhesihhnthgvlhdrtghomhdprhgtphhtthhope gsrhhutggvrdhrihgthhgrrhgushhonhesihhnthgvlhdrtghomhdprhgtphhtthhopehv lhgrughimhhirhdrmhgvughvvggukhhinhesihhnthgvlhdrtghomh X-ME-Proxy: <xmx:Xh4SZwcbO5B9gLtKaC7goVvxuYOgjGqpM5mp_Fs1OGBTPNmPOxEfUQ> <xmx:Xh4SZ1OQKrxg3AmjE-dM9z_1jriP1DHQ6ABBf80t9Ebqi8q5SVUESg> <xmx:Xh4SZ6mhNOM9MhvJBR_ace29o9FZUsbU4SZhqX-ImqCdW8akDShjKA> <xmx:Xh4SZ3s8EA95ygtCeu2qgSMfRop60NOK8btTdnYTLNnRtnNGXbJhnA> <xmx:Xx4SZ4cwPKdkBtjyolJC7caTItk_42QZB8X5B6i2ROmT8K2fm1TcIvTn> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Oct 2024 04:37:49 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Niall Meade <niall.meade@intel.com> Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>, Yipeng Wang <yipeng1.wang@intel.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com> Subject: Re: [PATCH v4] hash: separate creation parameters checks Date: Fri, 18 Oct 2024 10:37:47 +0200 Message-ID: <3605354.som1txNFv6@thomas> In-Reply-To: <20241017151131.2499153-1-thomas@monjalon.net> References: <20240726145443.1058676-1-niall.meade@intel.com> <20241017151131.2499153-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 17/10/2024 17:10, Thomas Monjalon: > From: Niall Meade <niall.meade@intel.com> > > Separate name, entries and key_len parameter checks in rte_hash_create(). > Also make the error messages more informative/verbose > to help with debugging. > > Signed-off-by: Niall Meade <niall.meade@intel.com> > Acked-by: Stephen Hemminger <stephen@networkplumber.org> > --- > v4: formatting details > sent for triggering a new CI run The community CI lab is not in a good shape today but I take the risk applying this patch.