From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to the list
Date: Wed, 12 Aug 2015 14:52:34 +0200 [thread overview]
Message-ID: <3605610.CPCfiOFDq4@xps13> (raw)
In-Reply-To: <1439383287-28447-1-git-send-email-maciejx.t.gajdzica@intel.com>
2015-08-12 14:41, Maciej Gajdzica:
> test_table_ACL wasn't invoked when running table_autotest. Added this
> test to table_tests array to make it run with other table tests.
>
> Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
[...]
> --- a/app/test/test_table_tables.h
> +++ b/app/test/test_table_tables.h
> @@ -36,7 +36,7 @@ int test_table_lpm(void);
> int test_table_lpm_ipv6(void);
> int test_table_array(void);
> #ifdef RTE_LIBRTE_ACL
> -int test_table_acl(void);
> +int test_table_ACL(void);
Why renaming it uppercase?
Function names should be lowercase.
It is lowercase also in app/test/test_table_combined.h
next prev parent reply other threads:[~2015-08-12 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 12:41 Maciej Gajdzica
2015-08-12 12:41 ` [dpdk-dev] [PATCH 1/1] test_table: fixed failing unit tests checking offset Maciej Gajdzica
2015-08-13 10:50 ` Mrzyglod, DanielX T
2015-08-17 16:04 ` Thomas Monjalon
2015-08-12 12:52 ` Thomas Monjalon [this message]
2015-08-12 12:58 ` [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to the list Gajdzica, MaciejX T
2015-08-13 10:25 ` Gajdzica, MaciejX T
2015-08-17 14:12 ` Gajdzica, MaciejX T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3605610.CPCfiOFDq4@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=maciejx.t.gajdzica@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).