From: Thomas Monjalon <thomas@monjalon.net>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>,
mstolarchuk <mike.stolarchuk@bigswitch.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] hash: fix lock release on add
Date: Sat, 08 Jul 2017 19:00:50 +0200 [thread overview]
Message-ID: <3606313.yn4QAvqHeP@xps> (raw)
In-Reply-To: <20170707055425.9357-1-pablo.de.lara.guarch@intel.com>
07/07/2017 07:54, Pablo de Lara:
> From: mstolarchuk <mike.stolarchuk@bigswitch.com>
>
> When adding items to a hash table with multiple threads,
> there is an spinlock used to prevent data corruption
> (unless Transactional Memory is supported).
>
> If there is a failure, the spinlock should be released,
> but there were cases where that was not happening.
>
> Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel TSX")
> CC: stable@dpdk.org
>
> Signed-off-by: mstolarchuk <mike.stolarchuk@bigswitch.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-07-08 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 12:30 [dpdk-dev] [PATCH] __rte_hash_add_key_with_hash not releasing multiwriter_lock in failure paths mstolarchuk
2017-07-05 14:50 ` De Lara Guarch, Pablo
2017-07-07 13:55 ` De Lara Guarch, Pablo
2017-07-07 5:54 ` [dpdk-dev] [PATCH v2] hash: fix lock release on add Pablo de Lara
2017-07-08 17:00 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3606313.yn4QAvqHeP@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=mike.stolarchuk@bigswitch.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).