From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id ADCAF16E; Sat, 8 Jul 2017 19:00:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C6CE420847; Sat, 8 Jul 2017 13:00:51 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sat, 08 Jul 2017 13:00:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=dypE7W3Cxxq0vBe y17gstxWJYYJgAUaFBs3YKxKVnLg=; b=cIr27DUO2px8SBZ/oPp60Er6hKl5uzI t9ff/ip93i+/FRRdWxQM3Y+UboijMbdjAyg+CbzkeMMsN2w3wOqJlTIrV5rlHXJb UFxrpaKzUAZObZA4mWXSMy0FeHD9sO+vcWUgON7wIHNvZ7+iTnOU+P3J9E1fGBgd +euoOIIiyHSw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=dypE7W3Cxxq0vBey17gstxWJYYJgAUaFBs3YKxKVnLg=; b=Ky22hgYS eNEMzO4Wspu63ILV2azBvzQQtMsILbSXjoOXPvkDbFzLNI04xsgUUe7ONzuaSX0N Jcdb4T/khkdJymQyt9BftE4tvzDi96xn2SZpJ10Gl1urkZFGf66TpCk8REQG2qzg ahCivnilXF+zo6jr5eQ1+vNwYYoczeDfSE9W78OMHo5yq6GSycH47Cbrb21INagW raBX6w9fdXCodJichV20RfEPx/WEqrl8e3fC9bgM9i0WzUKdg3WuMaB857agj4cO W7I/1Y4NrHM655TDhfMO0Yrh9plOiSuLMg/HnhB4BSoV/WpzyzofbRVGjgV8ZW4F 7p+pCEx6wXMf8g== X-ME-Sender: X-Sasl-enc: 9ffQ+VQYo23IWY40RXWTabmZs9rYkw2GSNOtu89ymO61 1499533251 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6689B248BB; Sat, 8 Jul 2017 13:00:51 -0400 (EDT) From: Thomas Monjalon To: Pablo de Lara , mstolarchuk Cc: dev@dpdk.org, stable@dpdk.org Date: Sat, 08 Jul 2017 19:00:50 +0200 Message-ID: <3606313.yn4QAvqHeP@xps> In-Reply-To: <20170707055425.9357-1-pablo.de.lara.guarch@intel.com> References: <1495801830-36849-1-git-send-email-mike.stolarchuk@bigswitch.com> <20170707055425.9357-1-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] hash: fix lock release on add X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jul 2017 17:00:53 -0000 07/07/2017 07:54, Pablo de Lara: > From: mstolarchuk > > When adding items to a hash table with multiple threads, > there is an spinlock used to prevent data corruption > (unless Transactional Memory is supported). > > If there is a failure, the spinlock should be released, > but there were cases where that was not happening. > > Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel TSX") > CC: stable@dpdk.org > > Signed-off-by: mstolarchuk > Acked-by: Pablo de Lara Applied, thanks