DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Xiaoyun Li <xiaoyun.li@intel.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Rosen Xu <rosen.xu@intel.com>,
	Haiyue Wang <haiyue.wang@intel.com>, Ray Kinsella <mdr@ashroe.eu>,
	Jiawen Wu <jiawenwu@trustnetic.com>,
	Jian Wang <jianwang@trustnetic.com>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove legacy mirroring API
Date: Wed, 29 Sep 2021 10:17:55 +0200	[thread overview]
Message-ID: <3606914.QClUM3AYhQ@thomas> (raw)
In-Reply-To: <20210928161633.1082957-1-andrew.rybchenko@oktetlabs.ru>

Hi Andrew,
Thanks a lot for working on this.
I had sent the deprecation notice and forgot about it, apologies.

28/09/2021 18:16, Andrew Rybchenko:
> A more file grain flow API should be used instead of it.

Do you mean "fine-grain"?
I think we can reference the rte_flow action to be used:
	RTE_FLOW_ACTION_TYPE_SAMPLE

> --- a/doc/guides/rel_notes/release_21_11.rst
> +++ b/doc/guides/rel_notes/release_21_11.rst
> +* ethdev: Removed the port mirroring API. A more fine grain flow API may
> +  be used instead.  The structures ``rte_eth_mirror_conf`` and
> +  ``rte_eth_vlan_mirror`` and the functions ``rte_eth_mirror_rule_set``
> +  and ``rte_eth_mirror_rule_reset`` along with the associated macros
> +  ``ETH_MIRROR_*`` are removed.

Here as well we can mention the replacement RTE_FLOW_ACTION_TYPE_SAMPLE.




  reply	other threads:[~2021-09-29  8:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 16:16 Andrew Rybchenko
2021-09-29  8:17 ` Thomas Monjalon [this message]
2021-09-29  8:42   ` Andrew Rybchenko
2021-09-29  8:39 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-09-29  8:57   ` Thomas Monjalon
2021-09-30  5:38     ` Jerin Jacob
2021-09-30  5:54   ` Wang, Haiyue
2021-10-07 11:03     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3606914.QClUM3AYhQ@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=haiyue.wang@intel.com \
    --cc=jianwang@trustnetic.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=mdr@ashroe.eu \
    --cc=rosen.xu@intel.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).