From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECB8DA0547; Wed, 29 Sep 2021 10:18:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 732AD40E3C; Wed, 29 Sep 2021 10:18:01 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id B09E04068F for ; Wed, 29 Sep 2021 10:18:00 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E51BB5C01EA; Wed, 29 Sep 2021 04:17:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 29 Sep 2021 04:17:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= IUACqTINul4dgkJEWt9dglnHGPkp//DUz/yvF8leedI=; b=HOcrDSZ2yCSs+CK+ NxNjiBaEFE+vzIWJ4HeGgWIqGPftt4n2TD0ryAZhlGbOkmEHsUd0AqdZ2MfrZ+Y8 A8akKvEy4RsXOCeX07EPjsYy8aYnFAaWxNEb2qfw6q41Tnzu0Y7wHUROwYEYheMd M3gxx4autgWrDrcV2BSgBWQ6K+I/vtlJAonfWWRqXDValf4kn1anb3XP1ajk3Lui rBQCyXmaIOFPxafa+GzIkZE5LftpOehIV4Tf9msOcm+vnHM2fjYhTBAryMdv8N73 Al24+T0y94ch2Lu84rDUn/O6MwxqXNngV/es1ErxoNQ381TrvrfkayCcwaWFqCa9 R5OtsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=IUACqTINul4dgkJEWt9dglnHGPkp//DUz/yvF8lee dI=; b=mtWycKnKSYuChuLAeaWdlZ+UdyG7qaAz5WdrHncu+ESNEWkfVEw/7KDoz ZaZm2Wy2PRG16tfn04LLu8z/6IdYNx8mK+xzfHa4hQqGKp7laYtNrPI4vIWKqm1A 0xut7qWC8/dg5BgBmVc+0UrLqs9eDc9EpCRnHO25JTWkctQObzRtfmExXA42v3dT RbNlxvcHNRm71vYx3Kbw7nvS4EDzV3zfSNVZh2SGs5PdE+jefUVSBhNoFwugYJIw NjCLqEvEe/2oQMqHZOEjV6YTEwKBl6R1wWgQW85K7jxrAAPKVWuG59suIRqb7/ug 5bgEm85YHUvSXypVeNqRhus/Y9U5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 04:17:57 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: Xiaoyun Li , Ferruh Yigit , Beilei Xing , Rosen Xu , Haiyue Wang , Ray Kinsella , Jiawen Wu , Jian Wang , dev@dpdk.org Date: Wed, 29 Sep 2021 10:17:55 +0200 Message-ID: <3606914.QClUM3AYhQ@thomas> In-Reply-To: <20210928161633.1082957-1-andrew.rybchenko@oktetlabs.ru> References: <20210928161633.1082957-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: remove legacy mirroring API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew, Thanks a lot for working on this. I had sent the deprecation notice and forgot about it, apologies. 28/09/2021 18:16, Andrew Rybchenko: > A more file grain flow API should be used instead of it. Do you mean "fine-grain"? I think we can reference the rte_flow action to be used: RTE_FLOW_ACTION_TYPE_SAMPLE > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > +* ethdev: Removed the port mirroring API. A more fine grain flow API may > + be used instead. The structures ``rte_eth_mirror_conf`` and > + ``rte_eth_vlan_mirror`` and the functions ``rte_eth_mirror_rule_set`` > + and ``rte_eth_mirror_rule_reset`` along with the associated macros > + ``ETH_MIRROR_*`` are removed. Here as well we can mention the replacement RTE_FLOW_ACTION_TYPE_SAMPLE.