From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by dpdk.org (Postfix) with ESMTP id B18145686 for ; Thu, 15 Jan 2015 14:51:54 +0100 (CET) Received: by mail-we0-f170.google.com with SMTP id w61so14835999wes.1 for ; Thu, 15 Jan 2015 05:51:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Hl1HKq/siEoEiNQiMtOW5pQg94af+rtoykwjoxMVVXM=; b=Ol9JK0oLwM07EXkvh8cgKtpuryo7+0rahd3sShnx2nPPpiOP+TfdJ9X5yKF0NA85QY 9Pynva+9Kv2WDLmq+91rzJk2pV27sCWQWSU2DWmLh4WcND4nQzrAE60QorxMpdZHX7Cw K83yggJyUbEUMTFfOBLKDTJdg6y3dRh/0WGHJdY1xngg8cpTqakkPQ3JHaK+n/Peydka NS0IjbTkdwwQSEPI6Y3qIeqzcwePLXHnSrszhwoFuA8UkmNZxhs+WF1Msln29hxeVFrH qMw60Rhc4Bg+svV6lhzVfiahqUKOPZYxwfheDas1faHM5ofJnyF6QnS3a/e6bcbAGReY QRuw== X-Gm-Message-State: ALoCoQkK1rVxPzCWSfPyCj3ZtB2ApZO2KamP5bWbyTSWZjFUq8aTB4F4pt3P5d/dFMdXWI0/SMU9 X-Received: by 10.180.82.98 with SMTP id h2mr19340813wiy.7.1421329914501; Thu, 15 Jan 2015 05:51:54 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u18sm2150088wjq.42.2015.01.15.05.51.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jan 2015 05:51:53 -0800 (PST) From: Thomas Monjalon To: "Burakov, Anatoly" Date: Thu, 15 Jan 2015 14:51:31 +0100 Message-ID: <3608020.TiYYj1Dva7@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1418035455-9434-1-git-send-email-michael.qiu@intel.com> <1613897.2bqBHJQoa5@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6] VFIO: Avoid to enable vfio while the module not loaded X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 13:51:54 -0000 2015-01-15 13:42, Burakov, Anatoly: > Yep, apologies, it's my fault as it was my suggestion. > I knew there was a linuxapp-only EAL header, for some reason I thought it's eal_private. > Any suggestions on where to put this function? I don't think BSD needs this function. No, it's OK. I think it could be needed in bsd if a PMD depends on a kernel driver or try to unload one. PS: please don't top post -- Thomas > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Thursday, January 15, 2015 1:38 PM > > To: Qiu, Michael > > Cc: Burakov, Anatoly; dev@dpdk.org; Xie, Huawei > > Subject: Re: [PATCH v6] VFIO: Avoid to enable vfio while the module not > > loaded > > > > > > When vfio module is not loaded when kernel support vfio feature, the > > > > routine still try to open the container to get file description. > > > > > > > > This action is not safe, and of cause got error messages: > > > > > > > > EAL: Detected 40 lcore(s) > > > > EAL: unsupported IOMMU type! > > > > EAL: VFIO support could not be initialized > > > > EAL: Setting up memory... > > > > > > > > This may make user confuse, this patch make it reasonable and much > > > > more soomth to user. > > > > > > > > Signed-off-by: Michael Qiu > > > > > > Acked-by: Anatoly Burakov > > > > Note that rte_eal_check_module has no bsd counterpart. > > It could be needed later. > > > > Applied > > > > Thanks > > -- > > Thomas