From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42150A0350; Tue, 22 Feb 2022 15:48:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1401240DF6; Tue, 22 Feb 2022 15:48:39 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 18A1A40DF4 for ; Tue, 22 Feb 2022 15:48:38 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E61B33201FF0; Tue, 22 Feb 2022 09:48:36 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 22 Feb 2022 09:48:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=fWfeAqMGti5VkQ y5WAXlEgzucmpvsHEzgZaQZribx/Q=; b=KgKWOF0V/6XNs/ulDw1XyZnlFIRxww w+RCkbtxgwsuGukCNhVTdZI2qZeH1xg2DfYjYM4mzY+bCQ6A+mpbvM/wE3513Of1 jxsf8D1X5gXqCIHBt+52FFfOJJ28QVG6PJa7u3pp3C+gcsrASfpX05st3yCRLGCN fqUb49e6d/u/yczRbHi1veAnTZGyVk58/6y44a5UoTFEa2HfsZDsUbyKKLiluXXV iqkiXXRXoDsvv+Hp1qirIC+vIyc9a+3HbYfjzfQJ27v0SSEsRSrDw+hJ7kV0OG/K tClCmsp2tNTjvF3YsHf5I+zmQPco3cUQdNKQX2gahJ9hMQi0ov46ahsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=fWfeAqMGti5VkQy5WAXlEgzucmpvsHEzgZaQZribx /Q=; b=E0GxpQqGdY4jN6VDKfTdxX7DNC3rMh/cAYwoXsOYeFqUZYKbQLSeKPQ/8 KnvA6pTZIMjNf54FjnBr2ojfttP0+j8c01bRcMjtINTkvtNfKRGEYFdneY3W7MZa QFK6lTCbR7CUXxTbkEA3dEZUf9u/khTo2ocUYsTm/YW7dvvyu0zgcyFtcJrE13M6 N/id8DC4Fr4cextqe5Cc47yR12X3A7V9xYeXnRYvCKkj2kHBmRNFTggWKmzHKJ9k Jvr60leH1te2+EDx4iFkp04vOEjK/vITnkdECJAb1GphQ6AVn4MxnDK8V9aIJmwF C3VBESE7Vz+8hEzjU3pY3UJXmYtgg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeekgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Feb 2022 09:48:35 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Weiguo Li , dev@dpdk.org Subject: Re: [PATCH v3 1/4] kni: add define guards to avoid multi-inclusion Date: Tue, 22 Feb 2022 15:48:33 +0100 Message-ID: <3610695.tlMGI8NQbM@thomas> In-Reply-To: <552086d6-dfa9-de92-8e97-92543ac0e722@intel.com> References: <552086d6-dfa9-de92-8e97-92543ac0e722@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/02/2022 14:52, Ferruh Yigit: > On 2/9/2022 7:24 AM, Weiguo Li wrote: > > +#ifndef RTE_KNI_FIFO_H > > +#define RTE_KNI_FIFO_H > > It doesn't really differ much but other kni header guards wrapped with '_', > I don't now why. No good reason I think. > If there will be a new version can you please apply the same here to have > consistency, like: > #ifndef _RTE_KNI_FIFO_H_ I think consistency is not important here. We should not add underscores where not needed, it gives a false impression of reserved keywords.