From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E462F1B024 for ; Fri, 5 Jan 2018 15:29:30 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 79933212A3; Fri, 5 Jan 2018 09:29:30 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 05 Jan 2018 09:29:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=fkoiyk9AWPYXcqN+Wrcs07Hdzl QhQf454I42KLB5wy4=; b=fg6HqPMyOnc0hWfa0uF6o2RreeDwEEoaRQi3DzYiJk gwxTor/KYOIJpOV5FCJgGZL3ylu1NpElGpqE4afy91fWlymh749TkcP4XVdR4W8e zLEvU8DcLaqkA/1BU7AEi7pwWYlnvYCdgitBSi5ErA2APIVYZ3Fu6PkX9YU5U/GZ I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fkoiyk 9AWPYXcqN+Wrcs07HdzlQhQf454I42KLB5wy4=; b=Je9n5xl+s7b/79Om/i48I9 AnHWzo9uWLNpXFcpvr406+JYunwLfZKysJGqCgP6jvlPs3SoYiGIh9/m0v/kOrMS MiV5jZijdMyGEy4HJAD3lYOii5Y/qHQRfTXeCfD+2IugvYiiGlsVYkfIeQAPiQZr BqQjCkS+oth8hu3awUwO8ScYulOSc54Ip8NBbUFQaMbBiH9Qc79EMRvimCDTwSrc nF5siIYnelvl8vaX5hS7HjuXThdbHjTzXml7WlQ1XzmYgDOZHo11d03uKpEfy8Re mdHquO+U81LLQwOfkTXFzpjU/CF3GcO7OtW2Wocv6Z+C1sPJUuaRgX89nvYlW4sw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2E7B37E4C8; Fri, 5 Jan 2018 09:29:30 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, arybchenko@solarflare.com Date: Fri, 05 Jan 2018 15:29:09 +0100 Message-ID: <3614502.L0iXJskvX9@xps> In-Reply-To: <20170714183027.16021-1-stephen@networkplumber.org> References: <20170714183027.16021-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC 00/14] link status API improvement and bugfixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 14:29:31 -0000 14/07/2017 20:30, Stephen Hemminger: > While writing new driver, I noticed a lot of unnecessary duplication of > code in drivers for handling the eth_dev link status information. While > consolidating this, it also became obvious that several drivers have > bugs in this are because they don't return the correct value. > Also, some drivers were not fully initializing all the space (including > padding). Good initiative. Please, could you spin a new version not RFC? > This is compile test only at this point, I don't have any of the hardware > available (except virtio) to test. I think we should integrate it in 18.02-rc1 so everybody will be forced to test it.