From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 678E7CF9 for ; Tue, 22 Sep 2015 16:24:57 +0200 (CEST) Received: by wicge5 with SMTP id ge5so164040350wic.0 for ; Tue, 22 Sep 2015 07:24:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=FUSXW2z4RMM9OWL9dY2hiQPhgXSXbk+Tqf/63M7CDpU=; b=ETLtQ6hoDlmc+lWP7U1NwjosGVLQ0N0kQtpsOsI2tm7ofc58KhupDdvnByrjo/MGJE VuvoDNsQzmqW8cMOdilZ3wNaXtD+jc91pGtuJ1kgkEnhNVqDEOwJ5ZLLwzzJEQz8004f cwdMjEwUgq1ekYoXRWspns00+qaYzx3YjXeRhcZUpI8IYj1u70XAG6QfAAH3DntxOxhb disssjo34rBzgbEEO+xYzJn1wrxTDANZxzH/qIrWZC8/L7NA8xmz3kvLxozzqC4SzCiR kWPeQrKF+A5cbQitmyRafGm9GXN7Vb6TcZj3AA84Spmk+I3H887hQXoHLxJj5dywinpJ zSNg== X-Gm-Message-State: ALoCoQn48HVEIVaNreVg8sl5iwi62w4TKTmYbEF1q7X4RtfL6HBLg3zUsbf0qMImYUWRpCESQ+/4 X-Received: by 10.180.188.169 with SMTP id gb9mr18894863wic.44.1442931897271; Tue, 22 Sep 2015 07:24:57 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id h6sm3426362wiy.14.2015.09.22.07.24.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Sep 2015 07:24:56 -0700 (PDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" Date: Tue, 22 Sep 2015 16:23:51 +0200 Message-ID: <3616846.ZsjBrqIcvx@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126478D65D5@IRSMSX108.ger.corp.intel.com> References: <1442322395-23365-1-git-send-email-piotrx.t.azarewicz@intel.com> <20150921153530.0b198652@urahara> <3EB4FA525960D640B5BDFFD6A3D89126478D65D5@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2015 14:24:57 -0000 2015-09-22 11:34, Dumitrescu, Cristian: > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > > Hemminger > > Sent: Tuesday, September 22, 2015 1:36 AM > > To: Azarewicz, PiotrX T > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports > > > > On Tue, 15 Sep 2015 15:06:33 +0200 > > Piotr Azarewicz wrote: > > > > > +static inline void > > > +send_burst_mp(struct rte_port_ring_writer *p) > > > +{ > > > > compiler will inline static functions anyway. No need to add inline qualifier > > Hi Stephen, > > Using 'static inline' seems to be the standard practice in DPDK and a good practice as well. Why do you think it is a good practice? Forced inlining can be a random optimization having negative effects. > DPDK> grep 'static inline' `find -name '*.[hc]'` | wc -l > 1700