DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org, Fan Zhang <roy.fan.zhang@intel.com>
Cc: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] ip_pipeline: add flow actions pipeline
Date: Fri, 13 Nov 2015 17:32:25 +0100	[thread overview]
Message-ID: <3632155.sWGWsa4oGk@xps13> (raw)
In-Reply-To: <1447432188-5033-1-git-send-email-roy.fan.zhang@intel.com>

2015-11-13 16:29, Fan Zhang:
>  examples/ip_pipeline/Makefile                      |    2 +
>  examples/ip_pipeline/app.h                         |    1 +
>  examples/ip_pipeline/init.c                        |    4 +
>  .../ip_pipeline/pipeline/pipeline_actions_common.h |   83 +
>  examples/ip_pipeline/pipeline/pipeline_common_fe.h |    5 +-
>  examples/ip_pipeline/pipeline/pipeline_firewall.c  |   10 +-
>  .../ip_pipeline/pipeline/pipeline_flow_actions.c   | 1814 ++++++++++++++++++++
>  .../ip_pipeline/pipeline/pipeline_flow_actions.h   |   78 +
>  .../pipeline/pipeline_flow_actions_be.c            |  973 +++++++++++
>  .../pipeline/pipeline_flow_actions_be.h            |  168 ++
>  .../pipeline/pipeline_flow_classification.c        |   18 +-
>  examples/ip_pipeline/pipeline/pipeline_routing.c   |   22 +-
>  12 files changed, 3155 insertions(+), 23 deletions(-)

It is a huge patch, especially for an example.
It may cause some code update more difficult to maintain.
I wonder wether we should have some line number limits for
the examples?

      reply	other threads:[~2015-11-13 16:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 16:29 Fan Zhang
2015-11-13 16:32 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3632155.sWGWsa4oGk@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=maciejx.t.gajdzica@intel.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).