From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD09CA0613 for ; Tue, 30 Jul 2019 19:47:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 908721BFD1; Tue, 30 Jul 2019 19:47:27 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 8DC0B1BE1D; Tue, 30 Jul 2019 19:47:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3A4B0221FD; Tue, 30 Jul 2019 13:47:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 30 Jul 2019 13:47:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0d1vXK6vlb/L7fb20RXyNcl1o1EuPAMibgyrOT9mrIQ=; b=jIfDPplA7He7 jqVuAAvjGMtctwabe0+dTW6/Reyv4qa34F1c0dikpFZ1qwB9WTV3G9OgiW3qwF8J B6UH77YtIXzsD2dnCYX6iwiBNdgbNPGjSbwCzyudPGV4LPFZUOVyHdyM9AiBVSA6 1P4vzXSoRbnJf9i7xczeS8WUMhCP75M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=0d1vXK6vlb/L7fb20RXyNcl1o1EuPAMibgyrOT9mr IQ=; b=PsY5y7acvGwLMtb700XSGiDUQXrs7HwXsYPux+edX/wyKSTpkCNOpCYFO ENoEBloArX9of3zAUTDK3u9C95W+NOnB46nbUltjHmJFWPDPjdRrPzrURVeO8nA4 U0MoWEudqAfwpUm1rCc59oh+wrtXv/fm0Dat2/JINsgjwXnwWHBfd0ENG/D15oLU Py0BaSPrXT8jv5acnzIGypB0QRo6wkC67KUauDkx7mjAwXkrEh32KdL/EOyQ6vva MnwJvzOOioTR8yKVfO81AZSAPXhbS3I8sE4UnPUdE5VaK5HYRzt/UxW19GnPSOtD bgwTDhdpTHTvFBpZyF8fgNPIj9Skg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleefgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehrohdrlhhotggrlhenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9A1BA80063; Tue, 30 Jul 2019 13:47:24 -0400 (EDT) From: Thomas Monjalon To: jerinj@marvell.com Cc: dev@dpdk.org, Maxime Coquelin , Tiwei Bie , Zhihong Wang , Jianfeng Tan , stable@dpdk.org Date: Tue, 30 Jul 2019 19:47:23 +0200 Message-ID: <3632593.gczBNArdAd@xps> In-Reply-To: <8ed9b94d-d884-c774-6600-3a59c929ed08@redhat.com> References: <20190730110406.30007-1-jerinj@marvell.com> <8ed9b94d-d884-c774-6600-3a59c929ed08@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix build errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/07/2019 18:12, Maxime Coquelin: > On 7/30/19 1:04 PM, jerinj@marvell.com wrote: > > From: Jerin Jacob > > > > Add extern to variable declaration to avoid some compiler treating it > > as variable definition. > > > > build error log: > > > > lib/librte_pmd_virtio.a(vhost_kernel.o):(.rodata+0x110): > > multiple definition of `vhost_msg_strings' > > lib/librte_pmd_virtio.a(vhost_user.o):(.data.rel.ro.local+0x0): > > first defined here > > lib/librte_pmd_virtio.a(virtio_user_dev.o):(.rodata+0xe8): > > multiple definition of `vhost_msg_strings' > > lib/librte_pmd_virtio.a(vhost_user.o):(.data.rel.ro.local+0x0): > > first defined here > > > > Fixes: 33d24d65fe2b ("net/virtio-user: abstract backend operations") > > > > Cc: Jianfeng Tan > > Cc: stable@dpdk.org > > > > Signed-off-by: Jerin Jacob > > Reviewed-by: Maxime Coquelin Applied, thanks