From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D560E1B1F5 for ; Fri, 12 Apr 2019 17:07:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 82DD421EAE; Fri, 12 Apr 2019 11:07:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 12 Apr 2019 11:07:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kNXuCJO75/sRVyN3l5TwdhQF9z5UexvjFpRkNOGk8nA=; b=q+XyP5iXk2Qc bvWC9tnrqV1lKz5dlPDZpzHvD5u3LWRgdfAkBqnpJbLzt6Z7f9zIWp/kCq1jYUzF E61uBrXv9NUly+/lcmu8f8ivawGVqp+8ypKXtZulOzZLYuYwzX+4/Vv0WD+RIPOt aJj7Plv6e7Sy98yHIX6CZR1RwVupRZA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=kNXuCJO75/sRVyN3l5TwdhQF9z5UexvjFpRkNOGk8 nA=; b=zJ2YQgJnq//l4wi534rumwZp6TmHyTxCM0CPJNksO0Rrj3a+hWm5AfF1g 8Y8oIPVKpqaen/u8UFaGsiRZl8jYNtnin+YNW416vICc5Sqwaesrl3suTBRHNtBJ nD9dwiMMyhC+u3+52wA+/4VUr4A4VLZiKVj8B6iqH6Teq3767Shtzt/KkXfKvkbT FuBlVO8bE86fivX3vfgKKdfP46NLNe4ExTbG36/QnRRFdqkX4gRzMdo9CJEi7iG3 jsmAwMsfPy4z/WVTtAQr1GuVGYXpuN95xR3KOFbs/0FLMgqvYWt5Q1r+s9+EQtNk CjjxBRg+HdKJhps+L3CeiWvOLhSYg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrvddugdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F310010380; Fri, 12 Apr 2019 11:07:53 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, David Marchand , Andrew Rybchenko Date: Fri, 12 Apr 2019 17:07:51 +0200 Message-ID: <3634944.uUV1zRL3KC@xps> In-Reply-To: References: <1551698315-2611-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 15:07:56 -0000 11/03/2019 18:22, Ferruh Yigit: > On 3/4/2019 11:18 AM, David Marchand wrote: > > According to the api, the q_errors[] per queue statistic is for reception > > errors not transmit errors. > > This is a first cleanup on statistics before looking at oerrors. > > > > Yes, the patchset looks aligned with the API documentation [1]. > > What can be the solution after cleanup? We can merge this cleanup and solution > next to each-other to not leave a gap? I think we should merge those fixes in 19.05-rc2. It seems there is a lot more work to achieve on stats, so better to start without waiting for the full picture. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 04636A0096 for ; Fri, 12 Apr 2019 17:07:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 508C31B1F9; Fri, 12 Apr 2019 17:07:57 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D560E1B1F5 for ; Fri, 12 Apr 2019 17:07:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 82DD421EAE; Fri, 12 Apr 2019 11:07:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 12 Apr 2019 11:07:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kNXuCJO75/sRVyN3l5TwdhQF9z5UexvjFpRkNOGk8nA=; b=q+XyP5iXk2Qc bvWC9tnrqV1lKz5dlPDZpzHvD5u3LWRgdfAkBqnpJbLzt6Z7f9zIWp/kCq1jYUzF E61uBrXv9NUly+/lcmu8f8ivawGVqp+8ypKXtZulOzZLYuYwzX+4/Vv0WD+RIPOt aJj7Plv6e7Sy98yHIX6CZR1RwVupRZA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=kNXuCJO75/sRVyN3l5TwdhQF9z5UexvjFpRkNOGk8 nA=; b=zJ2YQgJnq//l4wi534rumwZp6TmHyTxCM0CPJNksO0Rrj3a+hWm5AfF1g 8Y8oIPVKpqaen/u8UFaGsiRZl8jYNtnin+YNW416vICc5Sqwaesrl3suTBRHNtBJ nD9dwiMMyhC+u3+52wA+/4VUr4A4VLZiKVj8B6iqH6Teq3767Shtzt/KkXfKvkbT FuBlVO8bE86fivX3vfgKKdfP46NLNe4ExTbG36/QnRRFdqkX4gRzMdo9CJEi7iG3 jsmAwMsfPy4z/WVTtAQr1GuVGYXpuN95xR3KOFbs/0FLMgqvYWt5Q1r+s9+EQtNk CjjxBRg+HdKJhps+L3CeiWvOLhSYg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrvddugdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F310010380; Fri, 12 Apr 2019 11:07:53 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, David Marchand , Andrew Rybchenko Date: Fri, 12 Apr 2019 17:07:51 +0200 Message-ID: <3634944.uUV1zRL3KC@xps> In-Reply-To: References: <1551698315-2611-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412150751.FQEL-mrVQMKAx2NrW72QsPt3nPxhTInHnBSJyI5LWyI@z> 11/03/2019 18:22, Ferruh Yigit: > On 3/4/2019 11:18 AM, David Marchand wrote: > > According to the api, the q_errors[] per queue statistic is for reception > > errors not transmit errors. > > This is a first cleanup on statistics before looking at oerrors. > > > > Yes, the patchset looks aligned with the API documentation [1]. > > What can be the solution after cleanup? We can merge this cleanup and solution > next to each-other to not leave a gap? I think we should merge those fixes in 19.05-rc2. It seems there is a lot more work to achieve on stats, so better to start without waiting for the full picture.