From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 779C545B88; Mon, 28 Oct 2024 13:58:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B85040E44; Mon, 28 Oct 2024 13:58:19 +0100 (CET) Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) by mails.dpdk.org (Postfix) with ESMTP id 191B3400D7 for ; Mon, 28 Oct 2024 13:58:18 +0100 (CET) Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id A73841140157; Mon, 28 Oct 2024 08:58:17 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Mon, 28 Oct 2024 08:58:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1730120297; x=1730206697; bh=Dfjhx5c5YqdxC5QY83enpRS/u6zIv6hhkHGPgLVC+DI=; b= wYBtomHsapTMdpMajfCbqU0HW06jzCYuRBbedNBN/D2iHxNRxm/W4BQ6KWWZM4X2 CB/o0ngSlKqXMAQ3Aof+MXsr881fTf2sx9R+UnadD7iFc7T4+vn+lx1MCvR5V7LW dQgdUHBMxRUNUtzNUzoQOOB0ImmyIu0qdIk1VGsgv1s74oMciT8zg+EZ1oPy0Jvq syKWTSW2PBfO8nWm58ehVl2oiAnEhJN9ASaV3O7QV9T18SlD+6wdaupktLPgV1mq tQai+5nRJwgj08Lx0GU5VjRKRb4c9armnuI4dl1LbdVsDultnjJgOOY0uPWvVFrB LW24f8kg9AluxXtrC5k0dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730120297; x= 1730206697; bh=Dfjhx5c5YqdxC5QY83enpRS/u6zIv6hhkHGPgLVC+DI=; b=J sq/a4cnWWgE679H9YovUK/wbq3oozujfOwL6AfBvG7xHFpjWlCS2vlxBTYfcw4PW +QKzM1G89mSs3RKKvS66KysCvzQT9r/ANWLsR5CysVLAxUwbUXoh1+eKJmfmPjTl HUOAMvvfUj4VO4RPxTGe1u2NZsbpoTWUH2t0e0966uY0bfPvxiavcriPcB5YzGpe qVR8bJIr94BQhYkMiEFEd2Vi8sCETWgcB4cYAn/0DwUMqmcGirNkRmUxdlAJh3y0 9REMUSIXEpIzrifB6mwa+J+9UB0tk2EWbN/QROY9Dg46tHe8lG99KQ3H1LCQKRBn Y5HkuaUCphp8r138BmCbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdejledgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedt heevtdekiedvueeuvdeiuddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeekpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrjhhith drkhhhrghprghruggvsegsrhhorggutghomhdrtghomhdprhgtphhtthhopehsrhhihhgr rhhshhgrrdgsrghsrghvrghprghtnhgrsegsrhhorggutghomhdrtghomhdprhgtphhtth hopehfvghrrhhuhhdrhihighhithesrghmugdrtghomhdprhgtphhtthhopegrnhgurhgv fidrrhihsggthhgvnhhkohesohhkthgvthhlrggsshdrrhhupdhrtghpthhtohepuggvvh esughpughkrdhorhhgpdhrtghpthhtohepshhtvghphhgvnhesnhgvthifohhrkhhplhhu mhgsvghrrdhorhhgpdhrtghpthhtohepuggrvhhiugdrmhgrrhgthhgrnhgusehrvgguhh grthdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Oct 2024 08:58:13 -0400 (EDT) From: Thomas Monjalon To: Ajit Khaparde Cc: Sriharsha Basavapatna , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, Stephen Hemminger , ferruh.yigit@amd.com, david.marchand@redhat.com Subject: Re: [PATCH v6 00/47] TruFlow update for Thor2 Date: Mon, 28 Oct 2024 13:58:08 +0100 Message-ID: <3636333.hUukIMtRk4@thomas> In-Reply-To: References: <20241021082607.232829-1-sriharsha.basavapatna@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/10/2024 07:26, Ajit Khaparde: > On Mon, Oct 21, 2024 at 1:14=E2=80=AFAM Sriharsha Basavapatna > wrote: > > > > This patch series introduces TruFlow functionality for Broadcom Thor2 N= IC. > > > > TruFlow(TF) is the software library that exposes CFA HW resources to > > upper layer protocols or applications. This patch series implements the > > tfc (tf_core) and the tf_ulp libraries as a part of the bnxt PMD, > > so that upper layer APIs such as rte_flow can access the hardware. >=20 > Patchset applied to dpdk-next-net-brcm for-next-net branch. > Along the way, I fixed up some commit logs, > checkpatch errors, spelling errors, long lines and EOF errors - > wherever possible. > Some of the patches are auto generated and could not be modified. > The autogen scripts are being updated to fix them for the next round > of submissions. There are still too many issues. Please could you fix these warnings before we can merge? +drivers/net/bnxt/tf_core/v3/tfc_global_id.c: duplicated include: tfc.h +drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c: duplicated include: bnxt.h +drivers/net/bnxt/tf_core/v3/tfc_tcam.c: duplicated include: tfc.h Missing 'Fixes' tag: net/bnxt: tf_core: fix slice count in case of HA entry move net/bnxt: tf_ulp: fixed parent child db counters Is it candidate for Cc: stable@dpdk.org backport? net/bnxt: fix issue reading sff8436 sfp eeproms net/bnxt: tf_core: fix wc tcam multi slice delete issue net/bnxt: tf_core: tcam manager data corruption net/bnxt: tf_core: Thor TF EM key size check Wrong tag order:=20 net/bnxt: tf_core: fix wc tcam multi slice delete issue (Signed-off= =2Dby:) Contributor name/email mismatch with .mailmap:=20 Peter Morrow is unknown in .mailmap Writing to stdout or stderr Do not use variadic argument pack in macros Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory= _order_xxx Using __builtin helpers for bit count operations Error parsing drivers/net/bnxt/tf_core/v3/meson.build:15, got some tabulati= on Error: Missing trailing "," in list at drivers/net/bnxt/tf_core/v3/meson.bu= ild:33 Error parsing drivers/net/bnxt/hcapi/cfa_v3/meson.build:10, got some tabula= tion Error parsing drivers/net/bnxt/tf_ulp/meson.build:27, got some tabulation Error parsing drivers/net/bnxt/tf_ulp/generic_templates/meson.build:6, got = some tabulation rte_flow doc out of sync for bnxt item geneve item vxlan_gpe action set_ipv6_dst action set_ipv6_src action set_ttl WARNING:TYPO_SPELLING: 'pupose' may be misspelled - perhaps 'purpose'? #6584: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/host/cfa_bld_mpcops.= h:72: + * optional and can be filled with a null pointer. The pupose of these hoo= ks ^^^^^^ WARNING:TYPO_SPELLING: 'Foward' may be misspelled - perhaps 'Forward'? #7219: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_bld_p70_defs= =2Eh:103: + /** Set to statistic to Foward packet count(64b)/Foward byte ^^^^^^ WARNING:TYPO_SPELLING: 'Foward' may be misspelled - perhaps 'Forward'? #7219: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_bld_p70_defs= =2Eh:103: + /** Set to statistic to Foward packet count(64b)/Foward byte ^^^^^^ WARNING:TYPO_SPELLING: 'modfication' may be misspelled - perhaps 'modificat= ion'? #7389: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_bld_p70_defs= =2Eh:273: + /** Set to true to enable modfication ^^^^^^^^^^^ WARNING:TYPO_SPELLING: 'Conifiguration' may be misspelled - perhaps 'Config= uration'? #11468: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_p70_hw.h:15= 31: + * Mirror Destination 1 Sampling Conifiguration. ^^^^^^^^^^^^^^ WARNING:TYPO_SPELLING: 'wit' may be misspelled - perhaps 'with'? #14002: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_p70_hw.h:40= 65: + /* Add one VLAN tag remap wit inner VLAN Tag PRI field. */ ^^^ WARNING:TYPO_SPELLING: 'inluding' may be misspelled - perhaps 'including'? #14325: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_p70_mpc_str= ucts.h:96: + * cases (inluding EM_INSERT bucket writes), the OPTION field is se= t by ^^^^^^^^ WARNING:TYPO_SPELLING: 'explicity' may be misspelled - perhaps 'explicitly'? #15271: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_p70_mpc_str= ucts.h:1042: + * wishes to explicity delete the matching entry. * REPLACE=3D1: ^^^^^^^^^ WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'? #50280: FILE: drivers/net/bnxt/tf_core/v3/tfo.c:18: + bool ts_is_bs_owner; /**< Backing store alloced by this instance (P= =46) */ ^^^^^^^ WARNING:TYPO_SPELLING: 'paranthesis' may be misspelled - perhaps 'parenthes= is'? #20:=20 paranthesis. ^^^^^^^^^^^ WARNING:TYPO_SPELLING: 'firmwware' may be misspelled - perhaps 'firmware'? #3466: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:967: + * the firmwware.