From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCFB3A0577; Mon, 13 Apr 2020 14:18:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE4991BE9C; Mon, 13 Apr 2020 14:18:31 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id C3EA91BE9B for ; Mon, 13 Apr 2020 14:18:30 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 773A1887; Mon, 13 Apr 2020 08:18:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 13 Apr 2020 08:18:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ocLwbd8DADJwqwB1kK+4/GaBMip8GkxaVHM8RVnQxGA=; b=KWFAttOb3ghx d+tKILebu1OPFNIaUMFm1ldXOcgtMtXhT1DX8GWcG1zBkf2UZdcVOFtU8OfmSB5B cffNXRlawCGUtBYU4g4DMO/2HVVXGzC9NpMzXASywcVa5vb9i2RCAbg1Ta0dLVFo 9E+KHJn6wL5yeMgnzC8yY9zUqONK9Kc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ocLwbd8DADJwqwB1kK+4/GaBMip8GkxaVHM8RVnQx GA=; b=Uasdt0Lvkpz7v1QPo/LkSXSH7LA0fL4gEspfAYsczNIhJT0OCD4xC7cvv F3XpBwIrOBEbKasngefp1GTWyBIyyxABmb1eqxOZ3tFQHqOo6899qG0WTulctYJu nQXcX+mKaYy1HwkAmp2W5qZkdU5PuoDARK3BAsmtFWjfheOcA+AqcWov/kOhMx3M Fdcs6CudPP4US7YQsBDl58uI+MIE0fjSFPfSiHAXOQ/ZlEPlqu2gTS9JovXLcjQ+ mvnwdPfy7rLaHye4l5mM8iZycIVyDPwQ/PFhmH1Ug7q1txHpG93T4RTQ6Rp++JhQ 7mDFigCgwqnjtCkZfXj6oNQ9Be0JQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvdelgdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 947E6306005E; Mon, 13 Apr 2020 08:18:26 -0400 (EDT) From: Thomas Monjalon To: Haiyue Wang Cc: dev@dpdk.org, vattunuru@marvell.com, jerinj@marvell.com, alex.williamson@redhat.com, david.marchand@redhat.com Date: Mon, 13 Apr 2020 14:18:25 +0200 Message-ID: <3639790.NG923GbCHz@thomas> In-Reply-To: <20200413082930.84050-1-haiyue.wang@intel.com> References: <20200305043311.17065-1-vattunuru@marvell.com> <20200413082930.84050-1-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] eal: add VFIO-PCI SR-IOV support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, About the title, I think it does not convey what is new here. VFIO is not new, SR-IOV is already supported. The title should mention the new VFIO feature in few simple words. Is it only about using VFIO for PF? 13/04/2020 10:29, Haiyue Wang: > v4: 1. Ignore rte_vfio_setup_device ABI check since it is > for Linux driver use. [...] > +; Ignore this function which is only relevant to linux for driver > +[suppress_type] > + name = rte_vfio_setup_device Adding such exception for all internal "driver interface" functions is not scaling. Please use __rte_internal. I am waiting for the patchset about rte_internal to be reviewed or completed. As it is not progressing, the decision is to block any patch having ABI issue because of internal false positive. Please help, thanks.