From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F9A8A0524; Tue, 20 Apr 2021 02:34:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51BDF41448; Tue, 20 Apr 2021 02:34:47 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id D8BBD40685; Tue, 20 Apr 2021 02:34:45 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 82EB65C00B9; Mon, 19 Apr 2021 20:34:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 19 Apr 2021 20:34:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 3p1wBy19M1Qj9o29cZwBkDHgwTzWdKJ9XaXaOOgAzMs=; b=Du9R3bOJatdOVqZS Qi7SbcBB/wwKpe3mRH/1vPOpYKVzR3SsSlpNJFftVZj9A0QHByKarMn1z1UkJFBi IOgpJB0c8Lgqmu+K2bL0DaLpTMG+pOjr7sXTtYT96vQqZWEtgDuGD3DHhDa2UmRe ZhHP5I9jt6DGfHh5AMi6hr0nKm2i2RdR6/1ScBz4mgGUfogUzRrWA5d1CXfRNxcM ObAyAZzlj7HeNZ4HgYgwuHISni86vNrcZVUmVmu8oyWHWHOaf42+IpAY/7D0mLut pS4AOJhuMRC6aFj9tI8MCYyK0tr/P75Z6+t2rtgjVR86LBH8c2mgtk5q59ntpsWU agSjTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3p1wBy19M1Qj9o29cZwBkDHgwTzWdKJ9XaXaOOgAz Ms=; b=t2p7/cAEczR1CTtTuwaTN6r5eGE5jSX1i2LnW2NpaxFOPAtG9M7yCeReJ tRZenrvQl11obmRlKOm5VcbKaSLZoEsWNaDRU/zZlkmwr9/LEAtfTMMG3QYlO2Mw 53ad5VwzgSC9vzwOYzFMatQfoeOp2xSFlCcJCtxdf4KtMLVnnRpxs46f17mgJVaG Jz1bM0bXDIDQnWSEPSB9erCqEo1rfKYTl+bPDY5FfGtjdrV54zUFMF/Ai2Ae1Zif fyZ+4bbrr+k3MmOeNZizZBBJldSVA4kLrFauvynHfNPnaGjk0hkwovTt3e6SawQg QhUTiuPo+wY0j32eXqni3nZOYkB6g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddthedgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9463E24005C; Mon, 19 Apr 2021 20:34:44 -0400 (EDT) From: Thomas Monjalon To: Cristian Dumitrescu Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 20 Apr 2021 02:34:43 +0200 Message-ID: <3640647.UQ6DxFeTdr@thomas> In-Reply-To: <20210403001709.75890-1-cristian.dumitrescu@intel.com> References: <20210403001709.75890-1-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pipeline: fix endianness conversions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/04/2021 02:17, Cristian Dumitrescu: > The SWX pipeline instructions work with operands of different types: > header fields (h.header.field), packet meta-data (m.field), extern > object mailbox field (e.obj.field), extern function (f.field), action > data read from table entries (t.field), or immediate values; hence the > HMEFTI acronym. The H operands are stored in network byte order (NBO), > while the MEFT operands are stored in host byte order (HBO), hence the > need to operate endianness conversions. > > Some of the endianness conversion macros were not working correctly > for some cases such as operands of different sizes, and they are fixed > now. Affected instructions: mov, and, or, xor, jmpeq, jmpneq. > > Fixes: 7210349d5baa ("pipeline: add SWX move instruction") > Fixes: 650195cf965a ("pipeline: introduce SWX and instruction") > Fixes: 8f796198dcda ("pipeline: introduce SWX or instruction") > Fixes: b4e607f9fd5e ("pipeline: introduce SWX XOR instruction") > Fixes: b3947e25bed4 ("pipeline: introduce SWX jump and return instructions") > Cc: stable@dpdk.org > > Signed-off-by: Cristian Dumitrescu Applied, thanks