From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id D9B82C37E for ; Thu, 18 Feb 2016 15:10:22 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id g62so29544488wme.1 for ; Thu, 18 Feb 2016 06:10:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=YjwsFvS7c9mqzSSa+JwFwMiz+ai6l7PAD9cRFoM9CSA=; b=tfdgEysqU0sE5/haTey6pAGJuphneGcLHKp2oLLaKhFmYrN5kBqt/3iiQd/XhYDgkv 6IAvckRyAdggQEnjgbZVQ6+2W4NJEXhJD8345BTbJL526OnaAM8oLRngzzdErFLmQA5v T8Cgqd9uqkSW2lA0X/ZAyGLYwbhDq8hKA9NzN/OtkNFRhx7UvULtCrsoWbP0a/STscDt PZnpKMVDPhkm6yiyuVYTo7afMW156iIMYIOxlSPN6DXxjrLyAXD8KJOQbpSXYCLswMeq 3zdRHzObNwNVb+st0aq0j14XYOw7s50yE8qxlz2kGOv4FvgllFZaXgeB2Do58PZS5RUn j9Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=YjwsFvS7c9mqzSSa+JwFwMiz+ai6l7PAD9cRFoM9CSA=; b=ZNGxHTsWk877oqVoEtDj598T3LrGuV32PEDmd7Ir00CWfbqT9ZKhxjqQMG3o1sL9az Om9pZ1wDlmHMGRbxIuhq0QPb/+Os/jyInmcXvJv8akW9xvLY6FZW4mWsscM/eqqG/yxK bhAJg7AnsheXXlgWKMxMsXwjSaZlhBvFAomvITHstEA+DxSgVvP6A0l3MXmf+iBtoi+W 917+ZbnmcsqSvLzfUbIt0Mg0TJcIq1il6NgfzcCWoakpasMnwdVlVQIE+2iO205vLi7y YQVFvD6Phk3zfhDxJGmKtz7J4UYSosAJjbRWuEbVQIkO+SvA6hLFtMnxHP8tv9ryvUva S8Pw== X-Gm-Message-State: AG10YOQfLnRsjpSgYla6d0/PHqIIncqEHcA+QUCelV6qmDBGA8m1eWpV8U/eR4tRxL80QKNh X-Received: by 10.28.179.130 with SMTP id c124mr3749624wmf.76.1455804622711; Thu, 18 Feb 2016 06:10:22 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id t12sm3157401wmt.20.2016.02.18.06.10.21 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 18 Feb 2016 06:10:22 -0800 (PST) From: Thomas Monjalon To: "Burakov, Anatoly" Date: Thu, 18 Feb 2016 15:08:49 +0100 Message-ID: <3641912.UTtuKLG1Jr@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1441914050-43168-1-git-send-email-keith.wiles@intel.com> <1928276.P2Lqin6BEp@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal:Change log output to DEBUG instead of INFO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 14:10:23 -0000 2016-02-18 10:18, Burakov, Anatoly: > > > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > > > @@ -904,7 +904,7 @@ pci_vfio_enable(void) > > > > > > /* return 0 if VFIO modules not loaded */ > > > if (module_vfio_type1 == 0) { > > > - RTE_LOG(INFO, EAL, "VFIO modules not all loaded, " > > > + RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, " > > > "skip VFIO support...\n"); > > > return 0; > > > } > > Should people be forced to recompile DPDK with debug logs (and get all this > additional debug output) just to see why VFIO doesn't get initialized? No, there is a run-time option --log-level. The compiled max level must be set to DEBUG to be able to see this message with debug --log-level. > I would > argue this message is not as serious an annoyance to warrant this change, but > maybe Keith has a different opinion. > > Either way, I don't feel strongly for or against the change. Thanks