From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55405A0524; Fri, 8 Jan 2021 15:10:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D67A140EF9; Fri, 8 Jan 2021 15:10:48 +0100 (CET) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by mails.dpdk.org (Postfix) with ESMTP id 201E6140EE2 for ; Fri, 8 Jan 2021 15:10:46 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 543591BDD; Fri, 8 Jan 2021 09:10:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 08 Jan 2021 09:10:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= G6qJuxtM1Rmi90gjhzjUzIi1Y/ZyQTAyMtvyY16ksoE=; b=gqCS4e7cNmmkFCLX wSUv7aDnTCUwyShQ/IxBsZXkZcnuy82g7ho/bR3g+b5/VEmHu7uK1kben83Ixmwl fAtePxXjrRYmXO23IcH/EAv+qCMG9Kpwl3aYm1G9qR1S9jDxAUXMV3gZ1Ufk/jSh j/KTcsFJ2TXSy9vaUC9/vnyRL1+OoHFQWsd2smNyxj0NnyeJRBboL13iUzWEsEXr RsByt5lEVrwzUyKGF0QGmU7XBTYGDerzW9cEMePHG65GgV3/TjssAz18FCeX0cTg /Wan7C4F2hnclY++oYu634/xBtK+i19HLa8U8lpG23ixOKqn9L8MUScNK/zxJyji xL3pQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=G6qJuxtM1Rmi90gjhzjUzIi1Y/ZyQTAyMtvyY16ks oE=; b=YXM7D1urTNtqHhgP31my1Pk9meTYNqeS6g+ZlcyFY5enkz1ElJH29AQgo jF8/35Qb1g2SBuA48uqaP0LhrpQZLIwYOnWPiSbK5BsKZ5tlm/Fn3U156HJ+l0mY M5teVyy2hUT95XSkp5Wn+leOnsgxdwVu8Pg8NxZZXr88vymN78zOBV+zBFAMDMYU Q3Kzlk2fGHEq9S7m0cSbtEp7utMNZr35gu7fUNtvQn7x5k3WbX6C/hvk/f/Y/YSi J0TCMEIcQIYTFrh7k+oVPt/pLxJAju+S0MMBoU4SzPqaElxBz7orbljcO6ug+HRR 96AP/H1gsBg31BrTfMvKvsIPLSC5Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeggedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgeejfffhhfeghfetveffgeffteelveekhffghfefgedvleeuveet fffgudelvefhnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeejrddufe egrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C698D24005D; Fri, 8 Jan 2021 09:10:41 -0500 (EST) From: Thomas Monjalon To: "Guo, Jia" , "Zhang, Qi Z" , "Yigit, Ferruh" , "Kinsella, Ray" Cc: "Wu, Jingjing" , "Yang, Qiming" , "Wang, Haiyue" , "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "orika@nvidia.com" , "getelson@nvidia.com" , Dodji Seketeli Date: Fri, 08 Jan 2021 15:10:40 +0100 Message-ID: <3643807.hJ4yVFep8C@thomas> In-Reply-To: References: <20201216085854.7842-1-jia.guo@intel.com> <3369453.mArGO5O6NO@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/01/2021 15:07, Kinsella, Ray: > From: Thomas Monjalon > > 08/01/2021 11:43, Ferruh Yigit: > > > On 1/8/2021 10:23 AM, Thomas Monjalon wrote: > > > > 08/01/2021 10:22, Ferruh Yigit: > > > >> On 1/7/2021 1:33 PM, Thomas Monjalon wrote: > > > >>> 07/01/2021 13:47, Zhang, Qi Z: > > > >>>> From: Thomas Monjalon > > > >>>>> 07/01/2021 10:32, Guo, Jia: > > > >>>>>> From: Thomas Monjalon > > > >>>>>>> Sorry, it is a nack. > > > >>>>>>> BTW, it is probably breaking the ABI because of > > RTE_TUNNEL_TYPE_MAX. > > > >>>> > > > >>>> Yes that may break the ABI but fortunately the checking-abi- > > compatibility tool shows negative :) , thanks Ferruh' s guide. > > > >>>> https://github.com/ferruhy/dpdk/actions/runs/468859673 > > > >>> > > > >>> That's very strange. An enum value is changed. > > > >>> Why it is not flagged by libabigail? > > > >> > > > >> As long as the enum values not sent to the application and kept > > > >> within the library, changing their values shouldn't be problem. > > > > > > > > But RTE_TUNNEL_TYPE_MAX is part of lib/librte_ethdev/rte_ethdev.h > > so > > > > it is exposed to the application. > > > > I think it is a case of ABI breakage. > > > > > > Yes it is exposed to the application. But in runtime does it > > exchanged > > > between library and application is the issue I think. > > > For this case it seems it is not, so not an ABI break. > > > > If I create a table of size RTE_TUNNEL_TYPE_MAX with DPDK 20.11, I will > > get an overflow when writing to the new ECPRI index. > > I guess the question is - are you likely to do this? As said below, no I cannot think about such a case myself. > > The question is: can I receive the ECPRI value dynamically from ethdev? > > If yes, it is an ABI breakage. But I cannot think of such case now.