From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40EFCA0A05; Wed, 20 Jan 2021 12:09:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00010140CCF; Wed, 20 Jan 2021 12:09:23 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id E01B4140CCA for ; Wed, 20 Jan 2021 12:09:22 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 9597AE46; Wed, 20 Jan 2021 06:09:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 20 Jan 2021 06:09:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= UomEV44jwpxbjJVPnNrxGtGBPow0VvVejsoQOWxtVV0=; b=vyYWelVcuPHKwAwP PtherTyCppGtD8A7bamem8/nL8mTsxWhbLM1ito02UhKf8QSZ2MV8BReZE1OW5EB 72vDO20/Q5Ha8n86+1AmjdtNAQQjmaMjQzJq2y/BHVpiO8e2DDZ/7sCb0kPKe9YK 7HMwwv1qjXv280j3isLHFkQaS0BSyeAZRewxLEGFR9J7qmSMTKKXgm1rZ/ZUYJrO f2qUwSwNch1/c5o+Ym/dSFHlETmEu6cGLGLAQNIziYh4ouJPOnd4cPZ7sfn/jBwo 5rEvWI+sck5NqXuIcKbIhLFCYFOk3KmK3yRWZCCNDG8njtBBg+Kp4tAfjQPA3zsj xMBPWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=UomEV44jwpxbjJVPnNrxGtGBPow0VvVejsoQOWxtV V0=; b=ZqLP/+KXJaMYBr/kuQMZZ6+m/O3MyOlGNXFbfdj3Jcm9rkv8G4usO6LwR c1VPLnrZoLtk0gQSol+Oa086l31Abp1y56QrwALVuVev4zjRdpH2qQP/VEXcLQ3T H+h9esIDkFYWMThb+Anp/I5cTOaiBpLbH7ggOFyz4oPfBZDNAmZ+UJA6Ffe4Byro XGeEtzaiCT7X8qD5E3II/jPjL/WteVBpRycT+IoSOWhiWGm98oudh7JOCYEH1VDo RrinGW7vdLIMfMbVvdhzGT+ABDCx6z9MCfoApt34AvBUQ4HkiQnilhKj5GUb690H 7n3VcyWgHdqQ8q4d8juugBulZ8OUQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3D4021080063; Wed, 20 Jan 2021 06:09:20 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Tyler Retzlaff , dev@dpdk.org, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, ciara.power@intel.com Date: Wed, 20 Jan 2021 12:09:19 +0100 Message-ID: <3646223.fRS4d9ebDi@thomas> In-Reply-To: <20210120103757.GB1406@bricha3-MOBL.ger.corp.intel.com> References: <1610408246-29482-1-git-send-email-roretzla@linux.microsoft.com> <5601419.A6MszWdEHB@thomas> <20210120103757.GB1406@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/01/2021 11:37, Bruce Richardson: > On Tue, Jan 19, 2021 at 10:52:03PM +0100, Thomas Monjalon wrote: > > 19/01/2021 22:31, Tyler Retzlaff: > > > On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote: > > > > > > > > Not sure it makes sense without the new telemetry feature. > > > > Please focus on telemetry lib instead of half-enabling > > > > the old metrics lib. > > > > > > > > > > can you elaborate? (or reference a mailing list discussion) that gives some > > > guidance? > > > > > > is the telemetry lib a replacement for metrics? the component we have now > > > relies on the non-telemetry functions exported from metrics but does not > > > use the telemetry functions. > > > > > > also, i notice that the meson.build for telemetry lib has an include path > > > that references rte_metrics but does not appear to actually include any of > > > the headers from rte_metrics (vestigial? missed in previous cleanup perhaps?) > > > > I think Bruce and Ciara will better explain than me > > the intent of the telemetry lib and the compatibility path with the metrics lib. > > > > The include path addition for metrics to the telemetry library does indeed > look like it was just missed being removed, since I can compile things up > successfully with it removed. > > With regards to interaction between telemetry library and metrics library, > they are complementary but not replacements for each other. The metrics > library provides support for tracking metrics, mostly on a per-port basis. > The original telemetry library implementation was based on top of the > metrics library and supported reporting out data from that library. More > recent versions of the telemetry library have reworked that support to > allow the reporting of arbitrary telemetry data, not just from the metrics > library, but the old interface is still supported. The question is what is available in rte_metrics which is not already available with rte_telemetry only? I think rte_metrics is used only for rte_bitratestats and rte_latencystats. Can we use rte_telemetry for this and forget rte_metrics?