From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id E63107E9F
 for <dev@dpdk.org>; Tue, 28 Oct 2014 14:15:12 +0100 (CET)
Received: by mail-wg0-f45.google.com with SMTP id x12so839792wgg.4
 for <dev@dpdk.org>; Tue, 28 Oct 2014 06:24:00 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=NNKSL7Pims3rJezfpOKqw8dfBliQOvcrsLCtnhCcFzM=;
 b=ZIbTIFsOaV1AnswEfIZfDqL8b9r/RGcYR1ixml43VvvPMYqARue6EyNTFNxDHm8eMp
 X6PoyNgRSZRDXo/RAs6EA5SgyCuo9HDL4dtdubAUZ/jdoqp6IAzaaZyvWvfrR879kYhv
 jTPF9expM92k6ofS5RdjlfxKWqwWXN1miKVAAjFVUgHgNuq8pV9qyC1WQiQmW3HLGE1/
 7GtZhy2/EtysBZWsOVcQd0kCVHiSIQ6qIrc1g+ne8nMM4Zy0mbezfEYVhuKwGmcpnqXP
 0tjS6Hm+xiMbHN9uJNJeqWKF6A2DvNOHM7xrdDJoM7T+En2SMWaOGJ65zZltfg7HOGOy
 ECOA==
X-Gm-Message-State: ALoCoQmrT11BFcidS8DeZYUGZIiu8NBwgdWMBayMK7ooeVkIz+CWUEK0BZuXV7AYbdY99cdgS089
X-Received: by 10.194.236.200 with SMTP id uw8mr4430388wjc.50.1414502640095;
 Tue, 28 Oct 2014 06:24:00 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id f6sm2223202wix.5.2014.10.28.06.23.58
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 28 Oct 2014 06:23:59 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Date: Tue, 28 Oct 2014 14:23:41 +0100
Message-ID: <3655691.pDuQDRK5Z6@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <1413939687-11177-7-git-send-email-jingjing.wu@intel.com>
References: <1411711418-12881-1-git-send-email-jingjing.wu@intel.com>
 <1413939687-11177-1-git-send-email-jingjing.wu@intel.com>
 <1413939687-11177-7-git-send-email-jingjing.wu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 06/21] testpmd: add test commands to
	add/delete flow director filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2014 13:15:13 -0000

2014-10-22 09:01, Jingjing Wu:
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -73,6 +73,9 @@ int main(int argc, char **argv);
>  #define NUMA_NO_CONFIG 0xFF
>  #define UMA_NO_CONFIG  0xFF
>  
> +#define BYTES_PER_WORD  2

This is an example of a constant which have a meaning.
But it should be in lib/librte_eal/common/include/rte_common.h

> +#define IPV6_ADDR_LEN 16

This one should be in lib/librte_net/rte_ip.h and should be used in ipv6_hdr.

Thanks
-- 
Thomas