From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id BB9FEA3160
for <public@inbox.dpdk.org>; Sat, 12 Oct 2019 20:54:11 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 9680A1E868;
Sat, 12 Oct 2019 20:54:04 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 954591E85D;
Sat, 12 Oct 2019 20:54:02 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id DA04921947;
Sat, 12 Oct 2019 14:54:01 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Sat, 12 Oct 2019 14:54:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=lnde/NPUf2MOaGxKqUQwMoxNBW+oIUryu2vfeoJwIek=; b=Ui8lrFnimACF
SI9sxpivdp4e064uLtzUwqNPrtP3yVy3DR9WxoZh4VYB7DS6JCdeNh3qa8PbcwAq
1pWGYGzY67tTfeQBrH7XZP4N31aoKehni2LKohHHcv91SYv7lTaB0SblmjeXQ8a8
0om3bzZ8aBqY712GXbn2acR0BzaPPWc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=lnde/NPUf2MOaGxKqUQwMoxNBW+oIUryu2vfeoJwI
ek=; b=OGeKQ2tzk4OnV8ay0J/qNPdAYG9EfwCjYjDi2na7rrsEjCf/mMvMCX+AA
m3TZgxKpV+spqgaD4aOvEoG/vfa9K6qhqnhTzk+1fquCGlTuAyISeZmqYDXFCXjp
R/GRdZLXF+pJGUlzqy7SJZBS3w7d/CaUtu0PxzRrnnXUxtXpFfO18Q6KfZXic1nx
GQ6x5ka/PehBfwb4p7TsWw/RfzGrJH+IgKgPeqn47eR6RYledBRwnVy2LWxq9qoK
0z8PqPOa1wcRY5a1OvqacyWa0+X36o/XLtTotP5eAaowhoPYbR6sEB+783FiCOeO
iMFlf1rXrKqqeA5/mOa/a/gjkF1XA==
X-ME-Sender: <xms:SSGiXeFXceHfXhelStttk2C8aWjnet26Qo-JXBkfFMDV62u_z2T50Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrieejgddufeduucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
hppeduheegrddufeefrdduieeirddvudefnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht
hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepud
X-ME-Proxy: <xmx:SSGiXQK1vua5Fbv3RGNrL6bsrsl93LHJ0gETRl7tAlLn0lsRMNQ3Lw>
<xmx:SSGiXWse89VzdFkOgQ3xQgONkSR-PxdtcQ0Kw69iNQfZCMHVr0tb6g>
<xmx:SSGiXd5BBcwa2Tf_bSqcctV4ntlZOqrqVlEdx8bA5GqIjyaHncSnXg>
<xmx:SSGiXe6VvFqtmpObFug9r5YfleuzoKp_NxpWAMx-sTKD4DHWG5t2Dg>
Received: from xps.localnet (unknown [154.133.166.213])
by mail.messagingengine.com (Postfix) with ESMTPA id 29D6E8005B;
Sat, 12 Oct 2019 14:53:58 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: stable@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>, dev@dpdk.org
Date: Sat, 12 Oct 2019 14:36:45 +0200
Message-ID: <3656667.7vqnHmEFed@xps>
In-Reply-To: <20190905145315.19395-9-ferruh.yigit@intel.com>
References: <20190905145315.19395-1-ferruh.yigit@intel.com>
<20190905145315.19395-9-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 08/10] app/testpmd: fix global
variable multiple definitions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
05/09/2019 16:53, Ferruh Yigit:
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -507,7 +507,8 @@ struct vxlan_encap_conf {
> uint8_t eth_src[RTE_ETHER_ADDR_LEN];
> uint8_t eth_dst[RTE_ETHER_ADDR_LEN];
> };
> -struct vxlan_encap_conf vxlan_encap_conf;
> +
> +extern struct vxlan_encap_conf vxlan_encap_conf;
>
> /* NVGRE encap/decap parameters. */
> struct nvgre_encap_conf {
> @@ -522,7 +523,8 @@ struct nvgre_encap_conf {
> uint8_t eth_src[RTE_ETHER_ADDR_LEN];
> uint8_t eth_dst[RTE_ETHER_ADDR_LEN];
> };
> -struct nvgre_encap_conf nvgre_encap_conf;
> +
> +extern struct nvgre_encap_conf nvgre_encap_conf;
I guess the empty line is not needed here and above.
> /* L2 encap parameters. */
> struct l2_encap_conf {
> @@ -532,13 +534,13 @@ struct l2_encap_conf {
> uint8_t eth_src[RTE_ETHER_ADDR_LEN];
> uint8_t eth_dst[RTE_ETHER_ADDR_LEN];
> };
> -struct l2_encap_conf l2_encap_conf;
> +extern struct l2_encap_conf l2_encap_conf;
>
> /* L2 decap parameters. */
> struct l2_decap_conf {
> uint32_t select_vlan:1;
> };
> -struct l2_decap_conf l2_decap_conf;
> +extern struct l2_decap_conf l2_decap_conf;
>
> /* MPLSoGRE encap parameters. */
> struct mplsogre_encap_conf {
> @@ -553,14 +555,14 @@ struct mplsogre_encap_conf {
> uint8_t eth_src[RTE_ETHER_ADDR_LEN];
> uint8_t eth_dst[RTE_ETHER_ADDR_LEN];
> };
> -struct mplsogre_encap_conf mplsogre_encap_conf;
> +extern struct mplsogre_encap_conf mplsogre_encap_conf;
>
> /* MPLSoGRE decap parameters. */
> struct mplsogre_decap_conf {
> uint32_t select_ipv4:1;
> uint32_t select_vlan:1;
> };
> -struct mplsogre_decap_conf mplsogre_decap_conf;
> +extern struct mplsogre_decap_conf mplsogre_decap_conf;
>
> /* MPLSoUDP encap parameters. */
> struct mplsoudp_encap_conf {
> @@ -577,14 +579,14 @@ struct mplsoudp_encap_conf {
> uint8_t eth_src[RTE_ETHER_ADDR_LEN];
> uint8_t eth_dst[RTE_ETHER_ADDR_LEN];
> };
> -struct mplsoudp_encap_conf mplsoudp_encap_conf;
> +extern struct mplsoudp_encap_conf mplsoudp_encap_conf;
>
> /* MPLSoUDP decap parameters. */
> struct mplsoudp_decap_conf {
> uint32_t select_ipv4:1;
> uint32_t select_vlan:1;
> };
> -struct mplsoudp_decap_conf mplsoudp_decap_conf;
> +extern struct mplsoudp_decap_conf mplsoudp_decap_conf;
>
> static inline unsigned int
> lcore_num(void)