From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8A00A0C47; Thu, 4 Nov 2021 16:07:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB22941223; Thu, 4 Nov 2021 16:07:14 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id EC365411C9 for ; Thu, 4 Nov 2021 16:07:13 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 78A6D320153D; Thu, 4 Nov 2021 11:07:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 04 Nov 2021 11:07:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Ej9avkqF0PuSZWX8WXBl/53YHnZC+jQZBTCdRnocLwI=; b=NdTNOhEbj3z3vZ56 1LIht81yFlS8Ed8swVzLs0K63Q0M7SCtMkqhtCwcYHmNouM4xBUsTTYH3v28Eac+ puMrq02N/9MMGokm7MUMbiVs1xok9v+asXEFDThCK/KR0WJFRmvIScwt1wjECMqq QfFuYHxduQJFqSApUwydaczqzaOkRLswFbJbokDR5ckLxFIux6XXAiuB7CIdlzL+ ix2deFp/oXeyQVcfuwdadfkvOj6RgkwSi+ZQ5TykFk5oomwtBAYM47YVmjJBzA7y YON706ggv476NV6qOpZCrgqCPvQo5yZgPTGLHBSa3Ksyk7bsDMdlrDf9vBmxa3RM ldrXLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Ej9avkqF0PuSZWX8WXBl/53YHnZC+jQZBTCdRnocL wI=; b=JngSCWhve8TbyWESCPS6PyqriQw6jC08vgXrnyWwtqGSJzLIDhygWPxrW ox0IxJppEN+5Jkh70BwDWYy8rurdW/xhRCsd6kauX8FbpMCnC6CBcwakeS/+zhDa CK7TypR0QSFzi4VQeSMtXJMkTg0jl9VmMnD/FKPnw4nqVLrcFI+ZESe3KkiLYvq4 yIp3ZVZECZxatWrV5DTDuxiUOi5pxgbW8uQkzGwzWtrvGykyVNWdYrodo3//lzZh F5UzpYBl2l0SGUTjIx9AkjPmxkvc+kYSlYMw39DstmDlluH3X5MPSwZLzbgsUrwx lNaKCnCMy+dngR+k4ag9Iav/1k4/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdeggdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Nov 2021 11:07:10 -0400 (EDT) From: Thomas Monjalon To: Wojciech Liguzinski , Cristian Dumitrescu , Jasvinder Singh Cc: dev@dpdk.org, megha.ajmera@intel.com, Bruce Richardson , david.marchand@redhat.com, john.mcnamara@intel.com Date: Thu, 04 Nov 2021 16:07:09 +0100 Message-ID: <3662122.RA5NCudhvH@thomas> In-Reply-To: <20211104145548.59747-1-thomas@monjalon.net> References: <20211104104918.490051-1-wojciechx.liguzinski@intel.com> <20211104145548.59747-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v24 0/3] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/11/2021 15:55, Thomas Monjalon: > last changes to make this series "more acceptable": > - RTE_SCHED_CMAN in rte_config.h, replacing RTE_SCHED_RED > - test file listed in MAINTAINERS > - few whitespaces fixed Applied this last version. The maintainers of this library didn't help really. Review of basic stuff and process well known by maintainers were not done. Even after doing these last changes myself, this library is still in a poor state. The most problematic is the big amount of dead code disabled in config/rte_config.h: #undef RTE_SCHED_CMAN #undef RTE_SCHED_COLLECT_STATS #undef RTE_SCHED_SUBPORT_TC_OV #define RTE_SCHED_PORT_N_GRINDERS 8 #undef RTE_SCHED_VECTOR I think the most appropriate going forward is to stop merging any feature in the libraries and examples related to sched and pipeline, until a proper resolution is done for this dead code. Tips: make runtime options and properly document them. Note: I probably won't reply to this thread until 21.11 is done, because I have other priorities and I don't want to hear about this for some time.