From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id A55FF5922 for ; Wed, 25 Jun 2014 15:43:22 +0200 (CEST) Received: by mail-we0-f177.google.com with SMTP id u56so2012563wes.36 for ; Wed, 25 Jun 2014 06:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=0s5caQIeTa2cuhFVdRf3tlpi9kLdh3hWtNNUKZK0NyM=; b=fpuB4xA1MdvrDE9FJ1h+PRP3lKc41FPpfAZo/3ab+TZIYpGRsyHGtu9gnnCx1ipIyF ZKrad2BZNWplE4NnOJsRYmFVv+yG02KfYKnnvTOF3IPW75mfTYc/msWhEHVtmGwJOyt7 q0Iv8FY0JaqeOLip6xofGObsoSxcWT3RWAzfz7i2kG1ePw+2unGIuul+OM7NneLHvoww Ggvms4s8C7GiOxBDKGfC1Ag6By1PYLgC/rnMBK6uJ4c2vDl4jMAKpUxxDgwjirFgaxP3 n9diwmeX/uy54N63yMg6CzA6JPqR56kASPBU7daePZqEW7TO+KxxIqsN88ZPa97AVN+G pVBg== X-Gm-Message-State: ALoCoQmrPFape8DqIHsh9UIVLPzntHDCEpsGtCA1BnBuerNv0+I4eKcdxNyJepmn7JiEXPvZ6fvE X-Received: by 10.180.83.202 with SMTP id s10mr34365420wiy.25.1403703819037; Wed, 25 Jun 2014 06:43:39 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dt7sm53954166wic.6.2014.06.25.06.43.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jun 2014 06:43:38 -0700 (PDT) From: Thomas Monjalon To: Declan Doherty Date: Wed, 25 Jun 2014 15:43:32 +0200 Message-ID: <3664505.WcrJi8fzD3@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1403625828-20956-7-git-send-email-declan.doherty@intel.com> References: <1403621531-30487-1-git-send-email-declan.doherty@intel.com> <1403625828-20956-7-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 6/6] Link Bonding Library doxygen additions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jun 2014 13:43:22 -0000 Hi Declan, Since bonding library is a PMD, there should have no need of integrate it in the API documentation. I hadn't time to review it yet, so I would miss something. Do you mean it can be used directly by the application with a specific API? In this case, you could explain it in the commit log. 2014-06-24 17:03, Declan Doherty: > --- a/doc/doxy-api-index.md > +++ b/doc/doxy-api-index.md > @@ -36,6 +36,7 @@ API {#index} > There are many libraries, so their headers may be grouped by topics: > > - **device**: > + [bond] (@ref rte_eth_bond.h), > [ethdev] (@ref rte_ethdev.h), > [devargs] (@ref rte_devargs.h), > [KNI] (@ref rte_kni.h), ethdev should be first in this list. > --- a/doc/doxy-api.conf > +++ b/doc/doxy-api.conf > @@ -30,6 +30,7 @@ > > PROJECT_NAME = DPDK > INPUT = doc/doxy-api-index.md \ > + lib/librte_pmd_bond \ > lib/librte_eal/common/include \ > lib/librte_acl \ > lib/librte_distributor \ Libraries should be in alphabetical order here. Thanks -- Thomas