From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3407FA0548; Wed, 1 Jun 2022 16:38:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D162340689; Wed, 1 Jun 2022 16:38:06 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 029E74003F; Wed, 1 Jun 2022 16:38:05 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AC1675C02C6; Wed, 1 Jun 2022 10:38:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 01 Jun 2022 10:38:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1654094285; x= 1654180685; bh=PwheLwl2+U7qgxNdrIHI/jlK1+j2oBQGY2V7oxSQqvY=; b=r b6mFNsAyQLxH0PjnWuAl0b/GaGwu9qtSdquIHc6N2PcYr9aKPkdf1+ndqs7WqB0u e1MYNwY/9UaqKSknC0S+7+5BrGRjeYcSeRpqVMCXLcIW21g4ktq/+bUbG2H0xGHg oujayGOZsZZ3PVcqglcCNMHiqHqvLzEJOZT6AECNijoWUlZkpIs+/Z6XahBmpSNv qkJCFjCB6Bus7mIos6IuA6aQg6EdkhEGXEs5Pg46+BkLwngGCv9b/jSr+U9iTuU3 aRncFq8a8maep6188G6XKhF1Kaxf5TftTml0ImvvXCFgzje0Zxix/aHpwg2B4lvJ 0SoyfBj4urhE/zP9gYfDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1654094285; x= 1654180685; bh=PwheLwl2+U7qgxNdrIHI/jlK1+j2oBQGY2V7oxSQqvY=; b=f k+wWAQj6FQXAJcwY8CBh94Q3xx8AomPD0U+ZkorhzoWUEbO5waDJAS5SuCZJx6Mh W1lRx1uEmGqBnjMBHhCVXZkhEKWVDGFPycnpkBYqNG8dNm9VIsVgm35/Sbd5JJg6 0ocoZAlQPYyIR2Ho9+BmM62dHe5lpWFBBKYQ8L/c2cSuTJaepsK9/hyABvme8F+5 lAxKSbJLUWARqemdN69gbKrVgDpaffx4Rh1/pWuApoRJ5H1YQK2Ruh3sLpT4N0jn y9Q+y48bcSorN93qcINeUp67JtGYwdJ++lSo5XF2AVluRPGuwRtKU9j3+nZtQBMR Fn1JLnBf3QJn/5XbtMMtg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrledtgdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Jun 2022 10:38:03 -0400 (EDT) From: Thomas Monjalon To: Quentin Armitage Cc: dev@dpdk.org, Reshma Pattan , Ray Kinsella , dev@dpdk.org, stable@dpdk.org, Stephen Hemminger Subject: Re: [PATCH v2] libpcapng: fix timestamp wrapping in output files Date: Wed, 01 Jun 2022 16:38:01 +0200 Message-ID: <36758990.XM6RcZxFsP@thomas> In-Reply-To: <20220517081521.636cb5a0@hermes.local> References: <20220511094655.4f885c84@hermes.local> <20220517100115.157888-1-quentin@armitage.org.uk> <20220517081521.636cb5a0@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/05/2022 17:15, Stephen Hemminger: > On Tue, 17 May 2022 11:01:15 +0100 > Quentin Armitage wrote: > > > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 > > seconds after pcap_init is called when using a TSC with a frequency > > of 2.5GHz. > > > > To avoid the overflow, update the saved time and TSC value once > > delta >= tsc_hz. > > > > Fixes: 8d23ce8f5ee ("pcapng: add new library for writing pcapng files") > > Cc: stable@dpdk.org > > > > Signed-off-by: Quentin Armitage > > Thanks for fixing this. > > Acked-by: Stephen Hemminger Applied, thanks.