From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BA35AA0540;
	Thu,  7 Jul 2022 11:05:16 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5DA7C40A7B;
	Thu,  7 Jul 2022 11:05:16 +0200 (CEST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 0EEFD406B4
 for <dev@dpdk.org>; Thu,  7 Jul 2022 11:05:15 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 975025C018E;
 Thu,  7 Jul 2022 05:05:14 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Thu, 07 Jul 2022 05:05:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm3; t=1657184714; x=
 1657271114; bh=yp84JoGrBx8Ygi0Q1Up30YjuNj98N2aQCDcvbiVIHQM=; b=n
 3cOdcDqLs8t6Lz7fQ5SNnsg6gpb7w+1R4nQvpOeOW39SolhAw8k1ef9aKfLj48oj
 sVlvH+ILMr7UW5NyAJGAzTHIHcmAeCNqa4w6TcrOqjzqaWMERZhotTJjrCivBK7o
 a6ScB9+obcbCsqkpVHd4usNaH9C3/5wIbrdpeVI8sHmslF+gr6BrkA1nAigGppZR
 RnM3BmUknIwPqI+FGk1JXPjFndvZ/x97DGdiU5tZs73j/SQi6h3DRQmockajE0Tw
 ulPGbTyJNYF6VGEFVIsXN9c8ka5j2Un11dI1J49ke8ZZ/YILfIofhhLaJAiMYGRT
 1OpP1vninKCEMH+h9+YIQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657184714; x=
 1657271114; bh=yp84JoGrBx8Ygi0Q1Up30YjuNj98N2aQCDcvbiVIHQM=; b=b
 zbuZSRZ29eIGLFro+g7hnK8qcWjGBM2veKchD6BVw3yA98YMcggInwwiI520Erab
 yNkHPj29rl3ZLZJ+EODaKGboPEmZm72JREnEsPuhMaoasSMZbrrVWssU4P0bdGxM
 Nf9P3w8JkZJ+I1o5HBNJQsze9RCuSoDBn9J9sLranzWy4rB1BlmTxjRAWIYjvUFM
 YfVw6P8SKkcuNW6BpkJbamnvgZMAlWQlvEaWQEHfdwSc1xO2Fm/uVyAbdybED7vP
 hhFEDmgZp5tZCqxv8Lu1wowU36yzUha0Irq9+JgtxyDi5vBnwnS69wXQ7He/KgLl
 4TzMwn/GvLERvgUD0Dd2w==
X-ME-Sender: <xms:yqHGYr9atl8Q6S3ipxmtTJAwW6ZTZFG9NpnULXqOcLOSvgMx0nbM7w>
 <xme:yqHGYntZNii8WNDOOOw1ZlYTrnUuWb8B2zxy4d53Boe_SY5XYbcUVf5lkAgeoI0Ov
 gpBlv5JyYMcS11yqg>
X-ME-Received: <xmr:yqHGYpDzTBKDZz9wyTm068sfQeRu9ZZtnkBuRErODFZPS8Aa0SUDlPHo0HKYTGkzOXuIri_FNGLeXJtROOfmz9llDQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeihedgudduucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfgjfhgggfgtsehtuf
 ertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs
 sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnheptdejieeifeehtdffgf
 dvleetueeffeehueejgfeuteeftddtieekgfekudehtdfgnecuvehluhhsthgvrhfuihii
 vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh
 drnhgvth
X-ME-Proxy: <xmx:yqHGYneAOpsCTPU8rci1kDc8SmhAuJ7CWRGabehP1IWTb1zioltt6w>
 <xmx:yqHGYgNhS4M4PLTdCMFgJIc9k54z-H3hqySsTsUY9rEHx_z69O_f4A>
 <xmx:yqHGYpmc6yk3uaJq4jenKK2Te4ISlPEdj6FHYzSncNBjd33US7rH9g>
 <xmx:yqHGYhjgX9QRrR52_iUhF84AZWr12EDesBySm3fBwBmF7AnkDo_bJQ>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 7 Jul 2022 05:05:12 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Wenxuan Wu <wenxuanx.wu@intel.com>
Cc: andrew.rybchenko@oktetlabs.ru, xiaoyun.li@intel.com,
 ferruh.yigit@xilinx.com, aman.deep.singh@intel.com, dev@dpdk.org,
 yuying.zhang@intel.com, qi.z.zhang@intel.com, jerinjacobk@gmail.com,
 stephen@networkplumber.org
Subject: Re: [PATCH v9 1/4] ethdev: introduce protocol header API
Date: Thu, 07 Jul 2022 11:05:11 +0200
Message-ID: <3684735.UjfFaoq8vQ@thomas>
In-Reply-To: <20220613102550.241759-2-wenxuanx.wu@intel.com>
References: <20220303060136.36427-1-xuan.ding@intel.com>
 <20220613102550.241759-1-wenxuanx.wu@intel.com>
 <20220613102550.241759-2-wenxuanx.wu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

13/06/2022 12:25, wenxuanx.wu@intel.com:
> From: Wenxuan Wu <wenxuanx.wu@intel.com>
> 
> This patch added new ethdev API to retrieve supported protocol header mask
> of a PMD, which helps to configure protocol header based buffer split.
> 
> Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
> ---
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> + * Get supported header protocols to split supported by PMD.
> + * The API will return error if the device is not valid.
> + *
> + * @param port_id
> + *   The port identifier of the device.
> + * @param ptype
> + *   Supported protocol headers of driver.

It doesn't say where to find the types.
Please give the prefix.

> + * @return
> + *   - (-ENOTSUP) if header protocol is not supported by device.
> + *   - (-ENODEV) if *port_id* invalid.
> + *   - (-EIO) if device is removed.
> + *   - (0) on success.
> + */
> +__rte_experimental
> +int rte_eth_supported_hdrs_get(uint16_t port_id,
> +		uint32_t *ptype);

The function name is not precise enough.
There should be the word "split" in its name.