From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D964423B5; Thu, 12 Jan 2023 11:40:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38F8040156; Thu, 12 Jan 2023 11:40:47 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id C124F400EF for ; Thu, 12 Jan 2023 11:40:45 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 58DDA5C02C1; Thu, 12 Jan 2023 05:40:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 12 Jan 2023 05:40:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1673520043; x= 1673606443; bh=Tcdd3B2oHgw+WYBnlZTRker/cioubtvOGjEiZy6UDJI=; b=V kL53UsS1U8llqn5jMQdZ8qrMyXGbgEFIWFeuVABNTrlKPrW0Yu7LIKwDs4Jd2r2T g3+liyn3vIhG51zjB09c4Ab3WZ5ABdRUhKLraItiE1/FIlC6/EDSxX0PPRhGZLQ1 k+3zpcjg5f3N6ce8JxXMY0OYxxqNySVIYVp9be7PJvVZmlflcqnIk7tD9kQtS16z I5KbZruk/h7dHdGmxj+xgqQdJ2dMJcTozifvIziQYzPuw00eOPEL0lbMh9yII0mQ gAY5gXNsCBRHqDt+a2NikllyiR3UUrr/4Ms1WnVa/VV1ABrCwwiYH2QMlR/Ok+qT 9agNM3R13EQ6ColjgJOZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673520043; x= 1673606443; bh=Tcdd3B2oHgw+WYBnlZTRker/cioubtvOGjEiZy6UDJI=; b=U n7nA4MXAAMCqqp7xVLV1QZKCfuajZxfijBzJvykgVHpW9s50VspW29VZFXgnF0/N ScxMOIBiYbTTlGlDtMg6xlJRuW17Mf5EF+swoPyQDYYMCi7dPtgzB08qODZSHNeX A/BzVr2xIShEEEAsd9a6k65EBt3139HSaHREAoyeO7uWyEOniIw6nzXo12eGxMBu pwCp3W9gKRPskZtFeEBqqaUl6ShQjaEY4/gByG9ehi9gbgamKLdeuJnbKxibfEcd rqjv9XTEwG25nykib6Rt3nESAXEMPFb1ziDaQMl6Efzme+1Yj5X+ctCy66LlFsYW f1RG2kIo4ijDlKRn76k6w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleeigddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Jan 2023 05:40:41 -0500 (EST) From: Thomas Monjalon To: "De Lara Guarch, Pablo" , Akhil Goyal , "Ji, Kai" Cc: "dev@dpdk.org" , Tyler Retzlaff , "dev@dpdk.org" , David Marchand , "Dooley, Brian" , "Power, Ciara" , "Mcnamara, John" Subject: Re: [PATCH] crypto/qat: fix build Date: Thu, 12 Jan 2023 11:40:39 +0100 Message-ID: <3685739.QJadu78ljV@thomas> In-Reply-To: References: <20221230210728.86920-1-thomas@monjalon.net> <9337009.CDJkKcVGEf@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/01/2023 11:32, Ji, Kai: > Ok, a long story short, this issue should only occurred when RTE_QAT_LIBIPSECMB is enabled. > It was intend to remove Openssl lib dependency in QAT replaced with ipsec_mb lib, but the work was partially done due to limitation of ipsec_mb by the time (FIPS certification) > > I'm happy with current fix and please cc: stable@dpdk.org I'm not happy with this fix. It is a dirty workaround. It would be better to have an #ifdef in ipsec_mb. Also I would like an answer to the question below. What triggered this error? Is it a new thing in the lib ipsec_mb? Why defining AES_BLOCK_SIZE while IMB_AES_BLOCK_SIZE can be used and have a proper prefix? > The fully removal of Openssl dependency is already ongoing, I will take a note to fix this properly > > Regards > > Kai > > > From: Thomas Monjalon > > Subject: Re: [PATCH] crypto/qat: fix build > > > > Waiting for an answer here. > > The commit log is not supposed to stay like this with questions. > > > > > > 11/01/2023 10:03, Thomas Monjalon: > > > 04/01/2023 12:56, Akhil Goyal: > > > > > On Fri, Dec 30, 2022 at 10:07:28PM +0100, Thomas Monjalon wrote: > > > > > > When trying to compile on a fresh system, I hit this error: > > > > > > > > > > > > intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined > > > > > > 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE > > > > > > In file included from drivers/crypto/qat/qat_sym_session.c:8: > > > > > > /usr/include/openssl/aes.h:26: previous definition > > > > > > 26 | # define AES_BLOCK_SIZE 16 > > > > > > > > > > > > I don't know why it was not seen before. > > > > > > Is it because of a change in intel-ipsec-mb.h or in OpenSSL? > > > > > > > > > > > > Signed-off-by: Thomas Monjalon > > > > > > --- > > > > > > > > > > owners of intel-ipsec-mb.h should guard against the namespace > > > > > conflict... > > > > > > > > > > Acked-by: Tyler Retzlaff > > > > > > > > Applied to dpdk-next-crypto > > > > If there is no better fix, we should at least add Cc: stable@dpdk.org > > assuming it could be reproduced with an older DPDK. > > > > > > > > > > Thanks. > > > > > > I'm concerned to have no answer from Pablo and Kai. > > > It is real design problem. Is there any plan to have a protected > > namespace?