From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CD63A0C41; Wed, 17 Nov 2021 10:43:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28D1240687; Wed, 17 Nov 2021 10:43:02 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 9F1EB40040 for ; Wed, 17 Nov 2021 10:43:00 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E43525C0116; Wed, 17 Nov 2021 04:42:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 17 Nov 2021 04:42:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= K06Fp5vKr0axGUUmWbDL5C7WisBbV+gN0jVFJ90vQyk=; b=iOBM7WT3Q+EJv+G/ Po7K94yN5Z1e6tW1jeCChDHqLKZaU6B6MQ5Z7zbhz2pfnMJ0kyCvhdyVGZV//HNQ +q7MnZ7WxRgC0bU5BckMlixgeDyQQVtXYhVH10RcKDdnkhtEIjzxyYgpBsPZRkml N1a6kGkonqVRluN7IbBs9Z3f6huCPGTS5Rdv8tZ+4DRBN/0ZXMCF3+KnG30PBvRG unxji403h+F0O1trI0tCSSuH1/cH6dJUezV5fkB492eU5Zxuy6M4Ht5+KMjd+J0s mEi5fJmHtFuhJ/ndI3JYgWtIP0wh3zCNnXbrU1GrnMIpBU9Dscf1lPnMqChg6O61 OAceZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=K06Fp5vKr0axGUUmWbDL5C7WisBbV+gN0jVFJ90vQ yk=; b=lJljJIM8TkSiN9xqHZxD4nufwHUYZyuldpONGUstjoYcn1Ydm1WCtoV+G 8Jb+7K5hBjyNNO9aBxK0ED3mXQtYZ0fpf13pyoSbDq+CL6r0Uk+NK4rVGTH6RiAz wLsO/MfdLXcJyQ5xIfhY5gkNa4qqHJ4MqS3ZYmKPE7u+xJZ8gCnNF+/cC97fCVS7 IpQn8umURE0DbbAqstLFkG2zo8yM7EXI2/rmrSrNsyrA5AlaloFyJy6sV869Zhrf xn20EWpC8Sgwo+IdwARBMzrFqTouEssn1qnYbT8Ma2NnxDHbFJPyZm/8G8FQdxMz zcZ3VTG910FEgyVfhHtOYIDQGoi7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfeeggddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Nov 2021 04:42:59 -0500 (EST) From: Thomas Monjalon To: Michael Baum Cc: dev@dpdk.org, Matan Azrad Subject: Re: [PATCH] common/mlx5: fix redundant field in MR control structure Date: Wed, 17 Nov 2021 10:42:57 +0100 Message-ID: <3689260.RXIX8NE3PJ@thomas> In-Reply-To: <20211116143635.1863313-1-michaelba@nvidia.com> References: <20211116143635.1863313-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/11/2021 15:36, michaelba@nvidia.com: > From: Michael Baum > > Inside the MR control structure there is a pointer to the common device. > This pointer enables access to the global cache as well as hardware > objects that may be required in case a new MR needs to be created. > > The purpose of adding this pointer into the MR control structure was to > avoid its transfer as a parameter to all the functions of searching MR > in the caches. > However, adding it to this structure increased the Rx and Tx data-path > structures, all the fields that followed it were slightly moved away > which caused to a reduction in performance. > > This patch removes the pointer from the structure. It can be accessed > through the "dev_gen_ptr" existing field using the "container_of" > operator. > > Fixes: 334ed198ab4d ("common/mlx5: remove redundant parameter in MR search") > > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/common/mlx5/mlx5_common_mr.c | 42 +++++++++++++------------ > drivers/common/mlx5/mlx5_common_mr.h | 8 ++--- > drivers/compress/mlx5/mlx5_compress.c | 2 +- > drivers/crypto/mlx5/mlx5_crypto.c | 2 +- > drivers/net/mlx5/mlx5_rx.h | 13 ++------ > drivers/net/mlx5/mlx5_rxq.c | 3 +- > drivers/net/mlx5/mlx5_txq.c | 3 +- > drivers/regex/mlx5/mlx5_regex_control.c | 3 +- > 8 files changed, 36 insertions(+), 40 deletions(-) Applied, thanks.