From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 31169568A for <dev@dpdk.org>; Mon, 23 Nov 2015 23:56:22 +0100 (CET) Received: by wmec201 with SMTP id c201so183552714wme.0 for <dev@dpdk.org>; Mon, 23 Nov 2015 14:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Fm7g/zLS81XjVD7VsIea46QIUQO+lQeW+YS2rLo6XyQ=; b=1IaI0JiIq8KFfA1KWsn9uFVRutI6CHHmRCLTKG+vcY4PhyjxkxcyOLF0ycYPOdJ2vh 3uslob8rpSOmlTWB7n1h/kyieu0YHuWDPQCkZJWMFe7olzqCUyL/DsBde9YZsC1meZo8 tmRjzEMTbegsPD73HiWsl/oUwCCIhQTWsBlTiFUsQVSwdtyu4KgHCxGwDbQK4CeY2Q3A aAkHGfVHmDwdKmDO84vI38UV+dpMpdFE7hqAS0igAaMex9NprJ65hMI2W0aVofIUI1Lu a5VFCWIgY3pYq7/Ijx8lPNdzYuPJ/dBOYnvXUagcnyTLezf7sW/GMKlHcInMcJuHdekz iYmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Fm7g/zLS81XjVD7VsIea46QIUQO+lQeW+YS2rLo6XyQ=; b=IYZxNLG762skUgpiLe8Oym6GikypSfflN/7YxZ4daeT/L4fIHD7Va4dfcMF0wz9jiO copA+MD8e5+1VJ+dsgsJxPNcm9HCGO4OtpvMzhQEXXE5wUwwPZjG2ax8MCZfHkh/CnX9 5AOjdAD50y7phPyAQE5YeBkZNzf/hSkXi0b9rNqWjCN2yRIj1XyYJW7FVx2E1P29xWBi /VWufxS7qj7yS0fMRApW7fteZi1I/Oi9030XIPU/jMleWb+cDEx5dmW5yBxUQVrT0on9 cQwxNsGy9MiXYe4GekgLIAC3eZCWu+hvwBnyMIWj9dwEjWTttHtPliZ+3UxRaBWJmGG1 tjGQ== X-Gm-Message-State: ALoCoQmOK9z8u43F1FnnGWSq56Gos78QdnygAk2qQnOYqgARoRRRbe+cLSiXhB3N0rNTPLjJ1uoz X-Received: by 10.28.156.75 with SMTP id f72mr19739159wme.91.1448319382004; Mon, 23 Nov 2015 14:56:22 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id cv3sm15372521wjc.20.2015.11.23.14.56.21 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Nov 2015 14:56:21 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Chen Jing D(Mark)" <jing.d.chen@intel.com> Date: Mon, 23 Nov 2015 23:55:05 +0100 Message-ID: <3695173.dQDnAloRu5@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1447304251-4145-1-git-send-email-jing.d.chen@intel.com> References: <1447304251-4145-1-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] fm10k: fix a crash bug when quit from testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 23 Nov 2015 22:56:22 -0000 2015-11-12 12:57, Chen Jing D: > From: "Chen Jing D(Mark)" <jing.d.chen@intel.com> > > When the fm10k port is closed, both func tx_queue_clean() and > fm10k_tx_queue_release_mbufs_vec() will try to release buffer in > SW ring. The latter func won't do sanity check on those pointers > and cause crash. > > The fix include 2 parts. > 1. Remove Vector TX buffer release func since it can share the > release functions with regular TX. > 2. Add log to print out what actual Rx/Tx func is used. 2 parts mean 2 patches. [...] > + if (rx_using_sse) > + PMD_INIT_LOG(ERR, "Use vector Rx func"); > + else > + PMD_INIT_LOG(ERR, "Use regular Rx func"); Why using en error log level?