From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FCB1A00C5; Wed, 14 Sep 2022 16:28:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEE584021D; Wed, 14 Sep 2022 16:28:37 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id BF90D40156 for ; Wed, 14 Sep 2022 16:28:36 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 323395C0046; Wed, 14 Sep 2022 10:28:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 14 Sep 2022 10:28:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663165716; x= 1663252116; bh=Yp2R3SnxFnUaIiTyZwDY5cIYUoSHO+WIyHtaPkkJIpY=; b=0 hwxgoWOrMddcGwK3zokcNmDaAagDjm3TJ5y3Y8kZ+WoEMU5ZWY8mnAUxvQCJ1KiP wqs//3xitFNC12CJzGz3dgmj4arX37v+Y9r+S8x0ccYaPNISwKzeoQNAF4UtbU1k SeUfvEfKDv9eI6UsPjAucYwzow+PalJZvifZnOnj+P1Ygfjuu7TP5v0BhhodRZs8 Ne1GnNyxJuGRIKJlk0kikoRPHiaMCf4N0Tv8xSysjjdiL3p3Jta9EaoPzeMprti1 f3ZA0mDqHtRm5KeKgphpnUGS8I2GHicrKrVwPOUUYv/5jivf8b9HbW2f1ZZMkf+u TWa/xV96lGNmHWG6mY16w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663165716; x= 1663252116; bh=Yp2R3SnxFnUaIiTyZwDY5cIYUoSHO+WIyHtaPkkJIpY=; b=s ylxtfy8iZp3WX5t12V6fVTNfR9fsnocKifzn2Ub3XxbMUrqS+jQ0PGATWEkg3mej yEYUaVZa6blvRavuybXwCSwYX/lDn+yZdH1KSZR68E30yn/1jp3wSNcpNI5sDOsM 0Cbxml0ATCqW1dJrm1mAd3BYnLmDTim0Tfyz77f7vPjLp7H73VhQt4inqDxgcI7l zhdH0rNhG5ew8oe2T69dKUzD7enyu318TviRBYKbByem6rOWhHILN2hq/51lUxry 7ggW0jKfJNZePp1BmUY8gFMPP+3/5765zudMrm+WfeXneGdoH+mf0JGwfi6BXlkH AYugkYwhlG9HLmC4T4Sfg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefkeektefgkedthffgvdeluefggfevffdtleelgfeijedujefg udfhtdefveegueenucffohhmrghinhepvgguihhtohhrtghonhhfihhgrdhorhhgpdhrvg grughthhgvughotghsrdhiohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 10:28:35 -0400 (EDT) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= , Bruce Richardson Cc: Honnappa Nagarahalli , "david.marchand@redhat.com" , "ronan.randles@intel.com" , "ohilyard@iol.unh.edu" , "lijuan.tu@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH v4 1/9] dts: add project tools config Date: Wed, 14 Sep 2022 16:28:33 +0200 Message-ID: <36960503.XM6RcZxFsP@thomas> In-Reply-To: References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/09/2022 15:11, Bruce Richardson: > On Wed, Sep 14, 2022 at 12:55:21PM +0000, Juraj Linke=C5=A1 wrote: > > From: Thomas Monjalon > > > 13/09/2022 21:19, Honnappa Nagarahalli: > > > > > > > > > --- /dev/null +++ b/dts/.editorconfig @@ -0,0 +1,7 @@ +# > > > > > > > > > SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2022 > > > > > > > > > +PANTHEON.tech s.r.o. +# See https://editorconfig.org/ f= or > > > > > > > > > syntax reference. +# + +[*.py] +max_line_length =3D 88 > > > > > > > > > > > > > > > > It seems strange to have two different editorconfig settings > > > > > > > > in DPDK. Is there a reason that: a) we can't use 79, the > > > > > > > > current DPDK default and recommended length > > > by > > > > > > > > pycodestyle? Or alternatively: b) change all of DPDK to > > > > > > > > use the 88 setting? > > > > > > > > > > > > > > > > Also, 88 seems an unusual number. How was it chosen/arrived > > > > > > > > at? > > > > > > > > > > > > > > > > > > > > > > The commit message contains a link to Black's documentation > > > > > > > where they > > > > > > explain it: > > > > > > > https://black.readthedocs.io/en/stable/the_black_code_style/c= urr > > > > > > > ent_ st yle.html#line-length > > > > > > > > > > > > > > Let me know what you think about it. I think it's reasonable. > > > > > > > I'll move the > > > > > > config to the top level .editorconfig file. > > > > > > > > > > > > > > > > > > > I have no objection to moving this to the top level, but others > > > > > > may like to keep our python style as standard. Realistically I > > > > > > see three > > > choices here: > > > > > > > > > > > > 1. Force DTS to conform to existing DPDK python style of 79 > > > > > > characters 2. Allow DTS to use 88 chars but the rest of DPDK to > > > > > > keep with 79 chars 3. Allow all of DPDK to use 88 chars. > > > > > > > > > > > > Of the 3, I like relaxing the 79/80 char limit so #3 seems best > > > > > > to me as you suggest. However, I'd wait a few days for a > > > > > > desenting opinion before I'd do a new patchset revision. :-) > > > > +1 for option #3, it seems reasonable > > >=20 > > > In .editorconfig, we have this default: max_line_length =3D 100 It is > > > also documented in our guide. > > >=20 > > > For Python we have this exception: [*.py] indent_style =3D space > > > indent_size =3D 4 max_line_length =3D 79 > > >=20 > > > I'm OK to increase it to 88 as it does not exceed the default. In any > > > case, it should be documented in the style guide. > > >=20 > >=20 > > Where is the best place to document it? I'm thinking of adding a DTS > > Coding Style into contributor's guidelines, right after DPDK Coding > > Style. Or do we want to have separate DTS docs? >=20 > +1 for having it in the existing contributors doc. We want people to subm= it > code + DTS tests at the same time, so having the contribution docs combin= ed > will help with this. It also should help us to try and align the two codi= ng > styles for python. In future, we should perhaps update DPDK python code to > align to DTS coding style rather than having two styles in the one repo. +1 for targetting unified coding style