From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35DAEA0562; Wed, 14 Apr 2021 22:17:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 216C1161D03; Wed, 14 Apr 2021 22:17:16 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 755F1161CFD for ; Wed, 14 Apr 2021 22:17:14 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id EB90D5C00A3; Wed, 14 Apr 2021 16:17:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 14 Apr 2021 16:17:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= rPXDOKzrOM2VUpInFtg0oby1MvNqMVCpX8plaYZKT04=; b=s3/YOGxJWJgbKNSB /sChQFkieEVUZ1GQJhBMvZSScF5GICygT3xoicgAH5cFjETnfy1zCjQ8bdo4oSMZ QBbW3cHfdrz3zetSXCzbrhSYxhp9ejlD8vBwca7cOQ1zrgj3C5Rd2r1vwnzDK+uQ wVbzYXJ4imASDQCbNr9zmQpIcl/T163m0o/EqVmi9OP04HyFojvBxbtT2RZiDufh rnDXHXESli5HPuovM01Nlrt3I7dJz7wgYTc0+IbDIa4/Vp+sjstt8UOXT76YWt+T QDEzzc0K0/91R37+tBgpHQD2C6D8Vup79QteUEtgsxPp0AbfaaIJpgTpG+ujIRcq zynG6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rPXDOKzrOM2VUpInFtg0oby1MvNqMVCpX8plaYZKT 04=; b=g4yz1qHQulsnNL7xDoxwBhpsjRiG967joVC/HX9GPQ47nS1iNgePeGpYz r1UNyCAw7PcFDkDFHmzDPCv0Ku9TJS/yu2XfN1NDUHL3IIphoXserdnLZdAdpOej F7FESM2SebkcRr7cx4G8usIg3HkCh1ZzWtj8lyRQLYC5bAxR7ixDFVcHJJNosEGo ybsAnZkLOc6hE+WXaxkpP4WQWX6WJJcdhL3Qvd2xtdD1B0HHkjxtVKtCHE7n+5VZ 7iTIi99zV0E7NiGwGMUL5hDqWIhp5d6MuimH0xT5msp13/98/3ZM6FyMfunNPzQ/ 4CDMuOwj87z0qGfKGr38Tv//srJRw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgudeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeeh teffvdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefge drvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 39B4B24005D; Wed, 14 Apr 2021 16:17:12 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: dev@dpdk.org, "arkadiuszx.kusztal@intel.com" , Anoob Joseph , Matan Azrad , Ray Kinsella , Declan Doherty Date: Wed, 14 Apr 2021 22:17:11 +0200 Message-ID: <3696240.PSe9F7JUGx@thomas> In-Reply-To: References: <1612449252-395208-1-git-send-email-matan@nvidia.com> <2068151.q8ePLV6qny@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v4] cryptodev: support multiple cipher data-units X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2021 21:43, Akhil Goyal: > > 14/04/2021 20:37, Akhil Goyal: > > > Hi Thomas, > > > > > > > + RTE_STD_C11 > > > > + union { /* temporary anonymous union for ABI compatibility */ > > > > + > > > > struct { > > > > const uint8_t *data; /**< pointer to key data */ > > > > uint16_t length; /**< key length in bytes */ > > > > @@ -222,6 +225,27 @@ struct rte_crypto_cipher_xform { > > > > * - Each key can be either 128 bits (16 bytes) or 256 bits (32 bytes). > > > > * - Both keys must have the same size. > > > > **/ > > > > + > > > > + RTE_STD_C11 > > > > + struct { /* temporary anonymous struct for ABI compatibility */ > > > > + const uint8_t *_key_data; /* reserved for key.data union */ > > > > + uint16_t _key_length; /* reserved for key.length union */ > > > > + /* next field can fill the padding hole */ > > > > + > > > > + uint16_t dataunit_len; > > > > + /**< When RTE_CRYPTODEV_FF_CIPHER_MULTIPLE_DATA_UNITS is > > > > enabled, > > > > + * this is the data-unit length of the algorithm, > > > > + * otherwise or when the value is 0, use the operation length. > > > > + * The value should be in the range defined by the dataunit_set field > > > > + * in the cipher capability. > > > > + * > > > > + * - For AES-XTS it is the size of data-unit, from IEEE Std 1619-2007. > > > > + * For-each data-unit in the operation, the tweak (IV) value is > > > > + * assigned consecutively starting from the operation assigned IV. > > > > + */ > > > > + > > > > + }; }; /* temporary struct nested in union for ABI compatibility */ > > > > + > > > Can we add a deprecation notice also in this patch to remove these > > temporary > > > Struct and union, so that we remember to remove them in 21.11 > > > > I thought about it, but a deprecation notice may involve > > new design considerations and requires 3 approvals. > > I think it is better to send it separately. > > In that case you can send it as a separate patch now only. > Just wanted to make sure that it is not forgotten. Yes, sent: https://patches.dpdk.org/project/dpdk/patch/20210414201544.1063413-1-thomas@monjalon.net/