From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BFE5A2C38 for ; Thu, 28 Feb 2019 12:14:34 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C2A94231EF; Thu, 28 Feb 2019 06:14:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Feb 2019 06:14:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=GPTNXAphAAWDmuUkR+1QGuCW1xBMlQVzFTvscUYkA3M=; b=eRcF6lUhDJMy Nh5a/8I2QZmrZgwJTvGLWza9l218BYT8r4Qfge2WfIJWh0eZNgnnWo/Cxz5J9qjY ieD8CQkJnJAfDR4hZs3h3dr2sVZr/tWGxJBac2R8IotM9nGplRReXM3vF0l4opFN AHd6kFS7H8VdI4XXxJmYslLhJ+8dMIk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=GPTNXAphAAWDmuUkR+1QGuCW1xBMlQVzFTvscUYkA 3M=; b=0uXN8NvXvG6ySbrjayXqzJPgdQ7doo6TBRDWcC9KOSFBNNe++H2zn0JEJ oOZBq0IScNETxCc5By50rPcKZWaWAuxWfGiwlIZeA+QoLR43rOO9EpwO1RX+7cl9 CtaVzKcPR2gOqkWH/1aEBSLoSm8/ZY8ub9creBHd00RGMHqwCXt50K25VaZEK8+J 4i3GvM1L8XDDDAkakUFLD03OvMOL9X0Qt2msd+T4WfecM3/zV1uKVo33PfE/4RaX qM2yRaDYAeO6TYzWcwF2X/gtJ+YdO4JMs/kOgqHrs40rwIcYjSw1x5ROIMMgmJJ9 EKmNjuUjHgdnU5U2sGlU/DPJR7XPA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdefgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epleefrdeirddugeelrdduudegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr shesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id B342010330; Thu, 28 Feb 2019 06:14:28 -0500 (EST) From: Thomas Monjalon To: Michael Santana Cc: dev@dpdk.org, Van Haaren Harry , ramirose@gmail.com, Bruce Richardson Date: Thu, 28 Feb 2019 12:14:23 +0100 Message-ID: <3696913.gDqFAc8s5c@xps> In-Reply-To: <20190214193547.30783-3-msantana@redhat.com> References: <20190213190813.12702-1-msantana@redhat.com> <20190214193547.30783-1-msantana@redhat.com> <20190214193547.30783-3-msantana@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/2] Fix variable assignment. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 11:14:35 -0000 Hi, Few minor comments, The title should start with "devtools:" and not end with dot. One suggestion: devtools: fix result of svg include check 14/02/2019 20:35, Michael Santana: > Fix trivial bug. In sh shell, 'foo = 1' is not the same as > 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo > as a command, rather than a simple variable assignment. Yes, good catch, thanks. > Signed-off-by: Michael Santana > Fixes: dafc04c15174 ("hash: fix out-of-bound write while freeing key slot") The reference should be: Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks") and it should be followed by: Cc: stable@dpdk.org in order to be backported.