From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87B44A0032; Wed, 11 May 2022 13:43:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30DE9410F2; Wed, 11 May 2022 13:43:41 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 0316540DDD; Wed, 11 May 2022 13:43:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652269419; x=1683805419; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=rJwDFkXUkT0QzS2mOKo9U5+pt+RPNxR5xl5E1YAiYYg=; b=TuNNsXo4/DoMEhEiptdv+ev1E8c55q+wAE4aqTe1N7zvz1wPatK/vsui 2/bgIh7VlR+Ga3RAXQPCzh4yAWZXX/heMr50mPYIkQ/0hEez05u0S0+LQ TLQieZWpWWNMA8cQW/MKkvpE+5ZtZfQE95LOHvAPNYnRfIyL6XMO+2f4f eCUU5Upl6qSL0ti+AFo+GgQBTpuFegKq4pgpo2D0byjIsh/WspvpchOuk cB8ys99dgicxqvqaFVRYmAWIObRjmrU+43PUuH3rGZMYfSY5ZVBhKQvkk yIljETGOUh++bFeoDVwXawoH0kbgSCObudP9BQo1ja1FZ06JrP00xnFSK g==; X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="249569415" X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="249569415" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 04:43:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="697540208" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 11 May 2022 04:43:36 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 04:43:36 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 04:43:35 -0700 Received: from fmsmsx612.amr.corp.intel.com ([10.18.126.92]) by fmsmsx612.amr.corp.intel.com ([10.18.126.92]) with mapi id 15.01.2308.027; Wed, 11 May 2022 04:43:35 -0700 From: "Zhang, Qi Z" To: Jeff Daly , "Yang, Qiming" , "Wu, Wenjun1" , "Zhao1, Wei" , Xiao Zhang , Xiaolong Ye , Lunyuan Cui CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Thread-Topic: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Thread-Index: AQHYZJ/eHcrsLDd7GE+WnjXf9lsRJa0Zj1CQ Date: Wed, 11 May 2022 11:43:35 +0000 Message-ID: <36a68dda846440738e43d83a105b358c@intel.com> References: <20220510185725.27001-1-jeffd@silicom-usa.com> In-Reply-To: <20220510185725.27001-1-jeffd@silicom-usa.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jeff Daly > Sent: Wednesday, May 11, 2022 2:57 AM > To: Yang, Qiming ; Wu, Wenjun1 > ; Zhao1, Wei ; Xiao Zhang > ; Xiaolong Ye ; Lunyuan Cui > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate > devices >=20 > 1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to the S= FP > cage on these cards) is not asserted to avoid incorrectly reporting link = up when > the SFP's laser is turned off. >=20 > ff8162cb957 limited this workaround to fiber ports >=20 > This patch: > * Adds devarg 'fiber_sdp3_no_tx_disable' not all fiber ixgbe devs use > SDP3 as TX_DISABLE >=20 > Fixes: 1ca05831b9b ("net/ixgbe: fix link status") > Fixes: ff8162cb957 ("net/ixgbe: fix link status") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jeff Daly Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi