From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4D46A0567; Tue, 9 Mar 2021 11:19:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8394422A493; Tue, 9 Mar 2021 11:19:02 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 6AE4022A443 for ; Tue, 9 Mar 2021 11:19:00 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id CF5CA7F4A0; Tue, 9 Mar 2021 13:18:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru CF5CA7F4A0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1615285139; bh=iBdpEI5NUulRrUFGXoxhts4RB5kw09jHBawtDQHtZJg=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=FF5f59Wss4kzoJ2A1UZOOg8maze5MVTdUoirYbHun6F/ldAdi0Fc5b2MCLpyhcbAu 6ie+mVor6YyB1WKHCHCbWH7S5r+xcjEIkNQlhK6EZfRUr4UgVTa1511wnujHuoIj0K elS0c8evn0bo7BUvniJhT/ViSj1+qaEqMi576DiE= To: Thomas Monjalon , oulijun , Ferruh Yigit Cc: xiaoyun.li@intel.com, dev@dpdk.org, linuxarm@openeuler.org, Andrew Rybchenko , Aaron Conole , Honnappa Nagarahalli References: <1614929583-37727-1-git-send-email-oulijun@huawei.com> <35583d9b-0782-74a7-95df-aef1ca35f819@intel.com> <1980606.NPtmdolmL5@thomas> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <36b1a9dc-9e5a-85ea-0a1d-51304e0f90a4@oktetlabs.ru> Date: Tue, 9 Mar 2021 13:18:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1980606.NPtmdolmL5@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/9/21 12:57 PM, Thomas Monjalon wrote: > 09/03/2021 10:53, Ferruh Yigit: >> On 3/9/2021 8:49 AM, oulijun wrote: >>> 2021/3/9 1:33, Ferruh Yigit: >>>> Similar to above comment 'rte_eth_devices' is the internal variable, >>>> applications should not access it directly. >>>> >>> No API is available, and multiple references exist in the testpmd file. >> >> Technically 'rte_eth_devices' is still visible to the applications because of >> the static inline functions, in theory it should be hidden. >> >> But this variable accessed by our test application multiple times may be the >> sign that something more is missing. >> >> Thomas, Andrew, what to you think to try to clean this usage from testpmd and >> add more APIs if needed for this? > > I fully agree. > The test applications and examples should help identifying gaps > in the libraries. So we should not workaround the official API. > +1