From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5499A054F; Tue, 16 Mar 2021 12:32:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD3864069F; Tue, 16 Mar 2021 12:32:26 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 3FBB14003D for ; Tue, 16 Mar 2021 12:32:24 +0100 (CET) IronPort-SDR: +JJsHvalNZtoqdcuSj1l4Rsp4ABUTJSOMB3/S0PWXV3mx2GnxUMfPqvS3+H31o9ycjC8gm2GpF Ci1d4kTz6vSw== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="274285048" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="274285048" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 04:32:24 -0700 IronPort-SDR: LM2/vMrow3pOIHBDSJ0pXnTIjCNAMfGdt7vwMQlTdgbrOOSebWOic8wjlpEWfmBUhzqJNW/2hG JzJbowkRNa7A== X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="405517071" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.11.157]) ([10.252.11.157]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 04:32:23 -0700 To: Andrew Rybchenko Cc: dev@dpdk.org References: <20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru> <20210316085832.942481-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <36b86891-1ec2-3cfc-0a3b-a0b9fe850a2d@intel.com> Date: Tue, 16 Mar 2021 11:32:20 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 0/8] common/sfc_efx: prepare to introduce vDPA driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/16/2021 11:30 AM, Andrew Rybchenko wrote: > On 3/16/21 2:26 PM, Ferruh Yigit wrote: >> On 3/16/2021 8:58 AM, Andrew Rybchenko wrote: >>> Update base driver to provide functionality required by vDPA driver. >>> >>> Factor out helper functions to be shared by net and vDPA drivers. >>> >>> v4: >>>   - fix Copyright year >>> >>> v3: >>>   - one more attempt to fix windows build breakage >>> >>> v2: >>>   - fix windows build breakage - do not build common/sfc_efx in the case >>>     of windows >>>   - remove undefined efx_virtio_* functions from version.map (since >>>     EFSYS_OPT_VIRTIO is disabled) >>> >>> Vijay Kumar Srivastava (6): >>>    common/sfc_efx/base: add virtio build dependency >>>    common/sfc_efx/base: add support to get virtio features >>>    common/sfc_efx/base: add support to verify virtio features >>>    common/sfc_efx: add support to get the device class >>>    net/sfc: skip driver probe for incompatible device class >>>    drivers: add common driver API to get efx family >>> >>> Vijay Srivastava (2): >>>    common/sfc_efx/base: add base virtio support for vDPA >>>    common/sfc_efx/base: add API to get VirtQ doorbell offset >>> >> >> The driver adds vDPA support, I believe it worth mentioning in the >> driver documentation and in the release notes, can you please send a >> new version with documentation updates? > > No, no. It is just preparations to introduce the vDPA driver. > vDPA drier will be added in a subsequent patches and I'll > ensure that it is mentioned in release notes etc. > Got it, that answers a few of unused functions too.. Please be sure to document.