From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] net/mlx5: fix Ethernet header re-writing
Date: Thu, 2 Feb 2017 15:34:04 +0000 [thread overview]
Message-ID: <36c259d4-ed03-75b2-43ea-3de28facf1dc@intel.com> (raw)
In-Reply-To: <fb871683b18cb5a8db2145ea71f0d9a41d6f8683.1486031307.git.nelio.laranjeiro@6wind.com>
On 2/2/2017 10:34 AM, Nelio Laranjeiro wrote:
> First two bytes of the Ethernet header was written twice at the same place.
Is this patch just prevents re-writing 2 bytes of buffer, or changes the
buffer content as well?
If buffer content also updated, I think it would be nice to mention in
the commit log.
And if buffer content is not changed, will it be fair to say this patch
is refactor patch instead of fix?
>
> Fixes: b8fe952ec5b6 ("net/mlx5: prepare Tx vectorization")
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
<...>
next prev parent reply other threads:[~2017-02-02 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 10:34 Nelio Laranjeiro
2017-02-02 10:34 ` [dpdk-dev] [PATCH 2/3] net/mlx5: fix Tx WQE corruption caused by starvation Nelio Laranjeiro
2017-02-02 10:34 ` [dpdk-dev] [PATCH 3/3] net/mlx5: fix inline WQE consumption Nelio Laranjeiro
2017-02-02 15:34 ` Ferruh Yigit [this message]
2017-02-02 16:38 ` [dpdk-dev] [PATCH 1/3] net/mlx5: fix Ethernet header re-writing Nélio Laranjeiro
2017-02-02 21:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36c259d4-ed03-75b2-43ea-3de28facf1dc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).