From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1F9992BE5 for ; Thu, 2 Feb 2017 16:34:06 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 02 Feb 2017 07:34:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,325,1477983600"; d="scan'208";a="220574595" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga004.fm.intel.com with ESMTP; 02 Feb 2017 07:34:04 -0800 To: Nelio Laranjeiro , dev@dpdk.org References: Cc: Adrien Mazarguil , Yongseok Koh From: Ferruh Yigit Message-ID: <36c259d4-ed03-75b2-43ea-3de28facf1dc@intel.com> Date: Thu, 2 Feb 2017 15:34:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] net/mlx5: fix Ethernet header re-writing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2017 15:34:07 -0000 On 2/2/2017 10:34 AM, Nelio Laranjeiro wrote: > First two bytes of the Ethernet header was written twice at the same place. Is this patch just prevents re-writing 2 bytes of buffer, or changes the buffer content as well? If buffer content also updated, I think it would be nice to mention in the commit log. And if buffer content is not changed, will it be fair to say this patch is refactor patch instead of fix? > > Fixes: b8fe952ec5b6 ("net/mlx5: prepare Tx vectorization") > > Signed-off-by: Yongseok Koh > Signed-off-by: Nelio Laranjeiro > --- <...>