From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test/memzone: fix incorrect result judging criteria
Date: Mon, 29 Jan 2018 09:49:51 +0000 [thread overview]
Message-ID: <36ffe0b4-8a4d-2690-9c33-5eff41b21891@intel.com> (raw)
In-Reply-To: <1517206986-32281-2-git-send-email-phil.yang@arm.com>
On 29-Jan-18 6:23 AM, Phil Yang wrote:
> While running DTS with ixgbe NIC, dpdk EAL will reserve some
> memzones for the PCI device. So it is incorrect to judging the result by
> only checking whether it has memzone remained.
>
> Fixed by insert an unique name prefix into each memzone used in this case.
> And verify whether it has used memzone remained at the end.
>
> Fixes: 71330483a193 ("test/memzone: fix memory leak")
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> ---
Hi Phil,
I think this is a (rough) duplicate of what i've submitted recently:
http://dpdk.org/dev/patchwork/patch/34564/
I believe approach i've taken is a little cleaner and more generic :)
--
Thanks,
Anatoly
prev parent reply other threads:[~2018-01-29 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 6:23 [dpdk-dev] [PATCH] fix memzone unit test defect in verify process Phil Yang
2018-01-29 6:23 ` [dpdk-dev] [PATCH] test/memzone: fix incorrect result judging criteria Phil Yang
2018-01-29 9:49 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ffe0b4-8a4d-2690-9c33-5eff41b21891@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).