From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A4D2A1B415 for ; Mon, 29 Jan 2018 10:49:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 01:49:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,429,1511856000"; d="scan'208";a="26270285" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.145]) ([10.237.220.145]) by fmsmga001.fm.intel.com with ESMTP; 29 Jan 2018 01:49:52 -0800 To: dev@dpdk.org References: <1517206986-32281-1-git-send-email-phil.yang@arm.com> <1517206986-32281-2-git-send-email-phil.yang@arm.com> From: "Burakov, Anatoly" Message-ID: <36ffe0b4-8a4d-2690-9c33-5eff41b21891@intel.com> Date: Mon, 29 Jan 2018 09:49:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1517206986-32281-2-git-send-email-phil.yang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] test/memzone: fix incorrect result judging criteria X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 09:49:54 -0000 On 29-Jan-18 6:23 AM, Phil Yang wrote: > While running DTS with ixgbe NIC, dpdk EAL will reserve some > memzones for the PCI device. So it is incorrect to judging the result by > only checking whether it has memzone remained. > > Fixed by insert an unique name prefix into each memzone used in this case. > And verify whether it has used memzone remained at the end. > > Fixes: 71330483a193 ("test/memzone: fix memory leak") > > Signed-off-by: Phil Yang > --- Hi Phil, I think this is a (rough) duplicate of what i've submitted recently: http://dpdk.org/dev/patchwork/patch/34564/ I believe approach i've taken is a little cleaner and more generic :) -- Thanks, Anatoly