DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] tools: exit setup script without prompt
@ 2015-10-22 10:36 John McNamara
  2015-10-23 16:07 ` Van Haaren, Harry
  0 siblings, 1 reply; 3+ messages in thread
From: John McNamara @ 2015-10-22 10:36 UTC (permalink / raw)
  To: dev

Exit tools/setup.sh script without prompting "Press enter to continue".

The script can now be exited by typing the option number, "quit" or "q".

Signed-off-by: John McNamara <john.mcnamara@intel.com>
---
 tools/setup.sh | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/tools/setup.sh b/tools/setup.sh
index 5a8b2f3..fbd3853 100755
--- a/tools/setup.sh
+++ b/tools/setup.sh
@@ -57,6 +57,12 @@ quit()
 	QUIT=$1
 }
 
+# Shortcut for quit.
+q()
+{
+	quit
+}
+
 #
 # Sets up environmental variables for ICC.
 #
@@ -628,6 +634,10 @@ while [ "$QUIT" == "0" ]; do
 	read our_entry
 	echo ""
 	${OPTIONS[our_entry]} ${our_entry}
-	echo
-	echo -n "Press enter to continue ..."; read
+
+	if [ "$QUIT" == "0" ] ; then
+		echo
+		echo -n "Press enter to continue ..."; read
+	fi
+
 done
-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] tools: exit setup script without prompt
  2015-10-22 10:36 [dpdk-dev] [PATCH] tools: exit setup script without prompt John McNamara
@ 2015-10-23 16:07 ` Van Haaren, Harry
  2015-12-03 19:31   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Van Haaren, Harry @ 2015-10-23 16:07 UTC (permalink / raw)
  To: Mcnamara, John, dev

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John McNamara
> Sent: Thursday, October 22, 2015 11:36 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] tools: exit setup script without prompt
> 
> Exit tools/setup.sh script without prompting "Press enter to continue".
> 
> The script can now be exited by typing the option number, "quit" or "q".
> 
> Signed-off-by: John McNamara <john.mcnamara@intel.com>

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] tools: exit setup script without prompt
  2015-10-23 16:07 ` Van Haaren, Harry
@ 2015-12-03 19:31   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-12-03 19:31 UTC (permalink / raw)
  To: Mcnamara, John; +Cc: dev

> > Exit tools/setup.sh script without prompting "Press enter to continue".
> > 
> > The script can now be exited by typing the option number, "quit" or "q".
> > 
> > Signed-off-by: John McNamara <john.mcnamara@intel.com>
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-03 19:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-22 10:36 [dpdk-dev] [PATCH] tools: exit setup script without prompt John McNamara
2015-10-23 16:07 ` Van Haaren, Harry
2015-12-03 19:31   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).