[dpdk-dev] [PATCH 1/3] raw/skeleton_rawdev: fix resource leak

[dpdk-dev] [PATCH 1/3] raw/skeleton_rawdev: fix resource leak

[Shreyansh Jain]

Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases")
Coverity issue: 260402

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
index 795f24bcb..7ad8f19ce 100644
--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
@@ -288,6 +288,7 @@ test_rawdev_attr_set_get(void)
 			      "Attribute (Test2) not set correctly (%" PRIu64 ")",
 			      ret_value);
 
+	free(dummy_value);
 	return TEST_SUCCESS;
 }
 
-- 
2.17.0

[dpdk-dev] [PATCH 2/3] raw/skeleton_rawdev: remove dead code

[Shreyansh Jain]

Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases")
Coverity Issue: 260411

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
index 7ad8f19ce..3eb5c3a7b 100644
--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
@@ -380,8 +380,6 @@ test_rawdev_enqdeq(void)
 cleanup:
 	if (buffers[0].buf_addr)
 		free(buffers[0].buf_addr);
-	if (deq_buffers)
-		free(deq_buffers);
 
 	return TEST_FAILED;
 }
-- 
2.17.0

[dpdk-dev] [PATCH 3/3] rawdev: remove dead code

[Shreyansh Jain]

Fixes: c88b3f2558ed ("rawdev: introduce raw device library")
Coverity issue: 260406

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 lib/librte_rawdev/rte_rawdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c
index d314ef96b..284e6aec8 100644
--- a/lib/librte_rawdev/rte_rawdev.c
+++ b/lib/librte_rawdev/rte_rawdev.c
@@ -88,9 +88,6 @@ rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info)
 	RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
 	RTE_FUNC_PTR_OR_ERR_RET(dev_info, -EINVAL);
 
-	if (dev_info == NULL)
-		return -EINVAL;
-
 	rawdev = &rte_rawdevs[dev_id];
 
 	RTE_FUNC_PTR_OR_ERR_RET(*rawdev->dev_ops->dev_info_get, -ENOTSUP);
-- 
2.17.0

Re: [dpdk-dev] [PATCH 1/3] raw/skeleton_rawdev: fix resource leak

[Thomas Monjalon]

09/05/2018 17:26, Shreyansh Jain:
> Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases")
> Coverity issue: 260402
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Series applied, thanks