From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance
Date: Tue, 20 Nov 2018 14:48:43 +0000 [thread overview]
Message-ID: <370D42AF-375C-416D-98E6-2EAF4B77260E@intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258010CEBA106@IRSMSX106.ger.corp.intel.com>
> On Nov 20, 2018, at 3:16 AM, Ananyev, Konstantin <konstantin.ananyev@intel.com> wrote:
>
> Hi Qi,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
>> Sent: Tuesday, November 20, 2018 4:46 AM
>> To: Richardson, Bruce <bruce.richardson@intel.com>; Wiles, Keith <keith.wiles@intel.com>
>> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance
>>
>> The patch optimizes the mac swap operation by taking advantage
>> of SSE instructions, it only impacts x86 platform.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>> ---
>> app/test-pmd/macswap.c | 16 +++++++++++++++-
>> 1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/macswap.c b/app/test-pmd/macswap.c
>> index a8384d5b8..0722782b0 100644
>> --- a/app/test-pmd/macswap.c
>> +++ b/app/test-pmd/macswap.c
>> @@ -78,7 +78,6 @@ pkt_burst_mac_swap(struct fwd_stream *fs)
>> struct rte_port *txp;
>> struct rte_mbuf *mb;
>> struct ether_hdr *eth_hdr;
>> - struct ether_addr addr;
>> uint16_t nb_rx;
>> uint16_t nb_tx;
>> uint16_t i;
>> @@ -95,6 +94,15 @@ pkt_burst_mac_swap(struct fwd_stream *fs)
>> start_tsc = rte_rdtsc();
>> #endif
>>
>> +#ifdef RTE_ARCH_X86
>> + __m128i addr;
>> + __m128i shfl_msk = _mm_set_epi8(15, 14, 13, 12,
>> + 5, 4, 3, 2,
>> + 1, 0, 11, 10,
>> + 9, 8, 7, 6);
>> +#else
>> + struct ether_addr addr;
>> +#endif
>
> I think it would better to place IA specific code into a separate fnction
> (and probably into a separate .h file).
> BTW, just curious what % of improvement it gives?
> Konstantin
>
If we are going to the trouble of moving the code out of the .c into a .h then I suggest it be placed into the rte_ethdev headers for everyone to use.
>
>> /*
>> * Receive a burst of packets and forward them.
>> */
>> @@ -123,9 +131,15 @@ pkt_burst_mac_swap(struct fwd_stream *fs)
>> eth_hdr = rte_pktmbuf_mtod(mb, struct ether_hdr *);
>>
>> /* Swap dest and src mac addresses. */
>> +#ifdef RTE_ARCH_X86
>> + addr = _mm_loadu_si128((__m128i *)eth_hdr);
>> + addr = _mm_shuffle_epi8(addr, shfl_msk);
>> + _mm_storeu_si128((__m128i *)eth_hdr, addr);
>> +#else
>> ether_addr_copy(ð_hdr->d_addr, &addr);
>> ether_addr_copy(ð_hdr->s_addr, ð_hdr->d_addr);
>> ether_addr_copy(&addr, ð_hdr->s_addr);
>> +#endif
>>
>> mb->ol_flags &= IND_ATTACHED_MBUF | EXT_ATTACHED_MBUF;
>> mb->ol_flags |= ol_flags;
>> --
>> 2.13.6
Regards,
Keith
next prev parent reply other threads:[~2018-11-20 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 4:45 Qi Zhang
2018-11-20 9:16 ` Ananyev, Konstantin
2018-11-20 14:48 ` Wiles, Keith [this message]
2018-11-20 16:58 ` Zhang, Qi Z
2018-11-20 17:26 ` Ananyev, Konstantin
2018-11-20 22:53 ` Ananyev, Konstantin
2018-11-21 21:24 ` Zhang, Qi Z
2018-11-23 22:43 ` Wiles, Keith
2018-11-23 22:43 ` Wiles, Keith
2018-11-24 16:24 ` Wiles, Keith
2018-11-27 1:06 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=370D42AF-375C-416D-98E6-2EAF4B77260E@intel.com \
--to=keith.wiles@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).