From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1CEB43CA0; Wed, 13 Mar 2024 17:06:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90D0742E66; Wed, 13 Mar 2024 17:06:17 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 6306A42E33; Wed, 13 Mar 2024 17:06:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710345977; x=1741881977; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=/5PN8BUeh/c7UcxliRx8oMkXFB8A4Uv9LxR+m4sfNWs=; b=MX9Vi0ST2III5aoLy/tVS0KdRNZcE5kEE5WTIwBS/u/I0xuJfJPLekto Fiaw8Fh/KKzZhd1uCca+XwiVN8kc4oMyErKC8AMuzLwvN2698jTV3QIiu pTp7wOqKviYlaL2pI0o7/8kGM5EM3mPHiOjhbosmYskRzIafdUgRiY9t4 uLEx+9IKKGbwcLfw3D8onNn90oOKQjG5imEVvce8QxLXy1aam2z2wya/0 glqoeFyuv/NaGvvm0lHiv6uBaBlVaJfVDxxU7tn02ppXO+WRU1b1abs+4 dtBuNWG0Q9pjcfYjCP1rGf/4NyzBqLfDSSwifY95iKwyOCQ+XSGnJ1va5 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11011"; a="22574524" X-IronPort-AV: E=Sophos;i="6.07,122,1708416000"; d="scan'208";a="22574524" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 09:06:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,122,1708416000"; d="scan'208";a="11866910" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Mar 2024 09:06:15 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Mar 2024 09:06:14 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Mar 2024 09:06:14 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Mar 2024 09:06:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mUzhrInFxieLi47isFdM5XiiZanvQkVthz/4iVMaSD3HaBwAMepi3VTnhNRYVA9U4a08AvbFr/b4lssLXbpL175qNBILvL00TOsLsrd+Dc6LDZpahYeLrZEhe5e8UMGDMuV3XyFrA/8FTikOKpPkxd/aQtDrDdEA7j333yJGJ7hdqodSkHHMEqdbhnKHXn9Q9YGUqmaHC9+TVu7vUBAdDCFCDqb/ZvSTIKDKHNfJqaCfK1ivYmbZWYIHSirYsMnl4MUzqO7TT5WyWekcN3k0q59g6icC8K07nkr+6XHPKJJ5SxlLtSHGjQiW8IMZk8aBTt6aUWB1Wd0AOT5DGoKhmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NfoY5mHm0LJGTK5OELXx/uio1LIIQBDCZ7OynA4G5KQ=; b=bqhdm6mGH4AbRyct8tzBKJnLgV6DI4g+lpDkVCE49BsVE0IKJQOMVD3isUz/ruBj4WJFanILwZH0mntz+mlDjym1UiZswj30UujP28fP3J81NKB8kKV0zssH7Fuqe11aQEmFxqQCHEUXeV/r9ctdzGBNHmwp41AAeuN0Dz3DVEDvrVYoZLbDoxVyQKCle7pZUJVqnEzaf/FsbnvJemIb8z/Zn62TDRrVo+0zN7vxoabCCexlbyn4DMOnhS8+DoUKsIjk0kUWhtoTs4bE1PxYBKCQAUJK5/AxT3oLzFfOTpEvbT3ItF/8YbLQvcOe4oQpLbnwleMxPnBxS4bd+QQ1/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by SN7PR11MB6899.namprd11.prod.outlook.com (2603:10b6:806:2a7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.17; Wed, 13 Mar 2024 16:06:06 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::ab9d:3c81:51ea:7bb4]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::ab9d:3c81:51ea:7bb4%3]) with mapi id 15.20.7386.015; Wed, 13 Mar 2024 16:06:06 +0000 Message-ID: <370b1a7f-d49f-4a1b-b111-96ae9f775d24@intel.com> Date: Wed, 13 Mar 2024 17:06:04 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] ipc: fix mp channel closure to prevent message loss Content-Language: en-US To: Artemy Kovalyov , CC: Thomas Monjalon , , David Marchand , Maxime Coquelin References: <20231212042517.164353-2-artemyko@nvidia.com> <20240307070113.29580-1-artemyko@nvidia.com> <20240307070113.29580-4-artemyko@nvidia.com> From: "Burakov, Anatoly" In-Reply-To: <20240307070113.29580-4-artemyko@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0267.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::10) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|SN7PR11MB6899:EE_ X-MS-Office365-Filtering-Correlation-Id: 75be15f2-05de-4a01-b5d3-08dc43777d44 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eHRhiJvkOuxASN0dELJ8apLbjQclEvHJ3wWTNYmaS8mWk19LdDlLXq/VJBZrq8L/Qclpr8vHHkOQG+vO5q2aBghPlo6I0BdWEk6fQWC35+xpl+/GaKydhFVLkMJMBS5gBlDEr++1Durh09LHFWjuD8/S//SBpPE11aKKzqkgTna+/IRVHrFzuxodzBNTQrK9WLld/dZ6slXXsFYkNtBKcj7/lMmFX58xy7MhuS+7eOncC9Q8WiRaLVa6fXdeu4/AOaf0MM4jVmyE9VMBisweYOoq/CxBpmC7FrVyA3uojWB+GSP2Tvv2vlMqnEd0FlLifA8xZQC7nYUbocT+4vzDj7xgbGz1nf7uI8aV1WTAOZsk7jHlcHqpgWo5rOH0WJ/ojym9YSE9ClVWXsam1LolDhcC4GUlGanqW67cvOm8FtD59ND6nH2Tl1Le8npaV3R5nIDnBaBcPJ57lAOj8AxLS0P/xST1kTHGKRIAJoxx+PnE1BC4gRX2v58WCEZw+MU3H18cCi0ooXW0veyvpzsDcKnjZYVDdxmSJhblrRkkBMMhhS+sUSdSVxrphQoaQpn+BNDEDpRwlGljL7nCjbIFXDNv7yEcFVDMHvDpmaPekFAtF/3q2tFKMHrUIgAra4iErwyCqiDQzSOWxFmPF5GsDr6sR3G5b0Wk+WSuDx7M0Kc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a282dENIVDdoZHlsckFrYUFmYk1vWm5jeXNvVFJROHBsb3R6VDRKdzl0WDVZ?= =?utf-8?B?dXZBRVJCOXNNYkM0cDkyTitPQlFNRy8yVjBnNTEvT05QdXYxQjFHdXBTYnFa?= =?utf-8?B?SHhpRFM0TTNWK2JOMVF1TlBERlRZT21GeUhOVW1tRTY4OUhTd0VOSzNFQVh5?= =?utf-8?B?dHg0RVdObitNMnp6bVphbURZNEZBa1psSG84bUNPKzA3WDBUR2ordkpaY2Rq?= =?utf-8?B?dFpqYmdYQTFDbkt1Y2hYMUtzd0tGUE9obXZIRWhpTDN4UngwVjRRYXJkTUJP?= =?utf-8?B?MzVoVUtIbktBTVRkOTVZUWNOUHM3YjUvM0ZGSGxUc1NVRnE3YmJObUgyNU8v?= =?utf-8?B?VE9wbU1SUzZKcEgzQ0RQVFY4RmRkUFNzVFlMTXpFRmZnay8rVFZDL0V1Ynk1?= =?utf-8?B?d2RmN0k0cmhmVm5UbWZFNWFWQk4yR1JnRHd5WXh1SGI1M1EzY1NYd3JmcCto?= =?utf-8?B?MWloaGZhR1FqaGNiV00yR1JwOGpEU1hQd2M1SXE2UjR3b0Q1cXhKRkNUVEZn?= =?utf-8?B?eEJmbWlmckk2Kzl0aFBlaC85OVV4S1c5UXFsMEJpQnk2VzdFaUpMajhPL0Jh?= =?utf-8?B?N3VxMzhCMU94cmYvbEZRK1MvVXByc0lpMFRGaFBpTlhVS3RsblNUcnpWTzdy?= =?utf-8?B?MWpzclBHcVNZRUllK01xa29IV3FBKzdkUXpJaloyZTZRVHBqS2xUREZRV3Rp?= =?utf-8?B?OWZVWUh1c0ZnRVpjYWNvTTF4ZmtXdHJzdzR6RUd6Qzg1OXNyVFpVcEhJWXEz?= =?utf-8?B?TkVwc3o2Wnc1Zk55NmZGS1ZmRUVobWg3TTQzWERqTUViRUdVdWpQV2pwSjMv?= =?utf-8?B?Tmg3R2VCOFpLWFZES0FMU01zZUdEWjg0Yng4TnlIYmJsajI2clRTMjNFQlRh?= =?utf-8?B?V0pXR1NqRTdSa2xkMzlVMjBQWHFTdWx2MG8vcG00RTd5aE5xZkNzcHdaUmNp?= =?utf-8?B?ZU1EdU5GUG1vOEI3YlRtZHVGZS9JQTArMWp1UzBqZEVxWERLbjhwMXF0OTh1?= =?utf-8?B?dHQxdHY3a1B5Nks3YU1hTnN3YllaV21BT2gzcEJXbERoU1Bma1RyRjB5cHNO?= =?utf-8?B?UktONFNGZnUxSDl6bUlFSHkzRFhiTjVqVzNSYVV2M0ZyL0h3RlNTNnJVWEtU?= =?utf-8?B?b0xJTnNQZm15cUxTZ3JGbUVEZjhuYm5GZDNqQU5oY0RSZktZTGN6Zm9Bb1gz?= =?utf-8?B?bld3NE95bE11SStpbndHVE9xZUpDUHAzeTI5OGxlY1B1aURjbG9XU0NVeXhP?= =?utf-8?B?MWc5dmM2N2tnMjdCK203ZEFOQjB5YW5aRVZna2pYcmthRUVSNUNad0JuS2cx?= =?utf-8?B?SExhOVpURDZyeVg2K3JXQmc2QVhRMytsT3FqMmhqdEdBck44QXp0T3VkTlhQ?= =?utf-8?B?c1lIMm0xdWNxRTJ6RzJsQTNxS0J1R0FwZk9MbDRPMTg2OU14aTJTWmdQTURq?= =?utf-8?B?L2YxTXhTeGFuTlF0Q1IrVEFNL3AyRHIrOUdyOUxZR0FkT0EyZWNqeXJ6QmRO?= =?utf-8?B?QVp4VThicUFhNCtJM0gwTXNlOTBDY3pJRGZ5ckUvSGhIQUprS3RCcDBmUDR3?= =?utf-8?B?MDcxZUFtTDQ5ZGJMb09ia1BtRE5HbUFEZlBhd0dKYmE1SytVRUJPbE5Fc2Ft?= =?utf-8?B?MWZMZis3WWIycXpPdThCM3BqaUJpRzViYnMwZUJJTHhEenE3N3Jod2U3RnhM?= =?utf-8?B?MjZOQmROYlliWlcwNXZ6QzZJMG1qaE5ZVSs4S1BOMzZHT3Jpa21FMWo4RktS?= =?utf-8?B?eTNacGhITjRRRDduYUQ3MzBIaGRNQ1IzVG4rTm56N0F4cHpVVldiTWREcVBL?= =?utf-8?B?WXJmZEloUGFDZ0lRb0NoSnN4NkgzRUJMQ3hLWFJwa0ZydkNscWswMVlZM3Jk?= =?utf-8?B?RmQ4MzZuZUlGZG91ci9iQVQxREFwUVplSEZGWE9DMFVyVzNPRFRQOWlWU1JS?= =?utf-8?B?UFlZTUtWNm9iYnYwMFV0TllMUldzMDBSUVNlL05YNW95VEtSc25oTTJnK25z?= =?utf-8?B?ZmpPSUo2WGhZelBCS2NNWTk1U1NsUncwUTJGTDlQa25SeHNYRlpCcXdlaXJ2?= =?utf-8?B?Y1dGRjFlYWJwVU40cnV1ZFB0WXVtMUpmd3d3RGF4Tzlad3FZcHMzaW5kQ2JG?= =?utf-8?B?Y0VFRnA4LzBNbVN0dTk1aVpPb09HN2dzaXlOZ3FmMzU3Q2FYMVZmRU8rYUs1?= =?utf-8?B?Y1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 75be15f2-05de-4a01-b5d3-08dc43777d44 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 16:06:06.2938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ajk/GwuydVgVaj6S1S0mUS2c5cw0kra6X7ipFT67SO/Ewc7/YFjqZ0G1NDhPGG+foop2RgFKe0o/L3CBJn2mqw62j3fsV0yeu66pCZmV6O4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6899 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/7/2024 8:01 AM, Artemy Kovalyov wrote: > This commit addresses an issue related to the cleanup of the > multiprocess channel. Previously, when closing the channel, there was a > risk of losing trailing messages. This issue was particularly noticeable > when broadcast message from primary to secondary processes was sent > while a secondary process was closing it's mp channel. In this fix, we > delete mp socket file before stopping mp receive thread. > > Fixes: e7885281ded1 ("ipc: stop mp control thread on cleanup") > Cc: stable@dpdk.org > > Signed-off-by: Artemy Kovalyov > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly