From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CF59A00C2; Thu, 5 Jan 2023 10:01:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0433F400D4; Thu, 5 Jan 2023 10:01:35 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id B242B40041 for ; Thu, 5 Jan 2023 10:01:33 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 407385C0143; Thu, 5 Jan 2023 04:01:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 05 Jan 2023 04:01:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672909293; x= 1672995693; bh=jq34MulgJJSlEjDMANvEbtzfGHe+1ZwH/nkQ/3vl1GU=; b=G yZHP9q64VL7Jenj3db2SnPD68njDx/pdImk+UjbECCxmX5f06C+JcRo23XXB+jsg 2C3BkzBSv9wqzXYblb+uyW76IoHOPfecUoh9j390DTNU4LkrcVDkiVX2d7s/NFCT JNsEDLhKkHOa1QNEJKoExVNeLvGJL6D/CxNWqHijV9r0OFpxqyKNsJN7E6HydGBJ tyYT9Vmwe+BHmxxzlAGiYVIDrw9gUz7f21xl90M4JORKtZgDtt001CZ6lxCrQRps eN0HnOAitQNOeSkFdtThu7Y0/GVTHSK/QAk86giKy2RDAtiIHTrJiKK8N3dltdgv XmLHev7ig3MNDF/0eCGtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672909293; x= 1672995693; bh=jq34MulgJJSlEjDMANvEbtzfGHe+1ZwH/nkQ/3vl1GU=; b=w 4br0M3rln99cXwWLXoMRU1EXP6ECH00VqXAUC0IIbsIpgJAnSonUFNKNlzU210+S GIUlcZ3HBBswIQDHdohhucRLnHXmT17kFqn0awW+fDtD6EkLL3j47+olvZZXsQ21 CchXcLnKtlaleXPdWQGvWKRXc/K8t04s9ra29eNBDeIlqnTrcSLKywmZ3Pt1QmSn p8b6D6RGLsfzj32l6tLlSFLZ5WnUOcUJBbMWn2lk670dMlvvvEXEqJFyxBkBERpR CZuASKep5ZakE7G4wOX/vW7mug2vyZ+ltHr7sFNOo9C2+wwQeb+Kasl+zJnQWC/w vuvrcl2nCjJ4+Emt+Cyhw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeejgdduvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Jan 2023 04:01:32 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff , Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v2 1/2] eal: provide leading and trailing zero bit count abstraction Date: Thu, 05 Jan 2023 10:01:31 +0100 Message-ID: <3710898.kQq0lBPeGt@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87624@smartserver.smartshare.dk> References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <1669246997-30592-2-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D87624@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/01/2023 08:09, Morten Br=F8rup: > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change, or be removed, without prior > > notice > > + * > > + * Get the count of leading 0-bits in v. > > + * > > + * @param v > > + * The value. > > + * @return > > + * The count of leading zero bits. > > + */ > > +__rte_experimental > > +static inline unsigned int > > +rte_clzl(unsigned long v) >=20 > Don't use l (long) and ll (long long) for names (and types), use explicit= bit lengths, 32 and 64. >=20 > E.g.: rte_clz32(uint32_t v) I agree on using numbers.