Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Subendu Santra]

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

Hi Stephen,

We were going through the patch set: https://inbox.dpdk.org/dev/20200715212228.28010-7-stephen@networkplumber.org/ and hoping to get clarification on the behaviour if post mask is not specified in the input to `dpdk-proc-info` tool.

Specifically, In PATCH v3 6/7, we see this:
+	/* If no port mask was specified, one will be provided */
+	if (enabled_port_mask == 0) {
+		RTE_ETH_FOREACH_DEV(i) {
+			enabled_port_mask |= 1u << i;

However, in PATCH v4 8/8, we see this:
+	/* If no port mask was specified, then show non-owned ports */
+	if (enabled_port_mask == 0) {
+		RTE_ETH_FOREACH_DEV(i)
+			enabled_port_mask = 1ul << i;
+	}

Was there any specific reason to show just the last non-owned port in case the port mask was not specified?
Should we show all non-owned ports in case the user doesn’t specify any port mask?

Regards,
Subendu.




[-- Attachment #2: Type: text/html, Size: 2119 bytes --]

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Subendu Santra]

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

Hi Stephen,

Could you please help us understand the rationale behind showing just the
last non-owned port in case the port mask was not specified?
I really appreciate your help in this regard.

Regards,
Subendu.



On Sun, Apr 24, 2022 at 11:04 AM Subendu Santra <subendu@arista.com> wrote:

> Hi Stephen,
>
> We were going through the patch set:
> https://inbox.dpdk.org/dev/20200715212228.28010-7-stephen@networkplumber.org/
> and hoping to get clarification on the behaviour if post mask is not
> specified in the input to `dpdk-proc-info` tool.
>
> Specifically, In PATCH v3 6/7, we see this:
>
> +	/* If no port mask was specified, one will be provided */
> +	if (enabled_port_mask == 0) {
> +		RTE_ETH_FOREACH_DEV(i) {
> +			enabled_port_mask |= 1u << i;
>
>
> However, in PATCH v4 8/8, we see this:
>
> +	/* If no port mask was specified, then show non-owned ports */
> +	if (enabled_port_mask == 0) {
> +		RTE_ETH_FOREACH_DEV(i)
> +			enabled_port_mask = 1ul << i;
> +	}
>
>
> Was there any specific reason to show just the last non-owned port in case
> the port mask was not specified?
> Should we show all non-owned ports in case the user doesn’t specify any
> port mask?
>
> Regards,
> Subendu.
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 2373 bytes --]

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Thomas Monjalon]

24/04/2022 07:34, Subendu Santra:
> Hi Stephen,
> 
> We were going through the patch set: https://inbox.dpdk.org/dev/20200715212228.28010-7-stephen@networkplumber.org/ and hoping to get clarification on the behaviour if post mask is not specified in the input to `dpdk-proc-info` tool.
> 
> Specifically, In PATCH v3 6/7, we see this:
> +	/* If no port mask was specified, one will be provided */
> +	if (enabled_port_mask == 0) {
> +		RTE_ETH_FOREACH_DEV(i) {
> +			enabled_port_mask |= 1u << i;
> 
> However, in PATCH v4 8/8, we see this:
> +	/* If no port mask was specified, then show non-owned ports */
> +	if (enabled_port_mask == 0) {
> +		RTE_ETH_FOREACH_DEV(i)
> +			enabled_port_mask = 1ul << i;
> +	}
> 
> Was there any specific reason to show just the last non-owned port in case the port mask was not specified?
> Should we show all non-owned ports in case the user doesn’t specify any port mask?

It looks like a bug. It should be |=
Feel free to send a fix.

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Stephen Hemminger]

On Tue, 03 May 2022 10:47:58 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 24/04/2022 07:34, Subendu Santra:
> > Hi Stephen,
> > 
> > We were going through the patch set: https://inbox.dpdk.org/dev/20200715212228.28010-7-stephen@networkplumber.org/ and hoping to get clarification on the behaviour if post mask is not specified in the input to `dpdk-proc-info` tool.
> > 
> > Specifically, In PATCH v3 6/7, we see this:
> > +	/* If no port mask was specified, one will be provided */
> > +	if (enabled_port_mask == 0) {
> > +		RTE_ETH_FOREACH_DEV(i) {
> > +			enabled_port_mask |= 1u << i;
> > 
> > However, in PATCH v4 8/8, we see this:
> > +	/* If no port mask was specified, then show non-owned ports */
> > +	if (enabled_port_mask == 0) {
> > +		RTE_ETH_FOREACH_DEV(i)
> > +			enabled_port_mask = 1ul << i;
> > +	}
> > 
> > Was there any specific reason to show just the last non-owned port in case the port mask was not specified?
> > Should we show all non-owned ports in case the user doesn’t specify any port mask?  
> 
> It looks like a bug. It should be |=
> Feel free to send a fix.
> 
> 

Agree. Thats a bug.

It would be good to have a "show all ports" flag to proc-info.
To show all ports including owned.

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Subendu Santra]

[-- Attachment #1: Type: text/plain, Size: 2469 bytes --]

Hi Stephen, Thomas,

On a related note w.r.to commit 1dd6cffb6571f816d5a0d1fd620f43532240b40b
(app/procinfo: provide way to request info on owned ports), we see this
change:

-static uint32_t enabled_port_mask;
> +static unsigned long enabled_port_mask;


While this is ok for 64-bit machines, where unsigned long is 64-bit, on
32-bit machines unsigned long is 32-bits.
Should we change this to unsigned long long which is guaranteed to be
64-bits on both architectures?

Specifying a mask of 0xffffffffffffffff on 32-bit platforms results in
error:

> + sudo /usr/share/dpdk/tools/dpdk-procinfo -- --show-port -p
> 0xffffffffffffffff
> Invalid portmask '0xffffffffffffffff'


We have a script that runs periodically and it uses the dpdk-procinfo tool
to collect information about the ports.
It will be ideal to use the same portmask in the script irrespective of the
platform it runs on.

Kindly share your thoughts on this.

Regards,
Subendu.



On Wed, May 4, 2022 at 11:18 PM Stephen Hemminger <
stephen@networkplumber.org> wrote:

> On Tue, 03 May 2022 10:47:58 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > 24/04/2022 07:34, Subendu Santra:
> > > Hi Stephen,
> > >
> > > We were going through the patch set:
> https://inbox.dpdk.org/dev/20200715212228.28010-7-stephen@networkplumber.org/
> and hoping to get clarification on the behaviour if post mask is not
> specified in the input to `dpdk-proc-info` tool.
> > >
> > > Specifically, In PATCH v3 6/7, we see this:
> > > +   /* If no port mask was specified, one will be provided */
> > > +   if (enabled_port_mask == 0) {
> > > +           RTE_ETH_FOREACH_DEV(i) {
> > > +                   enabled_port_mask |= 1u << i;
> > >
> > > However, in PATCH v4 8/8, we see this:
> > > +   /* If no port mask was specified, then show non-owned ports */
> > > +   if (enabled_port_mask == 0) {
> > > +           RTE_ETH_FOREACH_DEV(i)
> > > +                   enabled_port_mask = 1ul << i;
> > > +   }
> > >
> > > Was there any specific reason to show just the last non-owned port in
> case the port mask was not specified?
> > > Should we show all non-owned ports in case the user doesn’t specify
> any port mask?
> >
> > It looks like a bug. It should be |=
> > Feel free to send a fix.
> >
> >
>
> Agree. Thats a bug.
>
> It would be good to have a "show all ports" flag to proc-info.
> To show all ports including owned.
>

[-- Attachment #2: Type: text/html, Size: 4213 bytes --]

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Stephen Hemminger]

On Tue, 10 May 2022 14:39:05 +0530
Subendu Santra <subendu@arista.com> wrote:

> Hi Stephen, Thomas,
> 
> On a related note w.r.to commit 1dd6cffb6571f816d5a0d1fd620f43532240b40b
> (app/procinfo: provide way to request info on owned ports), we see this
> change:
> 
> -static uint32_t enabled_port_mask;
> > +static unsigned long enabled_port_mask;  
> 
> 
> While this is ok for 64-bit machines, where unsigned long is 64-bit, on
> 32-bit machines unsigned long is 32-bits.
> Should we change this to unsigned long long which is guaranteed to be
> 64-bits on both architectures?
> 
> Specifying a mask of 0xffffffffffffffff on 32-bit platforms results in
> error:
> 
> > + sudo /usr/share/dpdk/tools/dpdk-procinfo -- --show-port -p
> > 0xffffffffffffffff
> > Invalid portmask '0xffffffffffffffff'  
> 
> 
> We have a script that runs periodically and it uses the dpdk-procinfo tool
> to collect information about the ports.
> It will be ideal to use the same portmask in the script irrespective of the
> platform it runs on.
> 
> Kindly share your thoughts on this.
> 
> Regards,
> Subendu.
> 
> 
> 
> On Wed, May 4, 2022 at 11:18 PM Stephen Hemminger <
> stephen@networkplumber.org> wrote:  
> 
> > On Tue, 03 May 2022 10:47:58 +0200
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >  
> > > 24/04/2022 07:34, Subendu Santra:  
> > > > Hi Stephen,
> > > >
> > > > We were going through the patch set:  
> > https://inbox.dpdk.org/dev/20200715212228.28010-7-stephen@networkplumber.org/
> > and hoping to get clarification on the behaviour if post mask is not
> > specified in the input to `dpdk-proc-info` tool.  
> > > >
> > > > Specifically, In PATCH v3 6/7, we see this:
> > > > +   /* If no port mask was specified, one will be provided */
> > > > +   if (enabled_port_mask == 0) {
> > > > +           RTE_ETH_FOREACH_DEV(i) {
> > > > +                   enabled_port_mask |= 1u << i;
> > > >
> > > > However, in PATCH v4 8/8, we see this:
> > > > +   /* If no port mask was specified, then show non-owned ports */
> > > > +   if (enabled_port_mask == 0) {
> > > > +           RTE_ETH_FOREACH_DEV(i)
> > > > +                   enabled_port_mask = 1ul << i;
> > > > +   }
> > > >
> > > > Was there any specific reason to show just the last non-owned port in  
> > case the port mask was not specified?  
> > > > Should we show all non-owned ports in case the user doesn’t specify  
> > any port mask?  
> > >
> > > It looks like a bug. It should be |=
> > > Feel free to send a fix.
> > >
> > >  
> >
> > Agree. Thats a bug.
> >
> > It would be good to have a "show all ports" flag to proc-info.
> > To show all ports including owned.
> >  

Using uint64_t is better, but eventually many DPDK utilities need to be
fixed to handle > 64 ports.

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Subendu Santra]

Agreed. I will change it to uint64_t and send it for review.
Thanks for your help.

Regards,
Subendu.


On Wed, May 11, 2022 at 1:32 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue, 10 May 2022 14:39:05 +0530
> Subendu Santra <subendu@arista.com> wrote:
>
> > Hi Stephen, Thomas,
> >
> > On a related note w.r.to commit 1dd6cffb6571f816d5a0d1fd620f43532240b40b
> > (app/procinfo: provide way to request info on owned ports), we see this
> > change:
> >
> > -static uint32_t enabled_port_mask;
> > > +static unsigned long enabled_port_mask;
> >
> >
> > While this is ok for 64-bit machines, where unsigned long is 64-bit, on
> > 32-bit machines unsigned long is 32-bits.
> > Should we change this to unsigned long long which is guaranteed to be
> > 64-bits on both architectures?
> >
> > Specifying a mask of 0xffffffffffffffff on 32-bit platforms results in
> > error:
> >
> > > + sudo /usr/share/dpdk/tools/dpdk-procinfo -- --show-port -p
> > > 0xffffffffffffffff
> > > Invalid portmask '0xffffffffffffffff'
> >
> >
> > We have a script that runs periodically and it uses the dpdk-procinfo tool
> > to collect information about the ports.
> > It will be ideal to use the same portmask in the script irrespective of the
> > platform it runs on.
> >
> > Kindly share your thoughts on this.
> >
> > Regards,
> > Subendu.
> >
> >
> >
> > On Wed, May 4, 2022 at 11:18 PM Stephen Hemminger <
> > stephen@networkplumber.org> wrote:
> >
> > > On Tue, 03 May 2022 10:47:58 +0200
> > > Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > > 24/04/2022 07:34, Subendu Santra:
> > > > > Hi Stephen,
> > > > >
> > > > > We were going through the patch set:
> > > https://inbox.dpdk.org/dev/20200715212228.28010-7-stephen@networkplumber.org/
> > > and hoping to get clarification on the behaviour if post mask is not
> > > specified in the input to `dpdk-proc-info` tool.
> > > > >
> > > > > Specifically, In PATCH v3 6/7, we see this:
> > > > > +   /* If no port mask was specified, one will be provided */
> > > > > +   if (enabled_port_mask == 0) {
> > > > > +           RTE_ETH_FOREACH_DEV(i) {
> > > > > +                   enabled_port_mask |= 1u << i;
> > > > >
> > > > > However, in PATCH v4 8/8, we see this:
> > > > > +   /* If no port mask was specified, then show non-owned ports */
> > > > > +   if (enabled_port_mask == 0) {
> > > > > +           RTE_ETH_FOREACH_DEV(i)
> > > > > +                   enabled_port_mask = 1ul << i;
> > > > > +   }
> > > > >
> > > > > Was there any specific reason to show just the last non-owned port in
> > > case the port mask was not specified?
> > > > > Should we show all non-owned ports in case the user doesn’t specify
> > > any port mask?
> > > >
> > > > It looks like a bug. It should be |=
> > > > Feel free to send a fix.
> > > >
> > > >
> > >
> > > Agree. Thats a bug.
> > >
> > > It would be good to have a "show all ports" flag to proc-info.
> > > To show all ports including owned.
> > >
>
> Using uint64_t is better, but eventually many DPDK utilities need to be
> fixed to handle > 64 ports.

[dpdk-dev] [PATCH 0/7] proc-info enhancements

[Stephen Hemminger]

The current proc-info command is useful for diagnosing issues
with external DPDK applications, but the display is limited
and somewhat ugly. This patchset adds some enhancements which
show more info and suppress unnecessary stuff.

Before:

EAL: Detected 4 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket_638764_15dfaa1a166a
EAL: Selected IOVA mode 'PA'
EAL: Probing VFIO support...
EAL: PCI device ae9f:00:02.0 on NUMA socket 0
EAL:   probe driver: 15b3:1014 net_mlx5
========== show - Port PMD 3490000000==========
===== Port (1)=====
  - generic config
	  -- Socket 0
	  -- link speed 40000 duplex 1, auto neg 1 status 1
	  -- promiscuous (1)
	  -- mtu (1500)
  - queue
	  -- queue 0 rx scatter 0 descriptors 256 offloads 0x0 mempool socket 0
  - cyrpto context
	  -- security context - (nil)
===== Port (2)=====
  - generic config
	  -- Socket 0
	  -- link speed 10000 duplex 1, auto neg 1 status 1
	  -- promiscuous (1)
	  -- mtu (1500)
  - queue
	  -- queue 0 rx scatter 0 descriptors 512 offloads 0x0 mempool socket 0
  - cyrpto context
	  -- security context - (nil)
================================================================================
======================================== ========================================

After:
========== show - Port PMD ==========
===== Port 1 =====
  - generic config
	  -- driver net_netvsc device 4179c815-5d8a-4915-976e-9ea2378e382b socket 0
	  -- link speed 40Gbps (auto neg), duplex full, up
	  -- mac 00:15:5D:01:10:02
	  -- promiscuous (1)
	  -- mtu (1500)
  - rx queue
	  -- 0 descriptors 0/256 offloads 0 socket 0
  - tx queue
	  -- 0 descriptors 256/256 offloads 0
===== Port 2 =====
  - generic config
	  -- driver net_netvsc device d8e21696-8885-4567-baf6-1d1cefdf6231 socket 0
	  -- link speed 10Gbps (auto neg), duplex full, up
	  -- mac 00:15:5D:01:10:09
	  -- promiscuous (1)
	  -- mtu (1500)
  - rx queue
	  -- 0 descriptors 0/512 offloads 0 socket 0
  - tx queue
	  -- 0 descriptors 512/512 offloads 0

Stephen Hemminger (7):
  app/proc-info: remove unused logtype #define
  app/proc-info: eliminate useless borders
  app/proc-info: hide EAL info messages
  app/proc-info: add more info to show_ports
  app/proc-info: hide crypto-context display
  app/proc-info: dump rx and tx descriptor info
  app/proc-info: provide way to request info on owned ports

 app/proc-info/Makefile |   3 +
 app/proc-info/main.c   | 283 ++++++++++++++++++++++++++++-------------
 2 files changed, 197 insertions(+), 89 deletions(-)

-- 
2.20.1

[dpdk-dev] [PATCH v3 0/7] app/proc-info enhancments

[Stephen Hemminger]

The current proc-info command is useful for diagnosing issues
with external DPDK applications, but the display is limited
and somewhat ugly. This patchset adds some enhancements which
show more info and suppress unnecessary stuff.

v3 - consolidate chages for displaying crypto info
v2 - fix checkpatch complaints

Hemant Agrawal (1):
  app/proc-info: add crypto security context info

Stephen Hemminger (6):
  app/proc-info: remove unused logtype #define
  app/proc-info: eliminate useless borders
  app/proc-info: hide EAL info messages
  app/proc-info: add more info to show_ports
  app/proc-info: dump rx and tx descriptor info
  app/proc-info: provide way to request info on owned ports

 app/proc-info/Makefile |   3 +
 app/proc-info/main.c   | 368 +++++++++++++++++++++++++++--------------
 2 files changed, 250 insertions(+), 121 deletions(-)

-- 
2.27.0

[dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Stephen Hemminger]

There are cases where a port maybe owned by another (failsafe, netvsc,
bond); but currently proc-info has no way to look at stats of those
ports. This patch provides way for the user to explicitly ask for these
ports.

If no portmask is given the output is unchanged; it only shows the
top level ports. If portmask requests a specific port it will be
shown even if owned.

The device owner is also a useful thing to show in port info.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 app/proc-info/Makefile |  3 ++
 app/proc-info/main.c   | 74 ++++++++++++++++++++++++++++--------------
 2 files changed, 53 insertions(+), 24 deletions(-)

diff --git a/app/proc-info/Makefile b/app/proc-info/Makefile
index 214f3f54a1e9..f777e037861f 100644
--- a/app/proc-info/Makefile
+++ b/app/proc-info/Makefile
@@ -5,7 +5,10 @@ include $(RTE_SDK)/mk/rte.vars.mk
 
 APP = dpdk-procinfo
 
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
+CFLAGS += -Wno-deprecated-declarations
 
 # all source are stored in SRCS-y
 
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 5000724fcdd1..14c04f8367f1 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -12,6 +12,7 @@
 #include <stdlib.h>
 #include <getopt.h>
 #include <unistd.h>
+#include <strings.h>
 
 #include <rte_eal.h>
 #include <rte_common.h>
@@ -676,19 +677,26 @@ eth_tx_queue_available(uint16_t port_id, uint16_t queue_id, uint16_t n)
 static void
 show_port(void)
 {
-	uint16_t i = 0;
-	int ret = 0, j, k;
+	uint32_t port_mask = enabled_port_mask;
+	int i, ret, j, k;
 
 	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD ");
 	STATS_BDR_STR(10, bdr_str);
 
-	RTE_ETH_FOREACH_DEV(i) {
+	for (port_mask = enabled_port_mask; port_mask != 0;
+	     port_mask &= ~(1u << i)) {
 		uint16_t mtu = 0;
 		struct rte_eth_link link;
 		struct rte_eth_dev_info dev_info;
 		struct rte_eth_rss_conf rss_conf;
 		struct rte_eth_fc_conf fc_conf;
 		struct rte_ether_addr mac;
+		struct rte_eth_dev_owner owner;
+
+		i = ffs(port_mask) - 1;
+
+		if (!rte_eth_dev_is_valid_port(i))
+			continue;
 
 		memset(&rss_conf, 0, sizeof(rss_conf));
 
@@ -707,6 +715,11 @@ show_port(void)
 		       dev_info.driver_name, dev_info.device->name,
 		       rte_eth_dev_socket_id(i));
 
+		ret = rte_eth_dev_owner_get(i, &owner);
+		if (ret == 0 && owner.id != RTE_ETH_DEV_NO_OWNER)
+			printf("\t --  owner %#"PRIx64":%s\n",
+			       owner.id, owner.name);
+
 		ret = rte_eth_link_get(i, &link);
 		if (ret < 0) {
 			printf("Link get failed (port %u): %s\n",
@@ -1351,6 +1364,7 @@ main(int argc, char **argv)
 	char log_flag[] = "--log-level=6";
 	char *argp[argc + 4];
 	uint16_t nb_ports;
+	uint32_t port_mask;
 
 	/* preparse app arguments */
 	ret = proc_info_preparse_args(argc, argv);
@@ -1394,30 +1408,42 @@ main(int argc, char **argv)
 	if (nb_ports == 0)
 		rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
 
-	/* If no port mask was specified*/
-	if (enabled_port_mask == 0)
-		enabled_port_mask = 0xffff;
-
-	RTE_ETH_FOREACH_DEV(i) {
-		if (enabled_port_mask & (1 << i)) {
-			if (enable_stats)
-				nic_stats_display(i);
-			else if (enable_xstats)
-				nic_xstats_display(i);
-			else if (reset_stats)
-				nic_stats_clear(i);
-			else if (reset_xstats)
-				nic_xstats_clear(i);
-			else if (enable_xstats_name)
-				nic_xstats_by_name_display(i, xstats_name);
-			else if (nb_xstats_ids > 0)
-				nic_xstats_by_ids_display(i, xstats_ids,
-						nb_xstats_ids);
-			else if (enable_metrics)
-				metrics_display(i);
+	/* If no port mask was specified, one will be provided */
+	if (enabled_port_mask == 0) {
+		RTE_ETH_FOREACH_DEV(i) {
+			enabled_port_mask |= 1u << i;
 		}
 	}
 
+	for (port_mask = enabled_port_mask; port_mask != 0;
+	     port_mask &= ~(1u << i)) {
+		/* ffs() first bit is 1 not 0 */
+		i = ffs(port_mask) - 1;
+
+		if (i >= RTE_MAX_ETHPORTS)
+			break;
+
+		if (!rte_eth_dev_is_valid_port(i))
+			continue;
+
+		if (enable_stats)
+			nic_stats_display(i);
+		else if (enable_xstats)
+			nic_xstats_display(i);
+		else if (reset_stats)
+			nic_stats_clear(i);
+		else if (reset_xstats)
+			nic_xstats_clear(i);
+		else if (enable_xstats_name)
+			nic_xstats_by_name_display(i, xstats_name);
+		else if (nb_xstats_ids > 0)
+			nic_xstats_by_ids_display(i, xstats_ids,
+						  nb_xstats_ids);
+		else if (enable_metrics)
+			metrics_display(i);
+
+	}
+
 	/* print port independent stats */
 	if (enable_metrics)
 		metrics_display(RTE_METRICS_GLOBAL);
-- 
2.27.0

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Thomas Monjalon]

15/07/2020 23:22, Stephen Hemminger:
> --- a/app/proc-info/Makefile
> +++ b/app/proc-info/Makefile
> +CFLAGS += -DALLOW_EXPERIMENTAL_API

not needed in app/

> +CFLAGS += -O3
>  CFLAGS += $(WERROR_FLAGS)
> +CFLAGS += -Wno-deprecated-declarations

Which deprecated function is used?
We must not use deprecated functions.

> +	/* If no port mask was specified, one will be provided */

Would be nice to help the user by printing a port mask
of owned and unowned ports.

> +	if (enabled_port_mask == 0) {
> +		RTE_ETH_FOREACH_DEV(i) {
> +			enabled_port_mask |= 1u << i;
>  		}
>  	}
>  
> +	for (port_mask = enabled_port_mask; port_mask != 0;
> +	     port_mask &= ~(1u << i)) {

Please would be good to help drunk or sleepy readers with few comments.

> +		/* ffs() first bit is 1 not 0 */
> +		i = ffs(port_mask) - 1;
> +
> +		if (i >= RTE_MAX_ETHPORTS)
> +			break;

This check is already done in rte_eth_dev_is_valid_port().

> +
> +		if (!rte_eth_dev_is_valid_port(i))
> +			continue;

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Stephen Hemminger]

On Fri, 17 Jul 2020 17:01:00 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 15/07/2020 23:22, Stephen Hemminger:
> > --- a/app/proc-info/Makefile
> > +++ b/app/proc-info/Makefile
> > +CFLAGS += -DALLOW_EXPERIMENTAL_API  
> 
> not needed in app/
> 
> > +CFLAGS += -O3
> >  CFLAGS += $(WERROR_FLAGS)
> > +CFLAGS += -Wno-deprecated-declarations  
> 
> Which deprecated function is used?
> We must not use deprecated functions.

Fixing.

> 
> > +	/* If no port mask was specified, one will be provided */  
> 
> Would be nice to help the user by printing a port mask
> of owned and unowned ports.

Not needed, since each display already has the port #

> 
> > +	if (enabled_port_mask == 0) {
> > +		RTE_ETH_FOREACH_DEV(i) {
> > +			enabled_port_mask |= 1u << i;
> >  		}
> >  	}
> >  
> > +	for (port_mask = enabled_port_mask; port_mask != 0;
> > +	     port_mask &= ~(1u << i)) {  
> 
> Please would be good to help drunk or sleepy readers with few comments.
ok?

> 
> > +		/* ffs() first bit is 1 not 0 */
> > +		i = ffs(port_mask) - 1;
> > +
> > +		if (i >= RTE_MAX_ETHPORTS)
> > +			break;  
> 
> This check is already done in rte_eth_dev_is_valid_port().

Want to stop early if port is out of range,
but continue if hits a port that is owned.


> 
> > +
> > +		if (!rte_eth_dev_is_valid_port(i))
> > +			continue;  
> 
> 
> 

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Thomas Monjalon]

21/07/2020 19:05, Stephen Hemminger:
> On Fri, 17 Jul 2020 17:01:00 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> > 15/07/2020 23:22, Stephen Hemminger:
> > > +	/* If no port mask was specified, one will be provided */  
> > 
> > Would be nice to help the user by printing a port mask
> > of owned and unowned ports.
> 
> Not needed, since each display already has the port #

By default, owned ports are not displayed at all.
How are we supposed to find them?

> > > +	if (enabled_port_mask == 0) {
> > > +		RTE_ETH_FOREACH_DEV(i) {
> > > +			enabled_port_mask |= 1u << i;
> > >  		}
> > >  	}
> > >  
> > > +	for (port_mask = enabled_port_mask; port_mask != 0;
> > > +	     port_mask &= ~(1u << i)) {  
> > 
> > Please would be good to help drunk or sleepy readers with few comments.
> ok?

Comments in the code I mean.

> > > +		/* ffs() first bit is 1 not 0 */
> > > +		i = ffs(port_mask) - 1;
> > > +
> > > +		if (i >= RTE_MAX_ETHPORTS)
> > > +			break;  
> > 
> > This check is already done in rte_eth_dev_is_valid_port().
> 
> Want to stop early if port is out of range,
> but continue if hits a port that is owned.

OK

> > > +
> > > +		if (!rte_eth_dev_is_valid_port(i))
> > > +			continue;  

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

[Stephen Hemminger]

On Tue, 21 Jul 2020 19:08:57 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 21/07/2020 19:05, Stephen Hemminger:
> > On Fri, 17 Jul 2020 17:01:00 +0200
> > Thomas Monjalon <thomas@monjalon.net> wrote:  
> > > 15/07/2020 23:22, Stephen Hemminger:  
> > > > +	/* If no port mask was specified, one will be provided */    
> > > 
> > > Would be nice to help the user by printing a port mask
> > > of owned and unowned ports.  
> > 
> > Not needed, since each display already has the port #  
> 
> By default, owned ports are not displayed at all.
> How are we supposed to find them?

You have to pass it in portmask.
The alternative would be to show all ports and mark those that are owned.

The ownership model API does not support a way to ask for either
"tell me which other port owns port X" or "iterate over all the ports owned by Y".
The problem is that the owner id is generic and stored inside the PMD.
The root cause is that the original design of port ownership was targeting
a more general use case that was never used. I would have been happier with
a simpler parent port id index in ethdev instead.