DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports
@ 2022-04-24  5:34 Subendu Santra
  2022-05-03  5:29 ` Subendu Santra
  2022-05-03  8:47 ` Thomas Monjalon
  0 siblings, 2 replies; 12+ messages in thread
From: Subendu Santra @ 2022-04-24  5:34 UTC (permalink / raw)
  To: stephen
  Cc: dev, hemant.agrawal, maryam.tahhan, reshma.pattan, Sriram Rajagopalan

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

Hi Stephen,

We were going through the patch set: https://inbox.dpdk.org/dev/20200715212228.28010-7-stephen@networkplumber.org/ and hoping to get clarification on the behaviour if post mask is not specified in the input to `dpdk-proc-info` tool.

Specifically, In PATCH v3 6/7, we see this:
+	/* If no port mask was specified, one will be provided */
+	if (enabled_port_mask == 0) {
+		RTE_ETH_FOREACH_DEV(i) {
+			enabled_port_mask |= 1u << i;

However, in PATCH v4 8/8, we see this:
+	/* If no port mask was specified, then show non-owned ports */
+	if (enabled_port_mask == 0) {
+		RTE_ETH_FOREACH_DEV(i)
+			enabled_port_mask = 1ul << i;
+	}

Was there any specific reason to show just the last non-owned port in case the port mask was not specified?
Should we show all non-owned ports in case the user doesn’t specify any port mask?

Regards,
Subendu.




[-- Attachment #2: Type: text/html, Size: 2119 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH 0/7] proc-info enhancements
@ 2020-05-06 19:37 Stephen Hemminger
  2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 0/7] app/proc-info enhancments Stephen Hemminger
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Hemminger @ 2020-05-06 19:37 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

The current proc-info command is useful for diagnosing issues
with external DPDK applications, but the display is limited
and somewhat ugly. This patchset adds some enhancements which
show more info and suppress unnecessary stuff.

Before:

EAL: Detected 4 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket_638764_15dfaa1a166a
EAL: Selected IOVA mode 'PA'
EAL: Probing VFIO support...
EAL: PCI device ae9f:00:02.0 on NUMA socket 0
EAL:   probe driver: 15b3:1014 net_mlx5
========== show - Port PMD 3490000000==========
===== Port (1)=====
  - generic config
	  -- Socket 0
	  -- link speed 40000 duplex 1, auto neg 1 status 1
	  -- promiscuous (1)
	  -- mtu (1500)
  - queue
	  -- queue 0 rx scatter 0 descriptors 256 offloads 0x0 mempool socket 0
  - cyrpto context
	  -- security context - (nil)
===== Port (2)=====
  - generic config
	  -- Socket 0
	  -- link speed 10000 duplex 1, auto neg 1 status 1
	  -- promiscuous (1)
	  -- mtu (1500)
  - queue
	  -- queue 0 rx scatter 0 descriptors 512 offloads 0x0 mempool socket 0
  - cyrpto context
	  -- security context - (nil)
================================================================================
======================================== ========================================

After:
========== show - Port PMD ==========
===== Port 1 =====
  - generic config
	  -- driver net_netvsc device 4179c815-5d8a-4915-976e-9ea2378e382b socket 0
	  -- link speed 40Gbps (auto neg), duplex full, up
	  -- mac 00:15:5D:01:10:02
	  -- promiscuous (1)
	  -- mtu (1500)
  - rx queue
	  -- 0 descriptors 0/256 offloads 0 socket 0
  - tx queue
	  -- 0 descriptors 256/256 offloads 0
===== Port 2 =====
  - generic config
	  -- driver net_netvsc device d8e21696-8885-4567-baf6-1d1cefdf6231 socket 0
	  -- link speed 10Gbps (auto neg), duplex full, up
	  -- mac 00:15:5D:01:10:09
	  -- promiscuous (1)
	  -- mtu (1500)
  - rx queue
	  -- 0 descriptors 0/512 offloads 0 socket 0
  - tx queue
	  -- 0 descriptors 512/512 offloads 0

Stephen Hemminger (7):
  app/proc-info: remove unused logtype #define
  app/proc-info: eliminate useless borders
  app/proc-info: hide EAL info messages
  app/proc-info: add more info to show_ports
  app/proc-info: hide crypto-context display
  app/proc-info: dump rx and tx descriptor info
  app/proc-info: provide way to request info on owned ports

 app/proc-info/Makefile |   3 +
 app/proc-info/main.c   | 283 ++++++++++++++++++++++++++++-------------
 2 files changed, 197 insertions(+), 89 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-05-11  7:37 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24  5:34 [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports Subendu Santra
2022-05-03  5:29 ` Subendu Santra
2022-05-03  8:47 ` Thomas Monjalon
2022-05-04 17:48   ` Stephen Hemminger
2022-05-10  9:09     ` Subendu Santra
2022-05-10 20:02       ` Stephen Hemminger
2022-05-11  7:36         ` Subendu Santra
  -- strict thread matches above, loose matches on Subject: below --
2020-05-06 19:37 [dpdk-dev] [PATCH 0/7] proc-info enhancements Stephen Hemminger
2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 0/7] app/proc-info enhancments Stephen Hemminger
2020-07-15 21:22   ` [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports Stephen Hemminger
2020-07-17 15:01     ` Thomas Monjalon
2020-07-21 17:05       ` Stephen Hemminger
2020-07-21 17:08         ` Thomas Monjalon
2020-07-21 17:37           ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).