From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A062463A5; Thu, 13 Mar 2025 15:35:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45EFA40FDE; Thu, 13 Mar 2025 15:35:24 +0100 (CET) Received: from fhigh-a3-smtp.messagingengine.com (fhigh-a3-smtp.messagingengine.com [103.168.172.154]) by mails.dpdk.org (Postfix) with ESMTP id 8577540150 for ; Thu, 13 Mar 2025 15:35:23 +0100 (CET) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 232181140223; Thu, 13 Mar 2025 10:35:23 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Thu, 13 Mar 2025 10:35:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1741876523; x=1741962923; bh=Gbxz8s3Tqdc0E0m3HaZBhYGGYdQ3hxsRB6OuyufzWIU=; b= oRAI+Za38Tt+KCz/XM7KFHd8zL5IjIxJpX7wdjrwgsOsXSIxZSHJecFku0JoN3nL ej1E2Jh4QLtYZnKiYNkjp5tofR/rk6DTMZrniEgwK1nz9gIhyjVachuZNGtEGIXF rW2xC/piAURIaKb4pjHriq1kqwhaDkbn2RKTCuIMWH4uqIZIiZV37mrzVjOlRBI7 DlaYboChbqb8GgIeRJ33S0aeyX8ctSpALLEbcm6dhueqwMfXJBRiyrzxhrIOpPGJ O4F8iKOXhIE38ssIg4/u+aEQLRandld+OXUD6PKA0Ct+8vaFKx3XB6Y/+JBJKyiE iMtD3f6VeYXQLt8Vr5tvbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1741876523; x= 1741962923; bh=Gbxz8s3Tqdc0E0m3HaZBhYGGYdQ3hxsRB6OuyufzWIU=; b=k 9TMHaogVsDQxkpGYCmKKuS8NvhyOPP4LXKIoYcJbuqwjWgecDVYDISA1J0ux3GRg fd57t/JSPUQ+GzVr5UjN+PerKrjSn8gCmZa0Sofjg8BjjL+wRhE07neLBgpG9o6a NQB2h4p7I0nLdXsV4vyVkvoXZV0EfL2/hVXgw1hIyoWL9VmGlzqbCWxKpkq639UU c7AosPEJzQSxztC0qvCVlzwE48b/cuuCmFQYlKkD3clbcW7ii0m0exZ6Dgz6TRJR F9Pn+v7uYUkjy7Y7Nuy0Ek8y7taUaCjkTeY55MNXzc6ojuqrl4Ee6odFQnHuKFP8 Lw48WLN3OXVYJiL00udjw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdekvddtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddt jeenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonh hjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdej vedtheevtdekiedvueeuvdeiuddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght pdhnsggprhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehmsg esshhmrghrthhshhgrrhgvshihshhtvghmshdrtghomhdprhgtphhtthhopegsrhhutggv rdhrihgthhgrrhgushhonhesihhnthgvlhdrtghomhdprhgtphhtthhopehsthgvphhhvg hnsehnvghtfihorhhkphhluhhmsggvrhdrohhrghdprhgtphhtthhopeguvghvseguphgu khdrohhrghdprhgtphhtthhopehrohhrvghtiihlrgeslhhinhhugidrmhhitghrohhsoh hfthdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Mar 2025 10:35:21 -0400 (EDT) From: Thomas Monjalon To: Morten =?UTF-8?B?QnLDuHJ1cA==?= , Bruce Richardson Cc: Stephen Hemminger , dev@dpdk.org, Tyler Retzlaff Subject: Re: [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD Date: Thu, 13 Mar 2025 15:35:20 +0100 Message-ID: <3711940.zToM8qfIzz@thomas> In-Reply-To: References: <20250127180842.97907-1-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35E9FAF6@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 13/03/2025 09:56, Bruce Richardson: > On Thu, Mar 13, 2025 at 09:00:09AM +0100, Morten Br=C3=B8rup wrote: > > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > Sent: Thursday, 13 March 2025 00.02 > > >=20 > > > On Wed, 19 Feb 2025 15:55:17 +0100 > > > Thomas Monjalon wrote: > > >=20 > > > > 14/02/2025 18:20, Stephen Hemminger: > > > > > The Linux version of sys/queue.h is frozen at an older version > > > > > and is missing the _SAFE macro variants. Several drivers started > > > > > introducing the own workarounds for this. Should be handled in EA= L. > > > > > > > > > > Signed-off-by: Stephen Hemminger > > > > > > > > We may want to unify with lib/eal/windows/include/sys/queue.h > > > > > > > > > > >=20 > > > Not sure, we have several options here: > > > 1. Keep using Linux sys/queue.h and add enhancements in rte_queue.h > > > 2. Make rte_queue.h a copy of FreeBSD version of queue.h (that is > > > what Windows did) > > > 3. Use the bsd version of queue.h. > > > On Debian/Ubuntu this in libbsd-dev package and referred to as > > > bsd/sys/queue.h > > >=20 > > > I chose #1 as simplest. But all of these could work. #3 means DPDK has > > > least new > > > code, but adds another dependency to the build. > >=20 > > +1 to #2: > > If Linux sys/queue.h is frozen, and is a subset of FreeBSD queue.h, #2 = would consolidate all the queue macros in one file. > > That seems easier to navigate (for a developer/reviewer looking at the = macro definitions/implementations) than including sys/queue.h, queue.h or l= ib/eal/windows/include/sys/queue.h depending on O/S, and then defining the = missing macros in rte_queue.h. > > A comment at the top of the rte_queue.h file could mention that it is a= copy of the FreeBSD queue.h file. > >=20 > > -1 to #3; it adds an unnecessary dependency. > >=20 > > >=20 > > > No matter what, should add to checkpatch to block any new files that > > > include sys/queue.h > > > directly. > >=20 > > +1 to this. > >=20 >=20 > I agree with Morten, #2 looks the best option to me too. It means we want to remove lib/eal/windows/include/sys/queue.h, right?