From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3976A04DD; Wed, 28 Oct 2020 08:21:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32A0272F0; Wed, 28 Oct 2020 08:21:26 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5684972EC for <dev@dpdk.org>; Wed, 28 Oct 2020 08:21:25 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E55BF5C0113; Wed, 28 Oct 2020 03:21:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 28 Oct 2020 03:21:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 5unkiTKVPIR7rbe3ZLrmkNzFmzHcwMFnIyO1VaEjGh0=; b=p6U1ma0qbK8n8XIs qDyLJrUQCfWTgNZKcAdlWwudw2JEbN5ic14knH5lUBrCT+Iuxo1cAtTphPvjj1Om AD59ryh5cK4CSnT1ofKAhpoQPSwRnDM6eNI0YBvDTbTR94NxAwmckQHtC/UxoeBI OjiRrjOmlAd+BSwYHyPVVZYQxurRoCZFChVOHUBJz0OUPUmWWW7JhgfKm6kFA1+B /1Ozdtwi3hIpyw99pccR9vzhqfgM5al8GNnBWk1KzY/07NjfwulMynkgjWvYi510 BFS51oG9/fhEGRQwubh4kpuNtlN6IAkpGmY7zZcKTosdeORPauuJ70QJXNrLvHdY uhHoLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=5unkiTKVPIR7rbe3ZLrmkNzFmzHcwMFnIyO1VaEjG h0=; b=Mk/3+/Newgc50JBEy2NERUfgJkXgl0zPFz5VDS3BMgrUDkIvPQgTsUEC0 BIfJyhRhUBssifRxpvbjlUUsGBFC1W40LZyBeeLSZXMHkshUUInve/BMI0q/C3Fc a+uvoC6hdpVmrf8Bjc3FGjpMaClScyYCCahf3ZPlR0+wHe6kmDroNML6BA7XfoYN zt8Eq+ybp+DHQ7qvyIlCLVvuu2yXSbPw+QDvXxtvE7H9bviB3gZNvjlLTBkN9QBb DjqBFH5LYw+oYxDvx+yHtwU+NHQCytU8DgWni32EKhmWWwZqhuF/M/g2+VcIb4nM sx89Lmq494iOf3+0aVjCP/TsQ/R4A== X-ME-Sender: <xms:8xuZX4nBMaS8Hc_C9WTbJxzPDRwl27wiHy7vmkypNTitt1U3seQ50Q> <xme:8xuZX32ZUh3kxpaRRp3JB0no9CRvS-wXyDtiEETO7yHo7vSNdHvBc8NVo0HJa1VrF kY4zCFqQ4sVl4_NvQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrledtgddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:8xuZX2oAro7Kvcj3EprDvNCdvGOeBpj6NMlx1yi1yYGs8U9HU2FP3A> <xmx:8xuZX0nVEKdaOwtclDlRECgv24G-rzCPMnJfIP7K9WH9bBGEeUj0UA> <xmx:8xuZX20qWmtIQev37Fg3wwKFjaE8A48NbMxo4kCjFZQwfU-lKbfFIw> <xmx:8xuZX7x8QZtWNNU1wQK31zXHOn2F5qaRXqu1r_5OlYqEpeb7BI3Klw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BD72E306467D; Wed, 28 Oct 2020 03:21:22 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ophir Munk <ophirmu@nvidia.com> Cc: dev@dpdk.org, Raslan Darawsheh <rasland@nvidia.com>, Matan Azrad <matan@nvidia.com>, Tal Shnaiderman <talshn@nvidia.com>, Suanming Mou <suanmingm@nvidia.com> Date: Wed, 28 Oct 2020 08:21:21 +0100 Message-ID: <3722409.7TIejfC7EG@thomas> In-Reply-To: <20201027232335.31427-39-ophirmu@nvidia.com> References: <20201027232335.31427-1-ophirmu@nvidia.com> <20201027232335.31427-39-ophirmu@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 38/72] net/mlx5/windows: add pthread initializer definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 28/10/2020 00:23, Ophir Munk: > PTHREAD_MUTEX_INITIALIZER is a Linux macro defined in > /usr/include/pthread.h. It is used by mlx5 PMD but it is not included > in DPDK Windows pthread implementation. Therefore define it privately > in windows/mlx5_os.h file. You should not define EAL stuff privately in the PMD. I remember Microsoft discouraged the definition of mutex initializer. Instead we have pthread_mutex_init().